Re: [PATCH] DRM: Armada: fixup wait_event_timeout being ignored

2015-06-10 Thread Nicholas Mc Guire
On Wed, 10 Jun 2015, Russell King - ARM Linux wrote: > On Wed, Jun 10, 2015 at 01:07:08PM +0200, Nicholas Mc Guire wrote: > > The calling side seems to assume 0 as success and <0 as error so > > returning -ETIME should be fine here. > > The idea here is to allow the remainder of the code to

Re: [PATCH] DRM: Armada: fixup wait_event_timeout being ignored

2015-06-10 Thread Russell King - ARM Linux
On Wed, Jun 10, 2015 at 01:07:08PM +0200, Nicholas Mc Guire wrote: > The calling side seems to assume 0 as success and <0 as error so > returning -ETIME should be fine here. The idea here is to allow the remainder of the code to execute when the condition succeeds _or_ times out. If it times

[PATCH] DRM: Armada: fixup wait_event_timeout being ignored

2015-06-10 Thread Nicholas Mc Guire
event API conformance testing with coccinelle spatches are being used to locate API usage inconsistencies this triggert with: ./drivers/gpu/drm/armada/armada_overlay.c:153 incorrect check for negative return Return type of wait_event_timeout is signed long not int and the return type is

Re: [PATCH] DRM: Armada: fixup wait_event_timeout being ignored

2015-06-10 Thread Nicholas Mc Guire
On Wed, 10 Jun 2015, Russell King - ARM Linux wrote: On Wed, Jun 10, 2015 at 01:07:08PM +0200, Nicholas Mc Guire wrote: The calling side seems to assume 0 as success and 0 as error so returning -ETIME should be fine here. The idea here is to allow the remainder of the code to execute

[PATCH] DRM: Armada: fixup wait_event_timeout being ignored

2015-06-10 Thread Nicholas Mc Guire
event API conformance testing with coccinelle spatches are being used to locate API usage inconsistencies this triggert with: ./drivers/gpu/drm/armada/armada_overlay.c:153 incorrect check for negative return Return type of wait_event_timeout is signed long not int and the return type is

Re: [PATCH] DRM: Armada: fixup wait_event_timeout being ignored

2015-06-10 Thread Russell King - ARM Linux
On Wed, Jun 10, 2015 at 01:07:08PM +0200, Nicholas Mc Guire wrote: The calling side seems to assume 0 as success and 0 as error so returning -ETIME should be fine here. The idea here is to allow the remainder of the code to execute when the condition succeeds _or_ times out. If it times out,