Re: [PATCH] EDAC, mv64x60: Remove some code duplication

2018-01-15 Thread Christophe JAILLET
Le 15/01/2018 à 23:31, Michael Ellerman a écrit : Chris Packham writes: On 14/01/18 06:17, Christophe JAILLET wrote: Le 13/01/2018 à 15:22, Borislav Petkov a écrit : + Chris Packham who's been fixing some stuff in here too. On Sat, Jan 13, 2018 at 08:28:21AM +0100, Christophe JAILLET wrote:

Re: [PATCH] EDAC, mv64x60: Remove some code duplication

2018-01-15 Thread Michael Ellerman
Chris Packham writes: > On 14/01/18 06:17, Christophe JAILLET wrote: >> Le 13/01/2018 à 15:22, Borislav Petkov a écrit : >>> + Chris Packham who's been fixing some stuff in here too. >>> >>> On Sat, Jan 13, 2018 at 08:28:21AM +0100, Christophe JAILLET wrote: Reorder the error handling code in

Re: [PATCH] EDAC, mv64x60: Remove some code duplication

2018-01-14 Thread Chris Packham
Hi Christophe, On 14/01/18 06:17, Christophe JAILLET wrote: > Le 13/01/2018 à 15:22, Borislav Petkov a écrit : >> + Chris Packham who's been fixing some stuff in here too. >> >> On Sat, Jan 13, 2018 at 08:28:21AM +0100, Christophe JAILLET wrote: >>> Reorder the error handling code in order to rele

Re: [PATCH] EDAC, mv64x60: Remove some code duplication

2018-01-13 Thread Christophe JAILLET
Le 13/01/2018 à 15:22, Borislav Petkov a écrit : + Chris Packham who's been fixing some stuff in here too. On Sat, Jan 13, 2018 at 08:28:21AM +0100, Christophe JAILLET wrote: Reorder the error handling code in order to release the resources in reverse order than allocation. Introduce a new 're

Re: [PATCH] EDAC, mv64x60: Remove some code duplication

2018-01-13 Thread Borislav Petkov
+ Chris Packham who's been fixing some stuff in here too. On Sat, Jan 13, 2018 at 08:28:21AM +0100, Christophe JAILLET wrote: > Reorder the error handling code in order to release the resources in > reverse order than allocation. > > Introduce a new 'release_group' label in the error handling pat

[PATCH] EDAC, mv64x60: Remove some code duplication

2018-01-12 Thread Christophe JAILLET
Reorder the error handling code in order to release the resources in reverse order than allocation. Introduce a new 'release_group' label in the error handling path and use it to void some code duplication. Signed-off-by: Christophe JAILLET --- drivers/edac/mv64x60_edac.c | 7 --- 1 file ch