Re: [PATCH] FS: Making aproriate return type

On Thu, May 11, 2017 at 09:44:09AM +0530, Pushkar Jambhlekar wrote: > unsigned_offsets function returns fmode_t but function definition returns > int. sparse generate warning. > Updating proper return type You do realize that it's a predicate? This is actually one case where bool would be

Re: [PATCH] FS: Making aproriate return type

On Thu, May 11, 2017 at 09:44:09AM +0530, Pushkar Jambhlekar wrote: > unsigned_offsets function returns fmode_t but function definition returns > int. sparse generate warning. > Updating proper return type You do realize that it's a predicate? This is actually one case where bool would be

[PATCH] FS: Making aproriate return type

unsigned_offsets function returns fmode_t but function definition returns int. sparse generate warning. Updating proper return type Signed-off-by: Pushkar Jambhlekar --- fs/read_write.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/read_write.c

[PATCH] FS: Making aproriate return type

unsigned_offsets function returns fmode_t but function definition returns int. sparse generate warning. Updating proper return type Signed-off-by: Pushkar Jambhlekar --- fs/read_write.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/read_write.c b/fs/read_write.c index