Re: [PATCH] Fix USB vendor and product IDs endianness for USB HID devices

2007-02-11 Thread Julien BLACHE
Jiri Kosina <[EMAIL PROTECTED]> wrote: Hi, > this is obviously a bug, thanks for a fix, I queued it for upstream. Thanks. > Two nitpicks: > > - could you please submitpatches in standard conventions, so that they > could be applied directly using patch -p1 against toplevel of the kernel >

Re: [PATCH] Fix USB vendor and product IDs endianness for USB HID devices

2007-02-11 Thread Jiri Kosina
On Sat, 10 Feb 2007, Julien BLACHE wrote: > The generic HID layer changes introduced an endianness bug for USB HID > devices. Hi Julien, this is obviously a bug, thanks for a fix, I queued it for upstream. Two nitpicks: - could you please submitpatches in standard conventions, so that they

Re: [PATCH] Fix USB vendor and product IDs endianness for USB HID devices

2007-02-11 Thread Jiri Kosina
On Sat, 10 Feb 2007, Julien BLACHE wrote: The generic HID layer changes introduced an endianness bug for USB HID devices. Hi Julien, this is obviously a bug, thanks for a fix, I queued it for upstream. Two nitpicks: - could you please submitpatches in standard conventions, so that they

Re: [PATCH] Fix USB vendor and product IDs endianness for USB HID devices

2007-02-11 Thread Julien BLACHE
Jiri Kosina [EMAIL PROTECTED] wrote: Hi, this is obviously a bug, thanks for a fix, I queued it for upstream. Thanks. Two nitpicks: - could you please submitpatches in standard conventions, so that they could be applied directly using patch -p1 against toplevel of the kernel tree

[PATCH] Fix USB vendor and product IDs endianness for USB HID devices

2007-02-10 Thread Julien BLACHE
Hi, The generic HID layer changes introduced an endianness bug for USB HID devices. The USB vendor and product IDs are not byteswapped appropriately, and thus come out in the wrong endianness when fetched through the evdev using ioctl() on big endian platforms. This byteswapping used to be done

[PATCH] Fix USB vendor and product IDs endianness for USB HID devices

2007-02-10 Thread Julien BLACHE
Hi, The generic HID layer changes introduced an endianness bug for USB HID devices. The USB vendor and product IDs are not byteswapped appropriately, and thus come out in the wrong endianness when fetched through the evdev using ioctl() on big endian platforms. This byteswapping used to be done