Re: [PATCH] Fix compat regression in process_vm_rw()

2020-10-27 Thread Jens Axboe
On 10/27/20 1:19 PM, damian wrote: > On Mo, 26. Okt 18:03, Jens Axboe wrote: >> The removal of compat_process_vm_{readv,writev} didn't change >> process_vm_rw(), which always assumes it's not doing a compat syscall. >> Instead of passing in 'false' unconditionally for 'compat', make it >>

Re: [PATCH] Fix compat regression in process_vm_rw()

2020-10-27 Thread Naresh Kamboju
On Wed, 28 Oct 2020 at 00:49, damian wrote: > > On Mo, 26. Okt 18:03, Jens Axboe wrote: > > The removal of compat_process_vm_{readv,writev} didn't change > > process_vm_rw(), which always assumes it's not doing a compat syscall. > > Instead of passing in 'false' unconditionally for 'compat', make

Re: [PATCH] Fix compat regression in process_vm_rw()

2020-10-27 Thread damian
On Mo, 26. Okt 18:03, Jens Axboe wrote: > The removal of compat_process_vm_{readv,writev} didn't change > process_vm_rw(), which always assumes it's not doing a compat syscall. > Instead of passing in 'false' unconditionally for 'compat', make it > conditional on in_compat_syscall(). > > Fixes:

Re: [PATCH] Fix compat regression in process_vm_rw()

2020-10-27 Thread Linus Torvalds
On Tue, Oct 27, 2020 at 1:01 AM Christoph Hellwig wrote: > > Independent of this fix I think we just need to explicitly prohibit > cross-access. Well, prohibiting a 32-bit process from accessing a 64-bit one might make sense, since it fundamentally cannot work, and returning an explicit error

Re: [PATCH] Fix compat regression in process_vm_rw()

2020-10-27 Thread Christoph Hellwig
On Tue, Oct 27, 2020 at 12:09:20AM +, Al Viro wrote: > On Mon, Oct 26, 2020 at 06:03:18PM -0600, Jens Axboe wrote: > > The removal of compat_process_vm_{readv,writev} didn't change > > process_vm_rw(), which always assumes it's not doing a compat syscall. > > Instead of passing in 'false'

Re: [PATCH] Fix compat regression in process_vm_rw()

2020-10-27 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH] Fix compat regression in process_vm_rw()

2020-10-26 Thread Kyle Huey
On Mon, Oct 26, 2020 at 5:03 PM Jens Axboe wrote: > > The removal of compat_process_vm_{readv,writev} didn't change > process_vm_rw(), which always assumes it's not doing a compat syscall. > Instead of passing in 'false' unconditionally for 'compat', make it > conditional on in_compat_syscall().

Re: [PATCH] Fix compat regression in process_vm_rw()

2020-10-26 Thread Al Viro
On Mon, Oct 26, 2020 at 06:03:18PM -0600, Jens Axboe wrote: > The removal of compat_process_vm_{readv,writev} didn't change > process_vm_rw(), which always assumes it's not doing a compat syscall. > Instead of passing in 'false' unconditionally for 'compat', make it > conditional on

[PATCH] Fix compat regression in process_vm_rw()

2020-10-26 Thread Jens Axboe
The removal of compat_process_vm_{readv,writev} didn't change process_vm_rw(), which always assumes it's not doing a compat syscall. Instead of passing in 'false' unconditionally for 'compat', make it conditional on in_compat_syscall(). Fixes: c3973b401ef2 ("mm: remove