Re: [PATCH] Fix sched_domain sysctl registration again

2007-10-21 Thread Ingo Molnar
* Milton D. Miller II <[EMAIL PROTECTED]> wrote: > commit 029190c515f15f512ac85de8fc686d4dbd0ae731 (cpuset > sched_load_balance flag) was not tested SCHED_DEBUG enabled as > committed as it dereferences NULL when used and it reordered the > sysctl registration to cause it to never show any

Re: [PATCH] Fix sched_domain sysctl registration again

2007-10-21 Thread Ingo Molnar
* Milton D. Miller II [EMAIL PROTECTED] wrote: commit 029190c515f15f512ac85de8fc686d4dbd0ae731 (cpuset sched_load_balance flag) was not tested SCHED_DEBUG enabled as committed as it dereferences NULL when used and it reordered the sysctl registration to cause it to never show any domains

Re: [PATCH] Fix sched_domain sysctl registration again

2007-10-20 Thread Paul Jackson
Thanks for catching these, Milton. I had done my testing against 2.6.23-rc8-mm2 and earlier, so had not picked up your earlier debug sysctl patches from Oct 12 or so that first fixed this, so had not noticed that the resulting merge of your work and mine was borked. ... somedays even the latest

[PATCH] Fix sched_domain sysctl registration again

2007-10-20 Thread Milton Miller
commit 029190c515f15f512ac85de8fc686d4dbd0ae731 (cpuset sched_load_balance flag) was not tested SCHED_DEBUG enabled as committed as it dereferences NULL when used and it reordered the sysctl registration to cause it to never show any domains or their tunables. Fixes: 1) restore

[PATCH] Fix sched_domain sysctl registration again

2007-10-20 Thread Milton D. Miller II
commit 029190c515f15f512ac85de8fc686d4dbd0ae731 (cpuset sched_load_balance flag) was not tested SCHED_DEBUG enabled as committed as it dereferences NULL when used and it reordered the sysctl registration to cause it to never show any domains or their tunables. Fixes: 1) restore

[PATCH] Fix sched_domain sysctl registration again

2007-10-20 Thread Milton Miller
commit 029190c515f15f512ac85de8fc686d4dbd0ae731 (cpuset sched_load_balance flag) was not tested SCHED_DEBUG enabled as committed as it dereferences NULL when used and it reordered the sysctl registration to cause it to never show any domains or their tunables. Fixes: 1) restore

[PATCH] Fix sched_domain sysctl registration again

2007-10-20 Thread Milton D. Miller II
commit 029190c515f15f512ac85de8fc686d4dbd0ae731 (cpuset sched_load_balance flag) was not tested SCHED_DEBUG enabled as committed as it dereferences NULL when used and it reordered the sysctl registration to cause it to never show any domains or their tunables. Fixes: 1) restore

Re: [PATCH] Fix sched_domain sysctl registration again

2007-10-20 Thread Paul Jackson
Thanks for catching these, Milton. I had done my testing against 2.6.23-rc8-mm2 and earlier, so had not picked up your earlier debug sysctl patches from Oct 12 or so that first fixed this, so had not noticed that the resulting merge of your work and mine was borked. ... somedays even the latest