From: Oussama Ghorbel
Date: Mon, 7 Oct 2013 18:52:15 +0100
> Sorry for that. I've added it and I have resubmitted the patch.
Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Mon, Oct 7, 2013 at 3:02 AM, Hannes Frederic Sowa
wrote:
> On Sun, Oct 06, 2013 at 08:18:15PM +0100, Oussama Ghorbel wrote:
>> Yes, to summarize, the idea of this patch was to fix the incoherence
>> in the condition of ip6gre_tunnel_change_mtu function
>>
>> if (new_mtu < 68 ||
>>new_mtu
ject is: [PATCH] ipv6: Fix the upper MTU limit in GRE tunnel
>
> You forgot to propagate the "Acked-by: " tag that was given by
> reviewers of your patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo
From: Oussama Ghorbel
Date: Mon, 7 Oct 2013 18:34:53 +0100
> OK, I've resubmitted the patch with the proper Subject line.
> The new mail subject is: [PATCH] ipv6: Fix the upper MTU limit in GRE tunnel
You forgot to propagate the "Acked-by: " tag that was given by
reviewe
OK, I've resubmitted the patch with the proper Subject line.
The new mail subject is: [PATCH] ipv6: Fix the upper MTU limit in GRE tunnel
Thanks,
Oussama
On Mon, Oct 7, 2013 at 5:53 PM, David Miller wrote:
> From: Oussama Ghorbel
> Date: Fri, 4 Oct 2013 10:52:13 +0100
>
>&
From: Oussama Ghorbel
Date: Fri, 4 Oct 2013 10:52:13 +0100
> Unlike ipv4, the struct member hlen holds the length of the GRE and ipv6
> headers. This length is also counted in dev->hard_header_len.
> Perhaps, it's more clean to modify the hlen to count only the GRE header
> without ipv6 header
From: Oussama Ghorbel ou.ghor...@gmail.com
Date: Fri, 4 Oct 2013 10:52:13 +0100
Unlike ipv4, the struct member hlen holds the length of the GRE and ipv6
headers. This length is also counted in dev-hard_header_len.
Perhaps, it's more clean to modify the hlen to count only the GRE header
OK, I've resubmitted the patch with the proper Subject line.
The new mail subject is: [PATCH] ipv6: Fix the upper MTU limit in GRE tunnel
Thanks,
Oussama
On Mon, Oct 7, 2013 at 5:53 PM, David Miller da...@davemloft.net wrote:
From: Oussama Ghorbel ou.ghor...@gmail.com
Date: Fri, 4 Oct 2013
From: Oussama Ghorbel ou.ghor...@gmail.com
Date: Mon, 7 Oct 2013 18:34:53 +0100
OK, I've resubmitted the patch with the proper Subject line.
The new mail subject is: [PATCH] ipv6: Fix the upper MTU limit in GRE tunnel
You forgot to propagate the Acked-by: tag that was given by
reviewers
.
The new mail subject is: [PATCH] ipv6: Fix the upper MTU limit in GRE tunnel
You forgot to propagate the Acked-by: tag that was given by
reviewers of your patch.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
On Mon, Oct 7, 2013 at 3:02 AM, Hannes Frederic Sowa
han...@stressinduktion.org wrote:
On Sun, Oct 06, 2013 at 08:18:15PM +0100, Oussama Ghorbel wrote:
Yes, to summarize, the idea of this patch was to fix the incoherence
in the condition of ip6gre_tunnel_change_mtu function
if (new_mtu 68
From: Oussama Ghorbel ou.ghor...@gmail.com
Date: Mon, 7 Oct 2013 18:52:15 +0100
Sorry for that. I've added it and I have resubmitted the patch.
Thank you.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
On Sun, Oct 06, 2013 at 08:18:15PM +0100, Oussama Ghorbel wrote:
> Yes, to summarize, the idea of this patch was to fix the incoherence
> in the condition of ip6gre_tunnel_change_mtu function
>
> if (new_mtu < 68 ||
>new_mtu > 0xFFF8 - dev->hard_header_len - tunnel->hlen)
>
> From the
Yes, to summarize, the idea of this patch was to fix the incoherence
in the condition of ip6gre_tunnel_change_mtu function
if (new_mtu < 68 ||
new_mtu > 0xFFF8 - dev->hard_header_len - tunnel->hlen)
>From the ip6gre_tnl_link_config function we can see that:
The variable addend is equal the
On Sun, Oct 06, 2013 at 04:36:56PM +0100, Oussama Ghorbel wrote:
> On Sun, Oct 6, 2013 at 4:13 PM, Hannes Frederic Sowa
> wrote:
> > On Sun, Oct 06, 2013 at 03:42:15PM +0100, Oussama Ghorbel wrote:
> >> The initialization in ip6gre_tnl_link_config is done as the following:
> >> static void
On Sun, Oct 6, 2013 at 4:13 PM, Hannes Frederic Sowa
wrote:
> On Sun, Oct 06, 2013 at 03:42:15PM +0100, Oussama Ghorbel wrote:
>> The initialization in ip6gre_tnl_link_config is done as the following:
>> static void ip6gre_tnl_link_config(struct ip6_tnl *t, int set_mtu)
>> {
>> ...
>> int addend
On Sun, Oct 06, 2013 at 03:42:15PM +0100, Oussama Ghorbel wrote:
> The initialization in ip6gre_tnl_link_config is done as the following:
> static void ip6gre_tnl_link_config(struct ip6_tnl *t, int set_mtu)
> {
> ...
> int addend = sizeof(struct ipv6hdr) + 4;
> ...
> /* Precalculate GRE options
On Sat, Oct 5, 2013 at 3:06 PM, Hannes Frederic Sowa
wrote:
> On Fri, Oct 04, 2013 at 10:52:13AM +0100, Oussama Ghorbel wrote:
>> Unlike ipv4, the struct member hlen holds the length of the GRE and ipv6
>> headers. This length is also counted in dev->hard_header_len.
>> Perhaps, it's more clean
On Sat, Oct 5, 2013 at 3:06 PM, Hannes Frederic Sowa
han...@stressinduktion.org wrote:
On Fri, Oct 04, 2013 at 10:52:13AM +0100, Oussama Ghorbel wrote:
Unlike ipv4, the struct member hlen holds the length of the GRE and ipv6
headers. This length is also counted in dev-hard_header_len.
Perhaps,
On Sun, Oct 06, 2013 at 03:42:15PM +0100, Oussama Ghorbel wrote:
The initialization in ip6gre_tnl_link_config is done as the following:
static void ip6gre_tnl_link_config(struct ip6_tnl *t, int set_mtu)
{
...
int addend = sizeof(struct ipv6hdr) + 4;
...
/* Precalculate GRE options length
On Sun, Oct 6, 2013 at 4:13 PM, Hannes Frederic Sowa
han...@stressinduktion.org wrote:
On Sun, Oct 06, 2013 at 03:42:15PM +0100, Oussama Ghorbel wrote:
The initialization in ip6gre_tnl_link_config is done as the following:
static void ip6gre_tnl_link_config(struct ip6_tnl *t, int set_mtu)
{
On Sun, Oct 06, 2013 at 04:36:56PM +0100, Oussama Ghorbel wrote:
On Sun, Oct 6, 2013 at 4:13 PM, Hannes Frederic Sowa
han...@stressinduktion.org wrote:
On Sun, Oct 06, 2013 at 03:42:15PM +0100, Oussama Ghorbel wrote:
The initialization in ip6gre_tnl_link_config is done as the following:
Yes, to summarize, the idea of this patch was to fix the incoherence
in the condition of ip6gre_tunnel_change_mtu function
if (new_mtu 68 ||
new_mtu 0xFFF8 - dev-hard_header_len - tunnel-hlen)
From the ip6gre_tnl_link_config function we can see that:
The variable addend is equal the ipv6
On Sun, Oct 06, 2013 at 08:18:15PM +0100, Oussama Ghorbel wrote:
Yes, to summarize, the idea of this patch was to fix the incoherence
in the condition of ip6gre_tunnel_change_mtu function
if (new_mtu 68 ||
new_mtu 0xFFF8 - dev-hard_header_len - tunnel-hlen)
From the
On Fri, Oct 04, 2013 at 10:52:13AM +0100, Oussama Ghorbel wrote:
> Unlike ipv4, the struct member hlen holds the length of the GRE and ipv6
> headers. This length is also counted in dev->hard_header_len.
> Perhaps, it's more clean to modify the hlen to count only the GRE header
> without ipv6
On Fri, Oct 04, 2013 at 10:52:13AM +0100, Oussama Ghorbel wrote:
Unlike ipv4, the struct member hlen holds the length of the GRE and ipv6
headers. This length is also counted in dev-hard_header_len.
Perhaps, it's more clean to modify the hlen to count only the GRE header
without ipv6 header as
Unlike ipv4, the struct member hlen holds the length of the GRE and ipv6
headers. This length is also counted in dev->hard_header_len.
Perhaps, it's more clean to modify the hlen to count only the GRE header
without ipv6 header as the variable name suggest, but the simple way to fix
this without
Unlike ipv4, the struct member hlen holds the length of the GRE and ipv6
headers. This length is also counted in dev-hard_header_len.
Perhaps, it's more clean to modify the hlen to count only the GRE header
without ipv6 header as the variable name suggest, but the simple way to fix
this without
28 matches
Mail list logo
