> strongly encouraged to restrict their checkpatch cleanups to the
> staging tree, since when such cleanup patches are considered welcome
> very much depends on the kernel subsystem and the maintainers
> involved.)
Should I still send the ones I tried to submit in this thread again
as separate
> On 8 Sep 2019, at 22:59, Theodore Y. Ts'o wrote:
>
Hi Ted,
Thank you, for elaborating all this to me! I will try to limit my patches to
the staging tree, until I feel confident enough to tackle a real coding issue
in the kernel.
Thanks,
Sandro V
Hi Sandro,
It's not mentioned in the process documentation (but maybe we should
add this), is that it's up to individual maintainers about whether or
not whitespace cleanups are accepted outside of the staging tree.
That's because whitespace cleanups are a great "training wheel" for
newbies who
Sandro V
>> On 7 Sep 2019, at 22:04, Joe Perches wrote:
>>
>> On Sat, 2019-09-07 at 11:09 +0200, volery wrote:
>> There were a lot of styling problems using space then tab or spaces
>> instead of tabs in that file. Especially the entire function at line
>> 2677.
>> Also added a space before
On Sat, 2019-09-07 at 11:09 +0200, volery wrote:
> There were a lot of styling problems using space then tab or spaces
> instead of tabs in that file. Especially the entire function at line
> 2677.
> Also added a space before the : on line 2221.
You do not have an appropriate subject line.
This
On Sat, 2019-09-07 at 21:51 +0200, Sandro Volery wrote:
> > On 7 Sep 2019, at 21:27, Joe Perches wrote:
[]
> > As long as git diff -w shows no difference and a compiled
> > object comparison before and after the change shows no
> > difference, I think it's fine.
>
> My thoughts, too. I didn't
> On 7 Sep 2019, at 21:27, Joe Perches wrote:
>
> On Sat, 2019-09-07 at 18:42 +0100, Greg KH wrote:
>>> On Sat, Sep 07, 2019 at 07:35:42PM +0200, Sandro Volery wrote:
>>>
>> On 7 Sep 2019, at 19:29, Greg KH wrote:
> On Sat, Sep 07, 2019 at 07:23:59PM +0200, Sandro Volery wrote:
On Sat, 2019-09-07 at 18:42 +0100, Greg KH wrote:
> On Sat, Sep 07, 2019 at 07:35:42PM +0200, Sandro Volery wrote:
> >
> > > > > On 7 Sep 2019, at 19:29, Greg KH wrote:
> > > > On Sat, Sep 07, 2019 at 07:23:59PM +0200, Sandro Volery wrote:
> > > > Dear Greg,
> > > > I am pretty sure the issue
Sandro V
> On 7 Sep 2019, at 20:03, Greg KH wrote:
>
> On Sat, Sep 07, 2019 at 07:49:43PM +0200, Sandro Volery wrote:
>>
>>
>>
>>
On 7 Sep 2019, at 19:42, Greg KH wrote:
>>>
>>> On Sat, Sep 07, 2019 at 07:35:42PM +0200, Sandro Volery wrote:
On 7 Sep 2019, at
On Sat, Sep 07, 2019 at 07:49:43PM +0200, Sandro Volery wrote:
>
>
>
>
> > On 7 Sep 2019, at 19:42, Greg KH wrote:
> >
> > On Sat, Sep 07, 2019 at 07:35:42PM +0200, Sandro Volery wrote:
> >>
> >>
> >> On 7 Sep 2019, at 19:29, Greg KH wrote:
> > On Sat, Sep 07, 2019 at 07:23:59PM
> On 7 Sep 2019, at 19:42, Greg KH wrote:
>
> On Sat, Sep 07, 2019 at 07:35:42PM +0200, Sandro Volery wrote:
>>
>>
>> On 7 Sep 2019, at 19:29, Greg KH wrote:
> On Sat, Sep 07, 2019 at 07:23:59PM +0200, Sandro Volery wrote:
> Dear Greg,
> I am pretty sure the issue was,
On Sat, Sep 07, 2019 at 07:35:42PM +0200, Sandro Volery wrote:
>
>
> >>> On 7 Sep 2019, at 19:29, Greg KH wrote:
> >> On Sat, Sep 07, 2019 at 07:23:59PM +0200, Sandro Volery wrote:
> >> Dear Greg,
> >> I am pretty sure the issue was, that I did too many things at once.
> >> However, all the
>>> On 7 Sep 2019, at 19:29, Greg KH wrote:
>> On Sat, Sep 07, 2019 at 07:23:59PM +0200, Sandro Volery wrote:
>> Dear Greg,
>> I am pretty sure the issue was, that I did too many things at once. However,
>> all the things I did are related to spaces / tabs, maybe that still works?
>
>
>
>
On Sat, Sep 07, 2019 at 11:09:48AM +0200, volery wrote:
> There were a lot of styling problems using space then tab or spaces
> instead of tabs in that file. Especially the entire function at line
> 2677.
> Also added a space before the : on line 2221.
>
> Signed-off-by: Sandro Volery
> ---
>
There were a lot of styling problems using space then tab or spaces
instead of tabs in that file. Especially the entire function at line
2677.
Also added a space before the : on line 2221.
Signed-off-by: Sandro Volery
---
drivers/tty/tty_io.c | 60 ++--
1
15 matches
Mail list logo