Re: [PATCH] HFSPlus: simplify inode mode settting logic

2007-06-24 Thread Roman Zippel
Hi, On Sat, 23 Jun 2007, Wyatt Banks wrote: > Besides this redundancy, mode is the BSD file type and mode > bits (see Apple TechNote 1150 for details) and is never 0. This is wrong, there is an extra note: "If the S_IFMT field (upper 4 bits) of the fileMode field is zero, then Mac OS X

Re: [PATCH] HFSPlus: simplify inode mode settting logic

2007-06-24 Thread Roman Zippel
Hi, On Sat, 23 Jun 2007, Wyatt Banks wrote: Besides this redundancy, mode is the BSD file type and mode bits (see Apple TechNote 1150 for details) and is never 0. This is wrong, there is an extra note: If the S_IFMT field (upper 4 bits) of the fileMode field is zero, then Mac OS X assumes

[PATCH] HFSPlus: simplify inode mode settting logic

2007-06-23 Thread Wyatt Banks
From: Wyatt Banks <[EMAIL PROTECTED]> HFSPlus: Fix broken inode mode setting logic. Fix broken umask mount option. Signed-off-by: Wyatt Banks <[EMAIL PROTECTED]> --- Patched against 2.6.21.5 hfsplus_cat_read_inode() decides if the selected inode is a directory or not. It then sets the 3rd

[PATCH] HFSPlus: simplify inode mode settting logic

2007-06-23 Thread Wyatt Banks
From: Wyatt Banks [EMAIL PROTECTED] HFSPlus: Fix broken inode mode setting logic. Fix broken umask mount option. Signed-off-by: Wyatt Banks [EMAIL PROTECTED] --- Patched against 2.6.21.5 hfsplus_cat_read_inode() decides if the selected inode is a directory or not. It then sets the 3rd