Re: [PATCH] HID: asus: support backlight on USB keyboards

2017-04-05 Thread Benjamin Tissoires
On Apr 05 2017 or thereabouts, Carlo Caione wrote: > On Wed, Apr 5, 2017 at 11:41 AM, Benjamin Tissoires > wrote: > > Hi Carlo, > > [cut] > >> With this patch we create the usual 'asus::kbd_backlight' sysfs entry > > > > Please change 'sysfs' with 'led class' or

Re: [PATCH] HID: asus: support backlight on USB keyboards

2017-04-05 Thread Benjamin Tissoires
On Apr 05 2017 or thereabouts, Carlo Caione wrote: > On Wed, Apr 5, 2017 at 11:41 AM, Benjamin Tissoires > wrote: > > Hi Carlo, > > [cut] > >> With this patch we create the usual 'asus::kbd_backlight' sysfs entry > > > > Please change 'sysfs' with 'led class' or this will mislead people into > >

Re: [PATCH] HID: asus: support backlight on USB keyboards

2017-04-05 Thread Carlo Caione
On Wed, Apr 5, 2017 at 11:41 AM, Benjamin Tissoires wrote: > Hi Carlo, [cut] >> With this patch we create the usual 'asus::kbd_backlight' sysfs entry > > Please change 'sysfs' with 'led class' or this will mislead people into > understanding that you are adding a

Re: [PATCH] HID: asus: support backlight on USB keyboards

2017-04-05 Thread Carlo Caione
On Wed, Apr 5, 2017 at 11:41 AM, Benjamin Tissoires wrote: > Hi Carlo, [cut] >> With this patch we create the usual 'asus::kbd_backlight' sysfs entry > > Please change 'sysfs' with 'led class' or this will mislead people into > understanding that you are adding a custom sysfs entry. Agree

Re: [PATCH] HID: asus: support backlight on USB keyboards

2017-04-05 Thread Benjamin Tissoires
Hi Carlo, On Apr 04 2017 or thereabouts, Carlo Caione wrote: > From: Carlo Caione > > The latest USB keyboards shipped on several ASUS laptop models > (including ROG laptop models such as GL702VMK) have the keyboards > backlight controlled by the keyboard firmware. > > The

Re: [PATCH] HID: asus: support backlight on USB keyboards

2017-04-05 Thread Benjamin Tissoires
Hi Carlo, On Apr 04 2017 or thereabouts, Carlo Caione wrote: > From: Carlo Caione > > The latest USB keyboards shipped on several ASUS laptop models > (including ROG laptop models such as GL702VMK) have the keyboards > backlight controlled by the keyboard firmware. > > The firmware implements

[PATCH] HID: asus: support backlight on USB keyboards

2017-04-04 Thread Carlo Caione
From: Carlo Caione The latest USB keyboards shipped on several ASUS laptop models (including ROG laptop models such as GL702VMK) have the keyboards backlight controlled by the keyboard firmware. The firmware implements at least 3 different commands: - Init command (to use

[PATCH] HID: asus: support backlight on USB keyboards

2017-04-04 Thread Carlo Caione
From: Carlo Caione The latest USB keyboards shipped on several ASUS laptop models (including ROG laptop models such as GL702VMK) have the keyboards backlight controlled by the keyboard firmware. The firmware implements at least 3 different commands: - Init command (to use when the system