Re: [PATCH] HID: intel_ish-hid: HBM: Use connected standby state bit during suspend/resume

2021-03-09 Thread Ye, Xiang
Hi Srinivas Thanks for the review. On Tue, Mar 09, 2021 at 08:08:36AM -0800, Srinivas Pandruvada wrote: > On Tue, 2021-03-09 at 11:47 +0800, Ye, Xiang wrote: > > Hi Srinivas, Jiri > > > > On Mon, Mar 08, 2021 at 08:00:41AM -0800, Srinivas Pandruvada wrote: > > > On Mon, 2021-03-08 at 11:26 +0100

Re: [PATCH] HID: intel_ish-hid: HBM: Use connected standby state bit during suspend/resume

2021-03-09 Thread Srinivas Pandruvada
On Tue, 2021-03-09 at 11:47 +0800, Ye, Xiang wrote: > Hi Srinivas, Jiri > > On Mon, Mar 08, 2021 at 08:00:41AM -0800, Srinivas Pandruvada wrote: > > On Mon, 2021-03-08 at 11:26 +0100, Jiri Kosina wrote: > > > On Wed, 3 Mar 2021, Ye Xiang wrote: > > > > > > > ISH firmware uses connected standby st

Re: [PATCH] HID: intel_ish-hid: HBM: Use connected standby state bit during suspend/resume

2021-03-08 Thread Ye, Xiang
Hi Srinivas, Jiri On Mon, Mar 08, 2021 at 08:00:41AM -0800, Srinivas Pandruvada wrote: > On Mon, 2021-03-08 at 11:26 +0100, Jiri Kosina wrote: > > On Wed, 3 Mar 2021, Ye Xiang wrote: > > > > > ISH firmware uses connected standby state bit > > > (CONNECTED_STANDBY_STATE_BIT bit 1) > > > to notify

Re: [PATCH] HID: intel_ish-hid: HBM: Use connected standby state bit during suspend/resume

2021-03-08 Thread Srinivas Pandruvada
On Mon, 2021-03-08 at 11:26 +0100, Jiri Kosina wrote: > On Wed, 3 Mar 2021, Ye Xiang wrote: > > > ISH firmware uses connected standby state bit > > (CONNECTED_STANDBY_STATE_BIT bit 1) > > to notify current power state to sensors instead of suspend state > > bit (bit 0). > > So send both SUSPEND_ST

Re: [PATCH] HID: intel_ish-hid: HBM: Use connected standby state bit during suspend/resume

2021-03-08 Thread Jiri Kosina
On Wed, 3 Mar 2021, Ye Xiang wrote: > ISH firmware uses connected standby state bit (CONNECTED_STANDBY_STATE_BIT > bit 1) > to notify current power state to sensors instead of suspend state bit (bit 0). > So send both SUSPEND_STATE_BIT and CONNECTED_STANDBY_STATE_BIT to firmware > to be compatibl

[PATCH] HID: intel_ish-hid: HBM: Use connected standby state bit during suspend/resume

2021-03-03 Thread Ye Xiang
ISH firmware uses connected standby state bit (CONNECTED_STANDBY_STATE_BIT bit 1) to notify current power state to sensors instead of suspend state bit (bit 0). So send both SUSPEND_STATE_BIT and CONNECTED_STANDBY_STATE_BIT to firmware to be compatible with the previous version. Signed-off-by: xi