Re: [PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes

2013-11-28 Thread Mark Brown
On Tue, Nov 26, 2013 at 01:05:53PM +, Charles Keepax wrote: > On Fri, Nov 08, 2013 at 09:59:28AM -0700, Stephen Warren wrote: > > That all said, I wonder if the I2C core shouldn't do something like the > > following inside i2c_add_adapter(): > > > > if (!adap->dev.of_node &&

Re: [PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes

2013-11-28 Thread Florian Meier
Thank you very much! I am sorry and will try to make it better next time. On 11/28/2013 09:50 AM, Wolfram Sang wrote: > On Mon, Nov 25, 2013 at 09:01:50AM +0100, Florian Meier wrote: >> In order to find I2C devices in the device tree, the platform nodes >> have to be known by the I2C core. This

Re: [PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes

2013-11-28 Thread Wolfram Sang
On Mon, Nov 25, 2013 at 09:01:50AM +0100, Florian Meier wrote: > In order to find I2C devices in the device tree, the platform nodes > have to be known by the I2C core. This requires setting the > dev.of_node parameter of the adapter. > > Signed-off-by: Florian Meier Fixed up for you and

Re: [PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes

2013-11-28 Thread Wolfram Sang
On Mon, Nov 25, 2013 at 09:01:50AM +0100, Florian Meier wrote: In order to find I2C devices in the device tree, the platform nodes have to be known by the I2C core. This requires setting the dev.of_node parameter of the adapter. Signed-off-by: Florian Meier florian.me...@koalo.de Fixed up

Re: [PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes

2013-11-28 Thread Florian Meier
Thank you very much! I am sorry and will try to make it better next time. On 11/28/2013 09:50 AM, Wolfram Sang wrote: On Mon, Nov 25, 2013 at 09:01:50AM +0100, Florian Meier wrote: In order to find I2C devices in the device tree, the platform nodes have to be known by the I2C core. This

Re: [PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes

2013-11-28 Thread Mark Brown
On Tue, Nov 26, 2013 at 01:05:53PM +, Charles Keepax wrote: On Fri, Nov 08, 2013 at 09:59:28AM -0700, Stephen Warren wrote: That all said, I wonder if the I2C core shouldn't do something like the following inside i2c_add_adapter(): if (!adap-dev.of_node adap-dev.parent)

Re: [PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes

2013-11-26 Thread Charles Keepax
On Fri, Nov 08, 2013 at 09:59:28AM -0700, Stephen Warren wrote: > On 11/08/2013 02:49 AM, Florian Meier wrote: > > In order to find I2C devices in the device tree, the platform nodes > > have to be known by the I2C core. Analogous to the i2c-omap driver > > this requires setting the dev.of_node

Re: [PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes

2013-11-26 Thread Wolfram Sang
On Mon, Nov 25, 2013 at 09:01:50AM +0100, Florian Meier wrote: > In order to find I2C devices in the device tree, the platform nodes > have to be known by the I2C core. This requires setting the > dev.of_node parameter of the adapter. > > Signed-off-by: Florian Meier Malformed patch, please

Re: [PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes

2013-11-26 Thread Wolfram Sang
On Mon, Nov 25, 2013 at 09:01:50AM +0100, Florian Meier wrote: In order to find I2C devices in the device tree, the platform nodes have to be known by the I2C core. This requires setting the dev.of_node parameter of the adapter. Signed-off-by: Florian Meier florian.me...@koalo.de Malformed

Re: [PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes

2013-11-26 Thread Charles Keepax
On Fri, Nov 08, 2013 at 09:59:28AM -0700, Stephen Warren wrote: On 11/08/2013 02:49 AM, Florian Meier wrote: In order to find I2C devices in the device tree, the platform nodes have to be known by the I2C core. Analogous to the i2c-omap driver this requires setting the dev.of_node parameter

Re: [PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes

2013-11-25 Thread Stephen Warren
On 11/08/2013 09:59 AM, Stephen Warren wrote: > On 11/08/2013 02:49 AM, Florian Meier wrote: >> In order to find I2C devices in the device tree, the platform nodes >> have to be known by the I2C core. Analogous to the i2c-omap driver >> this requires setting the dev.of_node parameter of the

Re: [PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes

2013-11-25 Thread Stephen Warren
On 11/25/2013 01:01 AM, Florian Meier wrote: > In order to find I2C devices in the device tree, the platform nodes > have to be known by the I2C core. This requires setting the > dev.of_node parameter of the adapter. Acked-by: Stephen Warren Tested-by: Stephen Warren (Interestingly, I just

[PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes

2013-11-25 Thread Florian Meier
In order to find I2C devices in the device tree, the platform nodes have to be known by the I2C core. This requires setting the dev.of_node parameter of the adapter. Signed-off-by: Florian Meier --- Since the general approach is not easy enough (see [PATCH] i2c: Fallback to of_node of parent),

[PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes

2013-11-25 Thread Florian Meier
In order to find I2C devices in the device tree, the platform nodes have to be known by the I2C core. This requires setting the dev.of_node parameter of the adapter. Signed-off-by: Florian Meier florian.me...@koalo.de --- Since the general approach is not easy enough (see [PATCH] i2c: Fallback

Re: [PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes

2013-11-25 Thread Stephen Warren
On 11/25/2013 01:01 AM, Florian Meier wrote: In order to find I2C devices in the device tree, the platform nodes have to be known by the I2C core. This requires setting the dev.of_node parameter of the adapter. Acked-by: Stephen Warren swar...@wwwdotorg.org Tested-by: Stephen Warren

Re: [PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes

2013-11-25 Thread Stephen Warren
On 11/08/2013 09:59 AM, Stephen Warren wrote: On 11/08/2013 02:49 AM, Florian Meier wrote: In order to find I2C devices in the device tree, the platform nodes have to be known by the I2C core. Analogous to the i2c-omap driver this requires setting the dev.of_node parameter of the adapter.

Re: [PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes

2013-11-08 Thread Stephen Warren
On 11/08/2013 02:49 AM, Florian Meier wrote: > In order to find I2C devices in the device tree, the platform nodes > have to be known by the I2C core. Analogous to the i2c-omap driver > this requires setting the dev.of_node parameter of the adapter. (CCing the I2C maintainers...) > diff --git

[PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes

2013-11-08 Thread Florian Meier
In order to find I2C devices in the device tree, the platform nodes have to be known by the I2C core. Analogous to the i2c-omap driver this requires setting the dev.of_node parameter of the adapter. Signed-off-by: Florian Meier --- I don't know if this is really necessary, but for me it does

[PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes

2013-11-08 Thread Florian Meier
In order to find I2C devices in the device tree, the platform nodes have to be known by the I2C core. Analogous to the i2c-omap driver this requires setting the dev.of_node parameter of the adapter. Signed-off-by: Florian Meier florian.me...@koalo.de --- I don't know if this is really necessary,

Re: [PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes

2013-11-08 Thread Stephen Warren
On 11/08/2013 02:49 AM, Florian Meier wrote: In order to find I2C devices in the device tree, the platform nodes have to be known by the I2C core. Analogous to the i2c-omap driver this requires setting the dev.of_node parameter of the adapter. (CCing the I2C maintainers...) diff --git