Re: [PATCH] IB/mlx5: Fix a parameter of find_first_bit

2016-09-02 Thread Doug Ledford
On 8/26/2016 1:16 AM, Christophe JAILLET wrote: > The 2nd parameter of 'find_first_bit' is the number of bits to search. > In this case, we are passing 'sizeof(tmp)' which is likely to be 4 or 8 > because 'tmp' is an 'unsigned long'. > > It is likely that the number of bits of 'tmp' was expected

Re: [PATCH] IB/mlx5: Fix a parameter of find_first_bit

2016-09-02 Thread Doug Ledford
On 8/26/2016 1:16 AM, Christophe JAILLET wrote: > The 2nd parameter of 'find_first_bit' is the number of bits to search. > In this case, we are passing 'sizeof(tmp)' which is likely to be 4 or 8 > because 'tmp' is an 'unsigned long'. > > It is likely that the number of bits of 'tmp' was expected

Re: [PATCH] IB/mlx5: Fix a parameter of find_first_bit

2016-08-27 Thread Majd Dibbiny
Acked-by: Majd Dibbiny > On Aug 26, 2016, at 8:25 AM, Christophe JAILLET > wrote: > > The 2nd parameter of 'find_first_bit' is the number of bits to search. > In this case, we are passing 'sizeof(tmp)' which is likely to be 4 or 8 > because

Re: [PATCH] IB/mlx5: Fix a parameter of find_first_bit

2016-08-27 Thread Majd Dibbiny
Acked-by: Majd Dibbiny > On Aug 26, 2016, at 8:25 AM, Christophe JAILLET > wrote: > > The 2nd parameter of 'find_first_bit' is the number of bits to search. > In this case, we are passing 'sizeof(tmp)' which is likely to be 4 or 8 > because 'tmp' is an 'unsigned long'. > > It is likely that

Re: [PATCH] IB/mlx5: Fix a parameter of find_first_bit

2016-08-26 Thread Leon Romanovsky
On Fri, Aug 26, 2016 at 07:16:17AM +0200, Christophe JAILLET wrote: > The 2nd parameter of 'find_first_bit' is the number of bits to search. > In this case, we are passing 'sizeof(tmp)' which is likely to be 4 or 8 > because 'tmp' is an 'unsigned long'. > > It is likely that the number of bits of

Re: [PATCH] IB/mlx5: Fix a parameter of find_first_bit

2016-08-26 Thread Leon Romanovsky
On Fri, Aug 26, 2016 at 07:16:17AM +0200, Christophe JAILLET wrote: > The 2nd parameter of 'find_first_bit' is the number of bits to search. > In this case, we are passing 'sizeof(tmp)' which is likely to be 4 or 8 > because 'tmp' is an 'unsigned long'. > > It is likely that the number of bits of

[PATCH] IB/mlx5: Fix a parameter of find_first_bit

2016-08-25 Thread Christophe JAILLET
The 2nd parameter of 'find_first_bit' is the number of bits to search. In this case, we are passing 'sizeof(tmp)' which is likely to be 4 or 8 because 'tmp' is an 'unsigned long'. It is likely that the number of bits of 'tmp' was expected here. So use BITS_PER_LONG instead. It has been spotted

[PATCH] IB/mlx5: Fix a parameter of find_first_bit

2016-08-25 Thread Christophe JAILLET
The 2nd parameter of 'find_first_bit' is the number of bits to search. In this case, we are passing 'sizeof(tmp)' which is likely to be 4 or 8 because 'tmp' is an 'unsigned long'. It is likely that the number of bits of 'tmp' was expected here. So use BITS_PER_LONG instead. It has been spotted