Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-04-07 Thread Lars-Peter Clausen
On 04/07/2015 11:35 AM, Linus Walleij wrote: On Mon, Mar 30, 2015 at 3:52 PM, Octavian Purdila wrote: On Mon, Mar 30, 2015 at 4:33 PM, Mika Westerberg wrote: On Mon, Mar 30, 2015 at 03:55:14PM +0300, Octavian Purdila wrote: On Mon, Mar 30, 2015 at 12:52 PM, Mika Westerberg wrote: On Fri,

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-04-07 Thread Linus Walleij
On Mon, Mar 30, 2015 at 3:52 PM, Octavian Purdila wrote: > On Mon, Mar 30, 2015 at 4:33 PM, Mika Westerberg > wrote: >> On Mon, Mar 30, 2015 at 03:55:14PM +0300, Octavian Purdila wrote: >>> On Mon, Mar 30, 2015 at 12:52 PM, Mika Westerberg >>> wrote: >>> > On Fri, Mar 27, 2015 at 11:36:25AM

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-04-07 Thread Linus Walleij
On Mon, Mar 30, 2015 at 3:52 PM, Octavian Purdila octavian.purd...@intel.com wrote: On Mon, Mar 30, 2015 at 4:33 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Mon, Mar 30, 2015 at 03:55:14PM +0300, Octavian Purdila wrote: On Mon, Mar 30, 2015 at 12:52 PM, Mika Westerberg

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-04-07 Thread Lars-Peter Clausen
On 04/07/2015 11:35 AM, Linus Walleij wrote: On Mon, Mar 30, 2015 at 3:52 PM, Octavian Purdila octavian.purd...@intel.com wrote: On Mon, Mar 30, 2015 at 4:33 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Mon, Mar 30, 2015 at 03:55:14PM +0300, Octavian Purdila wrote: On Mon,

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-30 Thread Mika Westerberg
On Mon, Mar 30, 2015 at 04:52:49PM +0300, Octavian Purdila wrote: > What if we can do the pin configuration in gpiolib right after the > GPIO controller is initialized. I am thinking of searching the ACPI > namespace and looking for resources that have GpioInt entries for that > particular GPIO

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-30 Thread Octavian Purdila
On Mon, Mar 30, 2015 at 4:33 PM, Mika Westerberg wrote: > On Mon, Mar 30, 2015 at 03:55:14PM +0300, Octavian Purdila wrote: >> On Mon, Mar 30, 2015 at 12:52 PM, Mika Westerberg >> wrote: >> > On Fri, Mar 27, 2015 at 11:36:25AM +0100, Linus Walleij wrote: >> >> On Fri, Mar 27, 2015 at 11:06 AM,

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-30 Thread Mika Westerberg
On Mon, Mar 30, 2015 at 03:55:14PM +0300, Octavian Purdila wrote: > On Mon, Mar 30, 2015 at 12:52 PM, Mika Westerberg > wrote: > > On Fri, Mar 27, 2015 at 11:36:25AM +0100, Linus Walleij wrote: > >> On Fri, Mar 27, 2015 at 11:06 AM, Mika Westerberg > >> wrote: > >> > On Thu, Mar 26, 2015 at

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-30 Thread Octavian Purdila
On Mon, Mar 30, 2015 at 12:52 PM, Mika Westerberg wrote: > On Fri, Mar 27, 2015 at 11:36:25AM +0100, Linus Walleij wrote: >> On Fri, Mar 27, 2015 at 11:06 AM, Mika Westerberg >> wrote: >> > On Thu, Mar 26, 2015 at 06:28:19PM +0200, Octavian Purdila wrote: >> >> >> For the sleep case I think the

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-30 Thread Mika Westerberg
On Fri, Mar 27, 2015 at 11:36:25AM +0100, Linus Walleij wrote: > On Fri, Mar 27, 2015 at 11:06 AM, Mika Westerberg > wrote: > > On Thu, Mar 26, 2015 at 06:28:19PM +0200, Octavian Purdila wrote: > > >> For the sleep case I think the GPIO controller needs to do the pin > >> enable and set input

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-30 Thread Mika Westerberg
On Fri, Mar 27, 2015 at 11:36:25AM +0100, Linus Walleij wrote: On Fri, Mar 27, 2015 at 11:06 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Thu, Mar 26, 2015 at 06:28:19PM +0200, Octavian Purdila wrote: For the sleep case I think the GPIO controller needs to do the pin

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-30 Thread Octavian Purdila
On Mon, Mar 30, 2015 at 12:52 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Fri, Mar 27, 2015 at 11:36:25AM +0100, Linus Walleij wrote: On Fri, Mar 27, 2015 at 11:06 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Thu, Mar 26, 2015 at 06:28:19PM +0200, Octavian

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-30 Thread Mika Westerberg
On Mon, Mar 30, 2015 at 03:55:14PM +0300, Octavian Purdila wrote: On Mon, Mar 30, 2015 at 12:52 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Fri, Mar 27, 2015 at 11:36:25AM +0100, Linus Walleij wrote: On Fri, Mar 27, 2015 at 11:06 AM, Mika Westerberg

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-30 Thread Mika Westerberg
On Mon, Mar 30, 2015 at 04:52:49PM +0300, Octavian Purdila wrote: What if we can do the pin configuration in gpiolib right after the GPIO controller is initialized. I am thinking of searching the ACPI namespace and looking for resources that have GpioInt entries for that particular GPIO

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-30 Thread Octavian Purdila
On Mon, Mar 30, 2015 at 4:33 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Mon, Mar 30, 2015 at 03:55:14PM +0300, Octavian Purdila wrote: On Mon, Mar 30, 2015 at 12:52 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Fri, Mar 27, 2015 at 11:36:25AM +0100, Linus

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-27 Thread Linus Walleij
On Fri, Mar 27, 2015 at 11:06 AM, Mika Westerberg wrote: > On Thu, Mar 26, 2015 at 06:28:19PM +0200, Octavian Purdila wrote: >> For the sleep case I think the GPIO controller needs to do the pin >> enable and set input direction operation in it's irq_bus_sync_unlock. > > I wonder how DT handles

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-27 Thread Mika Westerberg
On Thu, Mar 26, 2015 at 06:28:19PM +0200, Octavian Purdila wrote: > >>> >> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > >>> >> index 568aa2b..9865627 100644 > >>> >> --- a/drivers/gpio/gpiolib.c > >>> >> +++ b/drivers/gpio/gpiolib.c > >>> >> @@ -511,6 +511,19 @@ static const

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-27 Thread Mika Westerberg
On Thu, Mar 26, 2015 at 06:28:19PM +0200, Octavian Purdila wrote: diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 568aa2b..9865627 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -511,6 +511,19 @@ static const struct irq_domain_ops

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-27 Thread Linus Walleij
On Fri, Mar 27, 2015 at 11:06 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Thu, Mar 26, 2015 at 06:28:19PM +0200, Octavian Purdila wrote: For the sleep case I think the GPIO controller needs to do the pin enable and set input direction operation in it's irq_bus_sync_unlock.

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-26 Thread Jonathan Cameron
On 26 March 2015 15:00:43 GMT+00:00, Octavian Purdila wrote: >On Thu, Mar 26, 2015 at 4:47 PM, Mika Westerberg > wrote: >> On Thu, Mar 26, 2015 at 04:37:39PM +0200, Octavian Purdila wrote: >>> On Thu, Mar 26, 2015 at 4:04 PM, Mika Westerberg >>> wrote: >>> > On Thu, Mar 26, 2015 at 02:04:35PM

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-26 Thread Octavian Purdila
On Thu, Mar 26, 2015 at 5:00 PM, Octavian Purdila wrote: > On Thu, Mar 26, 2015 at 4:47 PM, Mika Westerberg > wrote: >> On Thu, Mar 26, 2015 at 04:37:39PM +0200, Octavian Purdila wrote: >>> On Thu, Mar 26, 2015 at 4:04 PM, Mika Westerberg >>> wrote: >>> > On Thu, Mar 26, 2015 at 02:04:35PM

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-26 Thread Octavian Purdila
On Thu, Mar 26, 2015 at 4:47 PM, Mika Westerberg wrote: > On Thu, Mar 26, 2015 at 04:37:39PM +0200, Octavian Purdila wrote: >> On Thu, Mar 26, 2015 at 4:04 PM, Mika Westerberg >> wrote: >> > On Thu, Mar 26, 2015 at 02:04:35PM +0200, Octavian Purdila wrote: >> >> On Thu, Mar 26, 2015 at 12:16 PM,

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-26 Thread Mika Westerberg
On Thu, Mar 26, 2015 at 04:37:39PM +0200, Octavian Purdila wrote: > On Thu, Mar 26, 2015 at 4:04 PM, Mika Westerberg > wrote: > > On Thu, Mar 26, 2015 at 02:04:35PM +0200, Octavian Purdila wrote: > >> On Thu, Mar 26, 2015 at 12:16 PM, Mika Westerberg > >> wrote: > >> > On Wed, Mar 25, 2015 at

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-26 Thread Octavian Purdila
On Thu, Mar 26, 2015 at 4:04 PM, Mika Westerberg wrote: > On Thu, Mar 26, 2015 at 02:04:35PM +0200, Octavian Purdila wrote: >> On Thu, Mar 26, 2015 at 12:16 PM, Mika Westerberg >> wrote: >> > On Wed, Mar 25, 2015 at 11:12:16PM +0200, Octavian Purdila wrote: >> >> On Wed, Mar 25, 2015 at 3:21 PM,

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-26 Thread Mika Westerberg
On Thu, Mar 26, 2015 at 02:04:35PM +0200, Octavian Purdila wrote: > On Thu, Mar 26, 2015 at 12:16 PM, Mika Westerberg > wrote: > > On Wed, Mar 25, 2015 at 11:12:16PM +0200, Octavian Purdila wrote: > >> On Wed, Mar 25, 2015 at 3:21 PM, Mika Westerberg > >> wrote: > >> > On Wed, Mar 25, 2015 at

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-26 Thread Octavian Purdila
On Thu, Mar 26, 2015 at 12:16 PM, Mika Westerberg wrote: > On Wed, Mar 25, 2015 at 11:12:16PM +0200, Octavian Purdila wrote: >> On Wed, Mar 25, 2015 at 3:21 PM, Mika Westerberg >> wrote: >> > On Wed, Mar 25, 2015 at 02:25:05PM +0200, Mika Westerberg wrote: >> >> I think we can do the same for

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-26 Thread Mika Westerberg
On Thu, Mar 26, 2015 at 12:06:45PM +0200, Robert Dolca wrote: > On Wed, Mar 25, 2015 at 11:12 PM, Octavian Purdila > wrote: > > On Wed, Mar 25, 2015 at 3:21 PM, Mika Westerberg > > wrote: > >> On Wed, Mar 25, 2015 at 02:25:05PM +0200, Mika Westerberg wrote: > >>> I think we can do the same for

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-26 Thread Mika Westerberg
On Wed, Mar 25, 2015 at 11:12:16PM +0200, Octavian Purdila wrote: > On Wed, Mar 25, 2015 at 3:21 PM, Mika Westerberg > wrote: > > On Wed, Mar 25, 2015 at 02:25:05PM +0200, Mika Westerberg wrote: > >> I think we can do the same for ACPI GpioInts so that we introduce > >> acpi_gpio_irq_get() that

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-26 Thread Robert Dolca
On Wed, Mar 25, 2015 at 11:12 PM, Octavian Purdila wrote: > On Wed, Mar 25, 2015 at 3:21 PM, Mika Westerberg > wrote: >> On Wed, Mar 25, 2015 at 02:25:05PM +0200, Mika Westerberg wrote: >>> I think we can do the same for ACPI GpioInts so that we introduce >>> acpi_gpio_irq_get() that translates

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-26 Thread Mika Westerberg
On Thu, Mar 26, 2015 at 12:06:45PM +0200, Robert Dolca wrote: On Wed, Mar 25, 2015 at 11:12 PM, Octavian Purdila octavian.purd...@intel.com wrote: On Wed, Mar 25, 2015 at 3:21 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Wed, Mar 25, 2015 at 02:25:05PM +0200, Mika

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-26 Thread Robert Dolca
On Wed, Mar 25, 2015 at 11:12 PM, Octavian Purdila octavian.purd...@intel.com wrote: On Wed, Mar 25, 2015 at 3:21 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Wed, Mar 25, 2015 at 02:25:05PM +0200, Mika Westerberg wrote: I think we can do the same for ACPI GpioInts so that we

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-26 Thread Mika Westerberg
On Wed, Mar 25, 2015 at 11:12:16PM +0200, Octavian Purdila wrote: On Wed, Mar 25, 2015 at 3:21 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Wed, Mar 25, 2015 at 02:25:05PM +0200, Mika Westerberg wrote: I think we can do the same for ACPI GpioInts so that we introduce

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-26 Thread Octavian Purdila
On Thu, Mar 26, 2015 at 12:16 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Wed, Mar 25, 2015 at 11:12:16PM +0200, Octavian Purdila wrote: On Wed, Mar 25, 2015 at 3:21 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Wed, Mar 25, 2015 at 02:25:05PM +0200, Mika

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-26 Thread Octavian Purdila
On Thu, Mar 26, 2015 at 5:00 PM, Octavian Purdila octavian.purd...@intel.com wrote: On Thu, Mar 26, 2015 at 4:47 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Thu, Mar 26, 2015 at 04:37:39PM +0200, Octavian Purdila wrote: On Thu, Mar 26, 2015 at 4:04 PM, Mika Westerberg

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-26 Thread Jonathan Cameron
On 26 March 2015 15:00:43 GMT+00:00, Octavian Purdila octavian.purd...@intel.com wrote: On Thu, Mar 26, 2015 at 4:47 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Thu, Mar 26, 2015 at 04:37:39PM +0200, Octavian Purdila wrote: On Thu, Mar 26, 2015 at 4:04 PM, Mika Westerberg

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-26 Thread Mika Westerberg
On Thu, Mar 26, 2015 at 02:04:35PM +0200, Octavian Purdila wrote: On Thu, Mar 26, 2015 at 12:16 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Wed, Mar 25, 2015 at 11:12:16PM +0200, Octavian Purdila wrote: On Wed, Mar 25, 2015 at 3:21 PM, Mika Westerberg

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-26 Thread Mika Westerberg
On Thu, Mar 26, 2015 at 04:37:39PM +0200, Octavian Purdila wrote: On Thu, Mar 26, 2015 at 4:04 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Thu, Mar 26, 2015 at 02:04:35PM +0200, Octavian Purdila wrote: On Thu, Mar 26, 2015 at 12:16 PM, Mika Westerberg

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-26 Thread Octavian Purdila
On Thu, Mar 26, 2015 at 4:04 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Thu, Mar 26, 2015 at 02:04:35PM +0200, Octavian Purdila wrote: On Thu, Mar 26, 2015 at 12:16 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Wed, Mar 25, 2015 at 11:12:16PM +0200, Octavian

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-26 Thread Octavian Purdila
On Thu, Mar 26, 2015 at 4:47 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Thu, Mar 26, 2015 at 04:37:39PM +0200, Octavian Purdila wrote: On Thu, Mar 26, 2015 at 4:04 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Thu, Mar 26, 2015 at 02:04:35PM +0200, Octavian

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-25 Thread Octavian Purdila
On Wed, Mar 25, 2015 at 3:21 PM, Mika Westerberg wrote: > On Wed, Mar 25, 2015 at 02:25:05PM +0200, Mika Westerberg wrote: >> I think we can do the same for ACPI GpioInts so that we introduce >> acpi_gpio_irq_get() that translates from GpioInt to Linux IRQ >> numberspace. Then we can do something

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-25 Thread Lars-Peter Clausen
On 03/25/2015 07:05 PM, sathyanarayanan kuppuswamy wrote: static acpi_status acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address, u32 bits, u64 *value, void *handler_context, diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-25 Thread sathyanarayanan kuppuswamy
Hi, On 03/25/2015 06:21 AM, Mika Westerberg wrote: On Wed, Mar 25, 2015 at 02:25:05PM +0200, Mika Westerberg wrote: I think we can do the same for ACPI GpioInts so that we introduce acpi_gpio_irq_get() that translates from GpioInt to Linux IRQ numberspace. Then we can do something like below

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-25 Thread Robert Dolca
On Wed, Mar 25, 2015 at 3:21 PM, Mika Westerberg wrote: > On Wed, Mar 25, 2015 at 02:25:05PM +0200, Mika Westerberg wrote: >> I think we can do the same for ACPI GpioInts so that we introduce >> acpi_gpio_irq_get() that translates from GpioInt to Linux IRQ >> numberspace. Then we can do something

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-25 Thread Mika Westerberg
On Wed, Mar 25, 2015 at 02:25:05PM +0200, Mika Westerberg wrote: > I think we can do the same for ACPI GpioInts so that we introduce > acpi_gpio_irq_get() that translates from GpioInt to Linux IRQ > numberspace. Then we can do something like below in I2C core: > > if (client->irq <= 0) { >

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-25 Thread Mika Westerberg
On Wed, Mar 25, 2015 at 11:43:27AM +0200, Mika Westerberg wrote: > On Wed, Mar 25, 2015 at 09:44:34AM +0100, Linus Walleij wrote: > > On Tue, Mar 24, 2015 at 4:06 PM, Mika Westerberg > > wrote: > > > > > This has few problems that I have not yet figured out. Maybe someone > > > here can suggest

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-25 Thread Mika Westerberg
On Wed, Mar 25, 2015 at 09:44:34AM +0100, Linus Walleij wrote: > On Tue, Mar 24, 2015 at 4:06 PM, Mika Westerberg > wrote: > > > This has few problems that I have not yet figured out. Maybe someone > > here can suggest what to do: > > > > 1) Who is responsible in releasing the GPIO? > > 2)

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-25 Thread Linus Walleij
On Tue, Mar 24, 2015 at 4:06 PM, Mika Westerberg wrote: > This has few problems that I have not yet figured out. Maybe someone > here can suggest what to do: > > 1) Who is responsible in releasing the GPIO? > 2) What if the driver wants to use that pin as a GPIO instead? The GPIO > is

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-25 Thread Linus Walleij
On Tue, Mar 24, 2015 at 4:06 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: This has few problems that I have not yet figured out. Maybe someone here can suggest what to do: 1) Who is responsible in releasing the GPIO? 2) What if the driver wants to use that pin as a GPIO

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-25 Thread Mika Westerberg
On Wed, Mar 25, 2015 at 09:44:34AM +0100, Linus Walleij wrote: On Tue, Mar 24, 2015 at 4:06 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: This has few problems that I have not yet figured out. Maybe someone here can suggest what to do: 1) Who is responsible in releasing

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-25 Thread Mika Westerberg
On Wed, Mar 25, 2015 at 02:25:05PM +0200, Mika Westerberg wrote: I think we can do the same for ACPI GpioInts so that we introduce acpi_gpio_irq_get() that translates from GpioInt to Linux IRQ numberspace. Then we can do something like below in I2C core: if (client-irq = 0) {

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-25 Thread Mika Westerberg
On Wed, Mar 25, 2015 at 11:43:27AM +0200, Mika Westerberg wrote: On Wed, Mar 25, 2015 at 09:44:34AM +0100, Linus Walleij wrote: On Tue, Mar 24, 2015 at 4:06 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: This has few problems that I have not yet figured out. Maybe someone

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-25 Thread Robert Dolca
On Wed, Mar 25, 2015 at 3:21 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Wed, Mar 25, 2015 at 02:25:05PM +0200, Mika Westerberg wrote: I think we can do the same for ACPI GpioInts so that we introduce acpi_gpio_irq_get() that translates from GpioInt to Linux IRQ numberspace.

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-25 Thread Lars-Peter Clausen
On 03/25/2015 07:05 PM, sathyanarayanan kuppuswamy wrote: static acpi_status acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address, u32 bits, u64 *value, void *handler_context, diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-25 Thread sathyanarayanan kuppuswamy
Hi, On 03/25/2015 06:21 AM, Mika Westerberg wrote: On Wed, Mar 25, 2015 at 02:25:05PM +0200, Mika Westerberg wrote: I think we can do the same for ACPI GpioInts so that we introduce acpi_gpio_irq_get() that translates from GpioInt to Linux IRQ numberspace. Then we can do something like below

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-25 Thread Octavian Purdila
On Wed, Mar 25, 2015 at 3:21 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Wed, Mar 25, 2015 at 02:25:05PM +0200, Mika Westerberg wrote: I think we can do the same for ACPI GpioInts so that we introduce acpi_gpio_irq_get() that translates from GpioInt to Linux IRQ numberspace.

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Mika Westerberg
On Tue, Mar 24, 2015 at 05:43:21PM +0100, Lars-Peter Clausen wrote: > On 03/24/2015 04:55 PM, Mika Westerberg wrote: > >On Tue, Mar 24, 2015 at 04:22:16PM +0100, Lars-Peter Clausen wrote: > >>Add Alexandre and linux-gpio to Cc. > >> > >>On 03/24/2015 04:06 PM, Mika Westerberg wrote: > >>>On Tue,

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Lars-Peter Clausen
On 03/24/2015 04:55 PM, Mika Westerberg wrote: On Tue, Mar 24, 2015 at 04:22:16PM +0100, Lars-Peter Clausen wrote: Add Alexandre and linux-gpio to Cc. On 03/24/2015 04:06 PM, Mika Westerberg wrote: On Tue, Mar 24, 2015 at 02:57:49PM +0100, Linus Walleij wrote: On Tue, Mar 24, 2015 at 2:38

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Mika Westerberg
On Tue, Mar 24, 2015 at 04:22:16PM +0100, Lars-Peter Clausen wrote: > Add Alexandre and linux-gpio to Cc. > > On 03/24/2015 04:06 PM, Mika Westerberg wrote: > >On Tue, Mar 24, 2015 at 02:57:49PM +0100, Linus Walleij wrote: > >>On Tue, Mar 24, 2015 at 2:38 PM, Lars-Peter Clausen wrote: > >>>On

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Daniel Baluta
On Tue, Mar 24, 2015 at 5:22 PM, Lars-Peter Clausen wrote: > Add Alexandre and linux-gpio to Cc. > > > On 03/24/2015 04:06 PM, Mika Westerberg wrote: >> >> On Tue, Mar 24, 2015 at 02:57:49PM +0100, Linus Walleij wrote: >>> >>> On Tue, Mar 24, 2015 at 2:38 PM, Lars-Peter Clausen >>> wrote:

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Lars-Peter Clausen
Add Alexandre and linux-gpio to Cc. On 03/24/2015 04:06 PM, Mika Westerberg wrote: On Tue, Mar 24, 2015 at 02:57:49PM +0100, Linus Walleij wrote: On Tue, Mar 24, 2015 at 2:38 PM, Lars-Peter Clausen wrote: On 03/24/2015 02:26 PM, Robert Dolca wrote: On Tue, Mar 24, 2015 at 2:17 PM,

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Mika Westerberg
On Tue, Mar 24, 2015 at 02:57:49PM +0100, Linus Walleij wrote: > On Tue, Mar 24, 2015 at 2:38 PM, Lars-Peter Clausen wrote: > > On 03/24/2015 02:26 PM, Robert Dolca wrote: > >> On Tue, Mar 24, 2015 at 2:17 PM, Lars-Peter Clausen > >> wrote: > > >> In the ACPI description you specify one or more

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Linus Walleij
On Tue, Mar 24, 2015 at 2:38 PM, Lars-Peter Clausen wrote: > On 03/24/2015 02:26 PM, Robert Dolca wrote: >> On Tue, Mar 24, 2015 at 2:17 PM, Lars-Peter Clausen >> wrote: >> In the ACPI description you specify one or more IRQ GPIO pins. In the >> driver you request the GPIO pin using the index.

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Lars-Peter Clausen
On 03/24/2015 02:26 PM, Robert Dolca wrote: On Tue, Mar 24, 2015 at 2:17 PM, Lars-Peter Clausen wrote: [...] +int st_sensors_acpi_i2c_probe(struct i2c_client *client, + const struct acpi_device_id *match) +{ + const struct acpi_device_id *id; + struct

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Robert Dolca
On Tue, Mar 24, 2015 at 2:17 PM, Lars-Peter Clausen wrote: > [...] >> >> +int st_sensors_acpi_i2c_probe(struct i2c_client *client, >> + const struct acpi_device_id *match) >> +{ >> + const struct acpi_device_id *id; >> + struct gpio_desc *gpiod_irq; >> +

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Lars-Peter Clausen
[...] +int st_sensors_acpi_i2c_probe(struct i2c_client *client, + const struct acpi_device_id *match) +{ + const struct acpi_device_id *id; + struct gpio_desc *gpiod_irq; + int ret; + + id = acpi_match_device(match, >dev); + if (!id) +

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Daniel Baluta
On Mon, Mar 23, 2015 at 5:18 PM, Mika Westerberg wrote: > On Mon, Mar 23, 2015 at 03:40:24PM +0200, Robert Dolca wrote: >> Signed-off-by: Robert Dolca >> --- >> drivers/iio/common/st_sensors/st_sensors_i2c.c | 35 >> ++ >> drivers/iio/gyro/st_gyro_i2c.c

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Linus Walleij
On Mon, Mar 23, 2015 at 2:40 PM, Robert Dolca wrote: Oh more comments still... > + /* Get IRQ GPIO */ > + gpiod_irq = devm_gpiod_get_index(>dev, 0, 0); > + if (IS_ERR(gpiod_irq)) > + return -ENODEV; Shouldn't that be devm_gpiod_get_index_optional()? I think the

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Linus Walleij
On Mon, Mar 23, 2015 at 2:40 PM, Robert Dolca wrote: > Signed-off-by: Robert Dolca More comments... > +static const char L3G4200D_gyro_dev_name[] = "l3g4200d"; > +static const char LSM330D_gyro_dev_name[] = "lsm330d_gyro"; > +static const char LSM330DL_gyro_dev_name[] = "lsm330dl_gyro"; >

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Linus Walleij
On Mon, Mar 23, 2015 at 2:40 PM, Robert Dolca wrote: > Signed-off-by: Robert Dolca That's a very terse commit message. > + /* Get IRQ GPIO */ > + gpiod_irq = devm_gpiod_get_index(>dev, 0, 0); > + if (IS_ERR(gpiod_irq)) > + return -ENODEV; > + > + /*

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Linus Walleij
On Mon, Mar 23, 2015 at 2:40 PM, Robert Dolca robert.do...@intel.com wrote: Signed-off-by: Robert Dolca robert.do...@intel.com That's a very terse commit message. + /* Get IRQ GPIO */ + gpiod_irq = devm_gpiod_get_index(client-dev, 0, 0); + if (IS_ERR(gpiod_irq)) +

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Daniel Baluta
On Mon, Mar 23, 2015 at 5:18 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Mon, Mar 23, 2015 at 03:40:24PM +0200, Robert Dolca wrote: Signed-off-by: Robert Dolca robert.do...@intel.com --- drivers/iio/common/st_sensors/st_sensors_i2c.c | 35 ++

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Lars-Peter Clausen
On 03/24/2015 02:26 PM, Robert Dolca wrote: On Tue, Mar 24, 2015 at 2:17 PM, Lars-Peter Clausen l...@metafoo.de wrote: [...] +int st_sensors_acpi_i2c_probe(struct i2c_client *client, + const struct acpi_device_id *match) +{ + const struct acpi_device_id *id;

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Robert Dolca
On Tue, Mar 24, 2015 at 2:17 PM, Lars-Peter Clausen l...@metafoo.de wrote: [...] +int st_sensors_acpi_i2c_probe(struct i2c_client *client, + const struct acpi_device_id *match) +{ + const struct acpi_device_id *id; + struct gpio_desc *gpiod_irq; +

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Linus Walleij
On Tue, Mar 24, 2015 at 2:38 PM, Lars-Peter Clausen l...@metafoo.de wrote: On 03/24/2015 02:26 PM, Robert Dolca wrote: On Tue, Mar 24, 2015 at 2:17 PM, Lars-Peter Clausen l...@metafoo.de wrote: In the ACPI description you specify one or more IRQ GPIO pins. In the driver you request the GPIO

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Linus Walleij
On Mon, Mar 23, 2015 at 2:40 PM, Robert Dolca robert.do...@intel.com wrote: Oh more comments still... + /* Get IRQ GPIO */ + gpiod_irq = devm_gpiod_get_index(client-dev, 0, 0); + if (IS_ERR(gpiod_irq)) + return -ENODEV; Shouldn't that be

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Lars-Peter Clausen
[...] +int st_sensors_acpi_i2c_probe(struct i2c_client *client, + const struct acpi_device_id *match) +{ + const struct acpi_device_id *id; + struct gpio_desc *gpiod_irq; + int ret; + + id = acpi_match_device(match, client-dev); + if

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Linus Walleij
On Mon, Mar 23, 2015 at 2:40 PM, Robert Dolca robert.do...@intel.com wrote: Signed-off-by: Robert Dolca robert.do...@intel.com More comments... +static const char L3G4200D_gyro_dev_name[] = l3g4200d; +static const char LSM330D_gyro_dev_name[] = lsm330d_gyro; +static const char

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Mika Westerberg
On Tue, Mar 24, 2015 at 02:57:49PM +0100, Linus Walleij wrote: On Tue, Mar 24, 2015 at 2:38 PM, Lars-Peter Clausen l...@metafoo.de wrote: On 03/24/2015 02:26 PM, Robert Dolca wrote: On Tue, Mar 24, 2015 at 2:17 PM, Lars-Peter Clausen l...@metafoo.de wrote: In the ACPI description you

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Lars-Peter Clausen
Add Alexandre and linux-gpio to Cc. On 03/24/2015 04:06 PM, Mika Westerberg wrote: On Tue, Mar 24, 2015 at 02:57:49PM +0100, Linus Walleij wrote: On Tue, Mar 24, 2015 at 2:38 PM, Lars-Peter Clausen l...@metafoo.de wrote: On 03/24/2015 02:26 PM, Robert Dolca wrote: On Tue, Mar 24, 2015 at

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Daniel Baluta
On Tue, Mar 24, 2015 at 5:22 PM, Lars-Peter Clausen l...@metafoo.de wrote: Add Alexandre and linux-gpio to Cc. On 03/24/2015 04:06 PM, Mika Westerberg wrote: On Tue, Mar 24, 2015 at 02:57:49PM +0100, Linus Walleij wrote: On Tue, Mar 24, 2015 at 2:38 PM, Lars-Peter Clausen l...@metafoo.de

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Mika Westerberg
On Tue, Mar 24, 2015 at 04:22:16PM +0100, Lars-Peter Clausen wrote: Add Alexandre and linux-gpio to Cc. On 03/24/2015 04:06 PM, Mika Westerberg wrote: On Tue, Mar 24, 2015 at 02:57:49PM +0100, Linus Walleij wrote: On Tue, Mar 24, 2015 at 2:38 PM, Lars-Peter Clausen l...@metafoo.de wrote: On

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Mika Westerberg
On Tue, Mar 24, 2015 at 05:43:21PM +0100, Lars-Peter Clausen wrote: On 03/24/2015 04:55 PM, Mika Westerberg wrote: On Tue, Mar 24, 2015 at 04:22:16PM +0100, Lars-Peter Clausen wrote: Add Alexandre and linux-gpio to Cc. On 03/24/2015 04:06 PM, Mika Westerberg wrote: On Tue, Mar 24, 2015 at

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-24 Thread Lars-Peter Clausen
On 03/24/2015 04:55 PM, Mika Westerberg wrote: On Tue, Mar 24, 2015 at 04:22:16PM +0100, Lars-Peter Clausen wrote: Add Alexandre and linux-gpio to Cc. On 03/24/2015 04:06 PM, Mika Westerberg wrote: On Tue, Mar 24, 2015 at 02:57:49PM +0100, Linus Walleij wrote: On Tue, Mar 24, 2015 at 2:38

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-23 Thread Mika Westerberg
On Mon, Mar 23, 2015 at 03:40:24PM +0200, Robert Dolca wrote: > Signed-off-by: Robert Dolca > --- > drivers/iio/common/st_sensors/st_sensors_i2c.c | 35 > ++ > drivers/iio/gyro/st_gyro_i2c.c | 29 - >

[PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-23 Thread Robert Dolca
Signed-off-by: Robert Dolca --- drivers/iio/common/st_sensors/st_sensors_i2c.c | 35 ++ drivers/iio/gyro/st_gyro_i2c.c | 29 - include/linux/iio/common/st_sensors_i2c.h | 3 +++ 3 files changed, 66 insertions(+), 1 deletion(-)

[PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-23 Thread Robert Dolca
Signed-off-by: Robert Dolca robert.do...@intel.com --- drivers/iio/common/st_sensors/st_sensors_i2c.c | 35 ++ drivers/iio/gyro/st_gyro_i2c.c | 29 - include/linux/iio/common/st_sensors_i2c.h | 3 +++ 3 files changed, 66

Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes

2015-03-23 Thread Mika Westerberg
On Mon, Mar 23, 2015 at 03:40:24PM +0200, Robert Dolca wrote: Signed-off-by: Robert Dolca robert.do...@intel.com --- drivers/iio/common/st_sensors/st_sensors_i2c.c | 35 ++ drivers/iio/gyro/st_gyro_i2c.c | 29 -