Re: [PATCH] IOATDMA: fix section mismatches

2007-06-25 Thread Sam Ravnborg
On Mon, Jun 25, 2007 at 02:51:47PM -0700, Randy Dunlap wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > > Rename struct pci_driver data so that false section mismatch > warnings won't be produced. > > Sam, ISTM that depending on variable names is the weakest & worst part of > modpost section

[PATCH] IOATDMA: fix section mismatches

2007-06-25 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Rename struct pci_driver data so that false section mismatch warnings won't be produced. Sam, ISTM that depending on variable names is the weakest & worst part of modpost section checking. Should __init_refok work here? I got build errors when I tried to

[PATCH] IOATDMA: fix section mismatches

2007-06-25 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Rename struct pci_driver data so that false section mismatch warnings won't be produced. Sam, ISTM that depending on variable names is the weakest worst part of modpost section checking. Should __init_refok work here? I got build errors when I tried to use

Re: [PATCH] IOATDMA: fix section mismatches

2007-06-25 Thread Sam Ravnborg
On Mon, Jun 25, 2007 at 02:51:47PM -0700, Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Rename struct pci_driver data so that false section mismatch warnings won't be produced. Sam, ISTM that depending on variable names is the weakest worst part of modpost section checking.