[PATCH] Initialise SAK member for each virtual console to prevent oops

2007-03-15 Thread Bernhard Walle
This patch initialises the SAK member of the vc_cons variable on all virtual terminals, not only the first one. This prevents an oops when trying Sysrq-C on e.g. the second virtual terminal: kernel BUG at kernel/workqueue.c:212! invalid opcode: [1] SMP CPU 0 Modules linked in: i915

[PATCH] Initialise SAK member for each virtual console to prevent oops

2007-03-15 Thread Bernhard Walle
This patch initialises the SAK member of the vc_cons variable on all virtual terminals, not only the first one. This prevents an oops when trying Sysrq-C on e.g. the second virtual terminal: kernel BUG at kernel/workqueue.c:212! invalid opcode: [1] SMP CPU 0 Modules linked in: i915

Re: [PATCH] Initialise SAK member for each virtual console to prevent oops

2007-03-13 Thread Eric W. Biederman
Ugh. I missed this one, when I fixed this. Sorry I thought the loop in con_init() covered all of the consoles and we initialized all of them at boot time :( Bernhard Walle <[EMAIL PROTECTED]> writes: > This patch initialises the SAK member of the vc_cons variable on all virtual > terminals,

Re: [PATCH] Initialise SAK member for each virtual console to prevent oops

2007-03-13 Thread Eric W. Biederman
Ugh. I missed this one, when I fixed this. Sorry I thought the loop in con_init() covered all of the consoles and we initialized all of them at boot time :( Bernhard Walle [EMAIL PROTECTED] writes: This patch initialises the SAK member of the vc_cons variable on all virtual terminals, not

[PATCH] Initialise SAK member for each virtual console to prevent oops

2007-03-11 Thread Bernhard Walle
This patch initialises the SAK member of the vc_cons variable on all virtual terminals, not only the first one. This prevents an oops when trying Sysrq-C on e.g. the second virtual terminal: kernel BUG at kernel/workqueue.c:212! invalid opcode: [1] SMP CPU 0 Modules linked in: i915

Re: [PATCH] Initialise SAK member for each virtual console to prevent oops

2007-03-11 Thread Bernhard Walle
* David Miller <[EMAIL PROTECTED]> [2007-03-11 21:52]: > > + /* INIT_WORK(_cons[currcons].SAK_work, vc_SAK); */ > > The code is commented out, so it won't do anything. Sorry, you're right. I commented the line out just to generate again the oops message to write the patch description

Re: [PATCH] Initialise SAK member for each virtual console to prevent oops

2007-03-11 Thread David Miller
From: Bernhard Walle <[EMAIL PROTECTED]> Date: Sun, 11 Mar 2007 21:41:38 +0100 > This patch initialises the SAK member of the vc_cons variable on all virtual > terminals, not only the first one. No it doesn't > --- linux-2.6.21-rc3.orig/drivers/char/vt.c > +++ linux-2.6.21-rc3/drivers/char/vt.c

[PATCH] Initialise SAK member for each virtual console to prevent oops

2007-03-11 Thread Bernhard Walle
This patch initialises the SAK member of the vc_cons variable on all virtual terminals, not only the first one. This prevents an oops when trying Sysrq-C on e.g. the second virtual terminal: kernel BUG at kernel/workqueue.c:212! invalid opcode: [1] SMP CPU 0 Modules linked in: i915

[PATCH] Initialise SAK member for each virtual console to prevent oops

2007-03-11 Thread Bernhard Walle
This patch initialises the SAK member of the vc_cons variable on all virtual terminals, not only the first one. This prevents an oops when trying Sysrq-C on e.g. the second virtual terminal: kernel BUG at kernel/workqueue.c:212! invalid opcode: [1] SMP CPU 0 Modules linked in: i915

Re: [PATCH] Initialise SAK member for each virtual console to prevent oops

2007-03-11 Thread David Miller
From: Bernhard Walle [EMAIL PROTECTED] Date: Sun, 11 Mar 2007 21:41:38 +0100 This patch initialises the SAK member of the vc_cons variable on all virtual terminals, not only the first one. No it doesn't --- linux-2.6.21-rc3.orig/drivers/char/vt.c +++ linux-2.6.21-rc3/drivers/char/vt.c @@

Re: [PATCH] Initialise SAK member for each virtual console to prevent oops

2007-03-11 Thread Bernhard Walle
* David Miller [EMAIL PROTECTED] [2007-03-11 21:52]: + /* INIT_WORK(vc_cons[currcons].SAK_work, vc_SAK); */ The code is commented out, so it won't do anything. Sorry, you're right. I commented the line out just to generate again the oops message to write the patch description because

[PATCH] Initialise SAK member for each virtual console to prevent oops

2007-03-11 Thread Bernhard Walle
This patch initialises the SAK member of the vc_cons variable on all virtual terminals, not only the first one. This prevents an oops when trying Sysrq-C on e.g. the second virtual terminal: kernel BUG at kernel/workqueue.c:212! invalid opcode: [1] SMP CPU 0 Modules linked in: i915