RE: [PATCH] Input: adp5589-keys - use BIT()

2020-11-19 Thread Ardelean, Alexandru
> -Original Message- > From: Dmitry Torokhov > Sent: Thursday, November 19, 2020 9:25 AM > To: linux-in...@vger.kernel.org > Cc: Ardelean, Alexandru ; linux- > ker...@vger.kernel.org > Subject: [PATCH] Input: adp5589-keys - use BIT() > > [External] > &

Re: [PATCH] Input: adp5589-keys - use BIT()

2020-11-18 Thread Dmitry Torokhov
On Wed, Nov 18, 2020 at 11:34:28PM -0800, Joe Perches wrote: > On Wed, 2020-11-18 at 23:24 -0800, Dmitry Torokhov wrote: > > Let's use BIT() macro instead of explicitly shifting '1'. > [] > > diff --git a/drivers/input/keyboard/adp5589-keys.c > > b/drivers/input/keyboard/adp5589-keys.c > > > @@

Re: [PATCH] Input: adp5589-keys - use BIT()

2020-11-18 Thread Joe Perches
On Wed, 2020-11-18 at 23:24 -0800, Dmitry Torokhov wrote: > Let's use BIT() macro instead of explicitly shifting '1'. [] > diff --git a/drivers/input/keyboard/adp5589-keys.c > b/drivers/input/keyboard/adp5589-keys.c > @@ -651,13 +652,13 @@ static int adp5589_setup(struct adp5589_kpad *kpad) >  

[PATCH] Input: adp5589-keys - use BIT()

2020-11-18 Thread Dmitry Torokhov
Let's use BIT() macro instead of explicitly shifting '1'. Signed-off-by: Dmitry Torokhov --- drivers/input/keyboard/adp5589-keys.c | 69 ++- 1 file changed, 35 insertions(+), 34 deletions(-) diff --git a/drivers/input/keyboard/adp5589-keys.c