Re: [PATCH] Input: matrix_keypad - use flush_delayed_work()

2019-02-11 Thread Sven Van Asbroeck
On Mon, Feb 11, 2019 at 3:29 AM Dmitry Torokhov wrote: > > It will not schedule new work because we check keypad->stopped flag > in ISR. > Yes, you are correct. Sorry for the confusion. Reviewed-by: Sven Van Asbroeck

Re: [PATCH] Input: matrix_keypad - use flush_delayed_work()

2019-02-11 Thread Dmitry Torokhov
Hi Sven, On Sun, Feb 10, 2019 at 12:43:21PM -0500, Sven Van Asbroeck wrote: > Hi Dmitry, > > On Thu, Feb 7, 2019 at 5:46 PM Dmitry Torokhov > wrote: > > > > We should be using flush_delayed_work() instead of flush_work() in > > matrix_keypad_stop() to ensure that we are not missing work that is

Re: [PATCH] Input: matrix_keypad - use flush_delayed_work()

2019-02-10 Thread Sven Van Asbroeck
Hi Dmitry, On Thu, Feb 7, 2019 at 5:46 PM Dmitry Torokhov wrote: > > We should be using flush_delayed_work() instead of flush_work() in > matrix_keypad_stop() to ensure that we are not missing work that is > scheduled but not yet put in the workqueue (i.e. its delay timer has not > expired yet).

[PATCH] Input: matrix_keypad - use flush_delayed_work()

2019-02-07 Thread Dmitry Torokhov
We should be using flush_delayed_work() instead of flush_work() in matrix_keypad_stop() to ensure that we are not missing work that is scheduled but not yet put in the workqueue (i.e. its delay timer has not expired yet). Signed-off-by: Dmitry Torokhov --- drivers/input/keyboard/matrix_keypad.c