Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-10-01 Thread Guenter Roeck
On 10/01/2016 12:04 PM, Dmitry Torokhov wrote: On Sat, Oct 01, 2016 at 10:27:42AM -0700, Andrew Duggan wrote: On Fri, Sep 30, 2016, at 08:44 PM, Guenter Roeck wrote: On 09/30/2016 04:02 PM, Dmitry Torokhov wrote: On Fri, Sep 30, 2016 at 03:54:03PM -0700, Dmitry Torokhov wrote: On Thu, Sep

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-10-01 Thread Guenter Roeck
On 10/01/2016 12:04 PM, Dmitry Torokhov wrote: On Sat, Oct 01, 2016 at 10:27:42AM -0700, Andrew Duggan wrote: On Fri, Sep 30, 2016, at 08:44 PM, Guenter Roeck wrote: On 09/30/2016 04:02 PM, Dmitry Torokhov wrote: On Fri, Sep 30, 2016 at 03:54:03PM -0700, Dmitry Torokhov wrote: On Thu, Sep

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-10-01 Thread Dmitry Torokhov
On Sat, Oct 01, 2016 at 10:27:42AM -0700, Andrew Duggan wrote: > > > On Fri, Sep 30, 2016, at 08:44 PM, Guenter Roeck wrote: > > On 09/30/2016 04:02 PM, Dmitry Torokhov wrote: > > > On Fri, Sep 30, 2016 at 03:54:03PM -0700, Dmitry Torokhov wrote: > > >> On Thu, Sep 29, 2016 at 10:55:40AM -0700,

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-10-01 Thread Dmitry Torokhov
On Sat, Oct 01, 2016 at 10:27:42AM -0700, Andrew Duggan wrote: > > > On Fri, Sep 30, 2016, at 08:44 PM, Guenter Roeck wrote: > > On 09/30/2016 04:02 PM, Dmitry Torokhov wrote: > > > On Fri, Sep 30, 2016 at 03:54:03PM -0700, Dmitry Torokhov wrote: > > >> On Thu, Sep 29, 2016 at 10:55:40AM -0700,

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-10-01 Thread Andrew Duggan
On Sat, Oct 1, 2016, at 10:45 AM, Guenter Roeck wrote: > On 10/01/2016 10:27 AM, Andrew Duggan wrote: > > > > > > On Fri, Sep 30, 2016, at 08:44 PM, Guenter Roeck wrote: > >> On 09/30/2016 04:02 PM, Dmitry Torokhov wrote: > >>> On Fri, Sep 30, 2016 at 03:54:03PM -0700, Dmitry Torokhov wrote: >

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-10-01 Thread Andrew Duggan
On Sat, Oct 1, 2016, at 10:45 AM, Guenter Roeck wrote: > On 10/01/2016 10:27 AM, Andrew Duggan wrote: > > > > > > On Fri, Sep 30, 2016, at 08:44 PM, Guenter Roeck wrote: > >> On 09/30/2016 04:02 PM, Dmitry Torokhov wrote: > >>> On Fri, Sep 30, 2016 at 03:54:03PM -0700, Dmitry Torokhov wrote: >

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-10-01 Thread Guenter Roeck
On 10/01/2016 10:27 AM, Andrew Duggan wrote: On Fri, Sep 30, 2016, at 08:44 PM, Guenter Roeck wrote: On 09/30/2016 04:02 PM, Dmitry Torokhov wrote: On Fri, Sep 30, 2016 at 03:54:03PM -0700, Dmitry Torokhov wrote: On Thu, Sep 29, 2016 at 10:55:40AM -0700, Bjorn Andersson wrote: On Wed 28

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-10-01 Thread Guenter Roeck
On 10/01/2016 10:27 AM, Andrew Duggan wrote: On Fri, Sep 30, 2016, at 08:44 PM, Guenter Roeck wrote: On 09/30/2016 04:02 PM, Dmitry Torokhov wrote: On Fri, Sep 30, 2016 at 03:54:03PM -0700, Dmitry Torokhov wrote: On Thu, Sep 29, 2016 at 10:55:40AM -0700, Bjorn Andersson wrote: On Wed 28

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-10-01 Thread Andrew Duggan
On Fri, Sep 30, 2016, at 08:44 PM, Guenter Roeck wrote: > On 09/30/2016 04:02 PM, Dmitry Torokhov wrote: > > On Fri, Sep 30, 2016 at 03:54:03PM -0700, Dmitry Torokhov wrote: > >> On Thu, Sep 29, 2016 at 10:55:40AM -0700, Bjorn Andersson wrote: > >>> On Wed 28 Sep 17:37 PDT 2016, Guenter Roeck

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-10-01 Thread Andrew Duggan
On Fri, Sep 30, 2016, at 08:44 PM, Guenter Roeck wrote: > On 09/30/2016 04:02 PM, Dmitry Torokhov wrote: > > On Fri, Sep 30, 2016 at 03:54:03PM -0700, Dmitry Torokhov wrote: > >> On Thu, Sep 29, 2016 at 10:55:40AM -0700, Bjorn Andersson wrote: > >>> On Wed 28 Sep 17:37 PDT 2016, Guenter Roeck

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-09-30 Thread Guenter Roeck
On 09/30/2016 04:02 PM, Dmitry Torokhov wrote: On Fri, Sep 30, 2016 at 03:54:03PM -0700, Dmitry Torokhov wrote: On Thu, Sep 29, 2016 at 10:55:40AM -0700, Bjorn Andersson wrote: On Wed 28 Sep 17:37 PDT 2016, Guenter Roeck wrote: Instantiating the rmi4 I2C transport driver without interrupts

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-09-30 Thread Guenter Roeck
On 09/30/2016 04:02 PM, Dmitry Torokhov wrote: On Fri, Sep 30, 2016 at 03:54:03PM -0700, Dmitry Torokhov wrote: On Thu, Sep 29, 2016 at 10:55:40AM -0700, Bjorn Andersson wrote: On Wed 28 Sep 17:37 PDT 2016, Guenter Roeck wrote: Instantiating the rmi4 I2C transport driver without interrupts

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-09-30 Thread Guenter Roeck
On 09/30/2016 03:54 PM, Dmitry Torokhov wrote: On Thu, Sep 29, 2016 at 10:55:40AM -0700, Bjorn Andersson wrote: On Wed 28 Sep 17:37 PDT 2016, Guenter Roeck wrote: Instantiating the rmi4 I2C transport driver without interrupts assigned (for example using manual i2c instantiation from the

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-09-30 Thread Guenter Roeck
On 09/30/2016 03:54 PM, Dmitry Torokhov wrote: On Thu, Sep 29, 2016 at 10:55:40AM -0700, Bjorn Andersson wrote: On Wed 28 Sep 17:37 PDT 2016, Guenter Roeck wrote: Instantiating the rmi4 I2C transport driver without interrupts assigned (for example using manual i2c instantiation from the

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-09-30 Thread Dmitry Torokhov
On Fri, Sep 30, 2016 at 03:54:03PM -0700, Dmitry Torokhov wrote: > On Thu, Sep 29, 2016 at 10:55:40AM -0700, Bjorn Andersson wrote: > > On Wed 28 Sep 17:37 PDT 2016, Guenter Roeck wrote: > > > > > Instantiating the rmi4 I2C transport driver without interrupts assigned > > > (for example using

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-09-30 Thread Dmitry Torokhov
On Fri, Sep 30, 2016 at 03:54:03PM -0700, Dmitry Torokhov wrote: > On Thu, Sep 29, 2016 at 10:55:40AM -0700, Bjorn Andersson wrote: > > On Wed 28 Sep 17:37 PDT 2016, Guenter Roeck wrote: > > > > > Instantiating the rmi4 I2C transport driver without interrupts assigned > > > (for example using

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-09-30 Thread Dmitry Torokhov
On Thu, Sep 29, 2016 at 10:55:40AM -0700, Bjorn Andersson wrote: > On Wed 28 Sep 17:37 PDT 2016, Guenter Roeck wrote: > > > Instantiating the rmi4 I2C transport driver without interrupts assigned > > (for example using manual i2c instantiation from the command line) > > caused the driver to fail

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-09-30 Thread Dmitry Torokhov
On Thu, Sep 29, 2016 at 10:55:40AM -0700, Bjorn Andersson wrote: > On Wed 28 Sep 17:37 PDT 2016, Guenter Roeck wrote: > > > Instantiating the rmi4 I2C transport driver without interrupts assigned > > (for example using manual i2c instantiation from the command line) > > caused the driver to fail

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-09-29 Thread Bjorn Andersson
On Wed 28 Sep 17:37 PDT 2016, Guenter Roeck wrote: > Instantiating the rmi4 I2C transport driver without interrupts assigned > (for example using manual i2c instantiation from the command line) > caused the driver to fail to load, but it does not clean up its > regulator or transport device

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-09-29 Thread Bjorn Andersson
On Wed 28 Sep 17:37 PDT 2016, Guenter Roeck wrote: > Instantiating the rmi4 I2C transport driver without interrupts assigned > (for example using manual i2c instantiation from the command line) > caused the driver to fail to load, but it does not clean up its > regulator or transport device

[PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-09-28 Thread Guenter Roeck
Instantiating the rmi4 I2C transport driver without interrupts assigned (for example using manual i2c instantiation from the command line) caused the driver to fail to load, but it does not clean up its regulator or transport device registrations. Result is a crash at a later time, for example

[PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-09-28 Thread Guenter Roeck
Instantiating the rmi4 I2C transport driver without interrupts assigned (for example using manual i2c instantiation from the command line) caused the driver to fail to load, but it does not clean up its regulator or transport device registrations. Result is a crash at a later time, for example