[PATCH] KEYS: Make request_key() and co fundamentally asynchronous

2007-09-17 Thread David Howells
Make request_key() and co fundamentally asynchronous to make it easier for NFS to make use of them. There are now accessor functions that do asynchronous constructions, a wait function to wait for construction to complete, and a completion function for the key type to indicate completion of

Re: [PATCH] KEYS: Make request_key() and co fundamentally asynchronous

2007-09-17 Thread Andrew Morton
On Mon, 17 Sep 2007 11:56:00 +0100 David Howells <[EMAIL PROTECTED]> wrote: > > checkpatch generates a pile of warnings, all of which afacit are legit. > > For this warning: > > ERROR: need space after that ',' (ctx:WxV) > #627: FILE: security/keys/internal.h:28: > +#define kenter(FMT, ...)

Re: [PATCH] KEYS: Make request_key() and co fundamentally asynchronous

2007-09-17 Thread David Howells
Andrew Morton <[EMAIL PROTECTED]> wrote: > So who's going to review this? Nobody? Well gee, maybe it was my turn > anyway. Well, Kevin Coffman has reviewed it and tested it against his NFS keys patches. > checkpatch generates a pile of warnings, all of which afacit are legit. For this

Re: [PATCH] KEYS: Make request_key() and co fundamentally asynchronous

2007-09-17 Thread David Howells
Andrew Morton [EMAIL PROTECTED] wrote: So who's going to review this? Nobody? Well gee, maybe it was my turn anyway. Well, Kevin Coffman has reviewed it and tested it against his NFS keys patches. checkpatch generates a pile of warnings, all of which afacit are legit. For this warning:

Re: [PATCH] KEYS: Make request_key() and co fundamentally asynchronous

2007-09-17 Thread Andrew Morton
On Mon, 17 Sep 2007 11:56:00 +0100 David Howells [EMAIL PROTECTED] wrote: checkpatch generates a pile of warnings, all of which afacit are legit. For this warning: ERROR: need space after that ',' (ctx:WxV) #627: FILE: security/keys/internal.h:28: +#define kenter(FMT, ...) no_printk(==

[PATCH] KEYS: Make request_key() and co fundamentally asynchronous

2007-09-17 Thread David Howells
Make request_key() and co fundamentally asynchronous to make it easier for NFS to make use of them. There are now accessor functions that do asynchronous constructions, a wait function to wait for construction to complete, and a completion function for the key type to indicate completion of

Re: [PATCH] KEYS: Make request_key() and co fundamentally asynchronous

2007-09-14 Thread Andrew Morton
On Wed, 12 Sep 2007 15:25:08 +0100 David Howells <[EMAIL PROTECTED]> wrote: > Make request_key() and co fundamentally asynchronous to make it easier for NFS > to make use of them. There are now accessor functions that do asynchronous > constructions, a wait function to wait for construction to

Re: [PATCH] KEYS: Make request_key() and co fundamentally asynchronous

2007-09-14 Thread Andrew Morton
On Wed, 12 Sep 2007 15:25:08 +0100 David Howells [EMAIL PROTECTED] wrote: Make request_key() and co fundamentally asynchronous to make it easier for NFS to make use of them. There are now accessor functions that do asynchronous constructions, a wait function to wait for construction to

[PATCH] KEYS: Make request_key() and co fundamentally asynchronous

2007-09-12 Thread David Howells
Make request_key() and co fundamentally asynchronous to make it easier for NFS to make use of them. There are now accessor functions that do asynchronous constructions, a wait function to wait for construction to complete, and a completion function for the key type to indicate completion of

[PATCH] KEYS: Make request_key() and co fundamentally asynchronous

2007-09-12 Thread David Howells
Make request_key() and co fundamentally asynchronous to make it easier for NFS to make use of them. There are now accessor functions that do asynchronous constructions, a wait function to wait for construction to complete, and a completion function for the key type to indicate completion of