Re: [PATCH] KVM: MMU: avoid fast page fault fixing mmio page fault

2013-07-18 Thread Gleb Natapov
this on > >>> Intel without ept. > >> > >> Since currently fast page fault only works for direct mmu. :) > > Ah, yes. So with shadow page and paging disabled in a guest is can > > happen eventually, but we do not trigger it for some reason? > > Ye

Re: [PATCH] KVM: MMU: avoid fast page fault fixing mmio page fault

2013-07-18 Thread Xiao Guangrong
st is can > happen eventually, but we do not trigger it for some reason? Yes. I guess so, paging disable is short-lived and the sptes will be invalid after memslot changed for 150 times, so it is hard to be triggered. I should update this to the changelog, thanks for your reminder, Gleb. ===

Re: [PATCH] KVM: MMU: avoid fast page fault fixing mmio page fault

2013-07-18 Thread Gleb Natapov
On Thu, Jul 18, 2013 at 02:01:47PM +0800, Xiao Guangrong wrote: > On 07/18/2013 01:31 PM, Gleb Natapov wrote: > > On Thu, Jul 18, 2013 at 12:52:37PM +0800, Xiao Guangrong wrote: > >> Currently, fast page fault tries to fix mmio page fault when the > >> generation number is invalid (spte.gen !=

Re: [PATCH] KVM: MMU: avoid fast page fault fixing mmio page fault

2013-07-18 Thread Xiao Guangrong
On 07/18/2013 01:31 PM, Gleb Natapov wrote: > On Thu, Jul 18, 2013 at 12:52:37PM +0800, Xiao Guangrong wrote: >> Currently, fast page fault tries to fix mmio page fault when the >> generation number is invalid (spte.gen != kvm.gen) and returns to >> guest to retry the fault since it sees the last

Re: [PATCH] KVM: MMU: avoid fast page fault fixing mmio page fault

2013-07-18 Thread Xiao Guangrong
On 07/18/2013 01:31 PM, Gleb Natapov wrote: On Thu, Jul 18, 2013 at 12:52:37PM +0800, Xiao Guangrong wrote: Currently, fast page fault tries to fix mmio page fault when the generation number is invalid (spte.gen != kvm.gen) and returns to guest to retry the fault since it sees the last spte is

Re: [PATCH] KVM: MMU: avoid fast page fault fixing mmio page fault

2013-07-18 Thread Gleb Natapov
On Thu, Jul 18, 2013 at 02:01:47PM +0800, Xiao Guangrong wrote: On 07/18/2013 01:31 PM, Gleb Natapov wrote: On Thu, Jul 18, 2013 at 12:52:37PM +0800, Xiao Guangrong wrote: Currently, fast page fault tries to fix mmio page fault when the generation number is invalid (spte.gen != kvm.gen) and

Re: [PATCH] KVM: MMU: avoid fast page fault fixing mmio page fault

2013-07-18 Thread Xiao Guangrong
for your reminder, Gleb. == [PATCH] KVM: MMU: avoid fast page fault fixing mmio page fault Currently, fast page fault tries to fix mmio page fault when the generation number is invalid (spte.gen != kvm.gen) and returns to guest to retry the fault since it sees the last spte is nonpresent. It causes

Re: [PATCH] KVM: MMU: avoid fast page fault fixing mmio page fault

2013-07-18 Thread Gleb Natapov
for 150 times, so it is hard to be triggered. I should update this to the changelog, thanks for your reminder, Gleb. == [PATCH] KVM: MMU: avoid fast page fault fixing mmio page fault Currently, fast page fault tries to fix mmio page fault when the generation number is invalid (spte.gen

Re: [PATCH] KVM: MMU: avoid fast page fault fixing mmio page fault

2013-07-17 Thread Gleb Natapov
On Thu, Jul 18, 2013 at 12:52:37PM +0800, Xiao Guangrong wrote: > Currently, fast page fault tries to fix mmio page fault when the > generation number is invalid (spte.gen != kvm.gen) and returns to > guest to retry the fault since it sees the last spte is nonpresent > which causes infinity loop >

Re: [PATCH] KVM: MMU: avoid fast page fault fixing mmio page fault

2013-07-17 Thread Xiao Guangrong
On 07/18/2013 12:52 PM, Xiao Guangrong wrote: > Currently, fast page fault tries to fix mmio page fault when the > generation number is invalid (spte.gen != kvm.gen) and returns to > guest to retry the fault since it sees the last spte is nonpresent > which causes infinity loop > > It can be

[PATCH] KVM: MMU: avoid fast page fault fixing mmio page fault

2013-07-17 Thread Xiao Guangrong
Currently, fast page fault tries to fix mmio page fault when the generation number is invalid (spte.gen != kvm.gen) and returns to guest to retry the fault since it sees the last spte is nonpresent which causes infinity loop It can be triggered only on AMD host since the mmio page fault is

[PATCH] KVM: MMU: avoid fast page fault fixing mmio page fault

2013-07-17 Thread Xiao Guangrong
Currently, fast page fault tries to fix mmio page fault when the generation number is invalid (spte.gen != kvm.gen) and returns to guest to retry the fault since it sees the last spte is nonpresent which causes infinity loop It can be triggered only on AMD host since the mmio page fault is

Re: [PATCH] KVM: MMU: avoid fast page fault fixing mmio page fault

2013-07-17 Thread Xiao Guangrong
On 07/18/2013 12:52 PM, Xiao Guangrong wrote: Currently, fast page fault tries to fix mmio page fault when the generation number is invalid (spte.gen != kvm.gen) and returns to guest to retry the fault since it sees the last spte is nonpresent which causes infinity loop It can be triggered

Re: [PATCH] KVM: MMU: avoid fast page fault fixing mmio page fault

2013-07-17 Thread Gleb Natapov
On Thu, Jul 18, 2013 at 12:52:37PM +0800, Xiao Guangrong wrote: Currently, fast page fault tries to fix mmio page fault when the generation number is invalid (spte.gen != kvm.gen) and returns to guest to retry the fault since it sees the last spte is nonpresent which causes infinity loop It