Re: [PATCH] KVM: SVM: Analyze is_guest_mode() in svm_vcpu_run()

2020-09-22 Thread Haiwei Li
On Tue, Sep 22, 2020 at 10:56 PM Paolo Bonzini wrote: > > On 22/09/20 16:54, Haiwei Li wrote: > >> EXIT_FASTPATH_REENTER_GUEST handling up to vcpu_enter_guest)... > > Hi, Paolo > > > > I have sent a patch to do this, > > > >

Re: [PATCH] KVM: SVM: Analyze is_guest_mode() in svm_vcpu_run()

2020-09-22 Thread Paolo Bonzini
On 22/09/20 16:54, Haiwei Li wrote: >> EXIT_FASTPATH_REENTER_GUEST handling up to vcpu_enter_guest)... > Hi, Paolo > > I have sent a patch to do this, > > https://lore.kernel.org/kvm/20200915113033.61817-1-lihaiwei.ker...@gmail.com/ Cool, thanks. I think I'll just squash it in Wanpeng's if you

Re: [PATCH] KVM: SVM: Analyze is_guest_mode() in svm_vcpu_run()

2020-09-22 Thread Haiwei Li
On 20/9/22 21:43, Paolo Bonzini wrote: > On 14/09/20 22:43, Krish Sadhukhan wrote: >>> >> >> Not related to your changes, but should we get rid of the variable >> 'exit_fastpath' and just do, >> >> return svm_exit_handler_fastpath(vcpu); >> >> It seems the variable isn't used anywhere

Re: [PATCH] KVM: SVM: Analyze is_guest_mode() in svm_vcpu_run()

2020-09-22 Thread Paolo Bonzini
On 14/09/20 22:43, Krish Sadhukhan wrote: >> > > Not related to your changes, but should we get rid of the variable > 'exit_fastpath' and just do, > >         return svm_exit_handler_fastpath(vcpu); > > It seems the variable isn't used anywhere else and svm_vcpu_run() > doesn't return from

Re: [PATCH] KVM: SVM: Analyze is_guest_mode() in svm_vcpu_run()

2020-09-15 Thread Haiwei Li
On 20/9/15 04:43, Krish Sadhukhan wrote: On 9/13/20 11:55 PM, Wanpeng Li wrote: From: Wanpeng Li Analyze is_guest_mode() in svm_vcpu_run() instead of svm_exit_handlers_fastpath() in conformity with VMX version. Suggested-by: Vitaly Kuznetsov Signed-off-by: Wanpeng Li ---  

Re: [PATCH] KVM: SVM: Analyze is_guest_mode() in svm_vcpu_run()

2020-09-14 Thread Krish Sadhukhan
On 9/13/20 11:55 PM, Wanpeng Li wrote: From: Wanpeng Li Analyze is_guest_mode() in svm_vcpu_run() instead of svm_exit_handlers_fastpath() in conformity with VMX version. Suggested-by: Vitaly Kuznetsov Signed-off-by: Wanpeng Li --- arch/x86/kvm/svm/svm.c | 7 +-- 1 file changed, 5

[PATCH] KVM: SVM: Analyze is_guest_mode() in svm_vcpu_run()

2020-09-14 Thread Wanpeng Li
From: Wanpeng Li Analyze is_guest_mode() in svm_vcpu_run() instead of svm_exit_handlers_fastpath() in conformity with VMX version. Suggested-by: Vitaly Kuznetsov Signed-off-by: Wanpeng Li --- arch/x86/kvm/svm/svm.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git