Re: [PATCH] KVM: VMX: fix crash cleanup when KVM wasn't used

2020-09-02 Thread Sean Christopherson
On Tue, Sep 01, 2020 at 12:36:40PM +0200, Vitaly Kuznetsov wrote: > Sean Christopherson writes: > > > On Mon, Aug 24, 2020 at 03:45:26PM -0700, Jim Mattson wrote: > >> On Mon, Aug 24, 2020 at 11:57 AM Jim Mattson wrote: > >> > > >> > On Fri, Aug 21, 2020 at 8:40 PM Sean Christopherson > >> > wr

Re: [PATCH] KVM: VMX: fix crash cleanup when KVM wasn't used

2020-09-01 Thread Vitaly Kuznetsov
Sean Christopherson writes: > On Mon, Aug 24, 2020 at 03:45:26PM -0700, Jim Mattson wrote: >> On Mon, Aug 24, 2020 at 11:57 AM Jim Mattson wrote: >> > >> > On Fri, Aug 21, 2020 at 8:40 PM Sean Christopherson >> > wrote: >> > > I agree the code is a mess (kvm_init() and kvm_exit() included), but

Re: [PATCH] KVM: VMX: fix crash cleanup when KVM wasn't used

2020-08-24 Thread Sean Christopherson
On Mon, Aug 24, 2020 at 03:45:26PM -0700, Jim Mattson wrote: > On Mon, Aug 24, 2020 at 11:57 AM Jim Mattson wrote: > > > > On Fri, Aug 21, 2020 at 8:40 PM Sean Christopherson > > wrote: > > > I agree the code is a mess (kvm_init() and kvm_exit() included), but I'm > > > pretty sure hardware_disab

Re: [PATCH] KVM: VMX: fix crash cleanup when KVM wasn't used

2020-08-24 Thread Jim Mattson
On Mon, Aug 24, 2020 at 11:57 AM Jim Mattson wrote: > > On Fri, Aug 21, 2020 at 8:40 PM Sean Christopherson > wrote: > > > > On Thu, Aug 20, 2020 at 01:08:22PM -0700, Jim Mattson wrote: > > > On Wed, Apr 1, 2020 at 1:13 AM Vitaly Kuznetsov > > > wrote: > > > > --- > > > > arch/x86/kvm/vmx/vmx.

Re: [PATCH] KVM: VMX: fix crash cleanup when KVM wasn't used

2020-08-24 Thread Jim Mattson
On Fri, Aug 21, 2020 at 8:40 PM Sean Christopherson wrote: > > On Thu, Aug 20, 2020 at 01:08:22PM -0700, Jim Mattson wrote: > > On Wed, Apr 1, 2020 at 1:13 AM Vitaly Kuznetsov wrote: > > > --- > > > arch/x86/kvm/vmx/vmx.c | 12 +++- > > > 1 file changed, 7 insertions(+), 5 deletions(-) >

Re: [PATCH] KVM: VMX: fix crash cleanup when KVM wasn't used

2020-08-21 Thread Sean Christopherson
On Thu, Aug 20, 2020 at 01:08:22PM -0700, Jim Mattson wrote: > On Wed, Apr 1, 2020 at 1:13 AM Vitaly Kuznetsov wrote: > > --- > > arch/x86/kvm/vmx/vmx.c | 12 +++- > > 1 file changed, 7 insertions(+), 5 deletions(-) > > > > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > >

Re: [PATCH] KVM: VMX: fix crash cleanup when KVM wasn't used

2020-08-20 Thread Jim Mattson
On Wed, Apr 1, 2020 at 1:13 AM Vitaly Kuznetsov wrote: > > If KVM wasn't used at all before we crash the cleanup procedure fails with > BUG: unable to handle page fault for address: ffc8 > #PF: supervisor read access in kernel mode > #PF: error_code(0x) - not-present page > PGD