Re: [PATCH] KVM: nVMX: preserve SECONDARY_EXEC_DESC without UMIP

2018-01-31 Thread Paolo Bonzini
On 31/01/2018 12:12, Radim Krčmář wrote: > L1 might want to use SECONDARY_EXEC_DESC, so we must not clear the VMCS > bit if UMIP is not being emulated. > > We must still set the bit when emulating UMIP as the feature can be > passed to L2 where L0 will do the emulation and because L2 can change >

Re: [PATCH] KVM: nVMX: preserve SECONDARY_EXEC_DESC without UMIP

2018-01-31 Thread Paolo Bonzini
On 31/01/2018 12:12, Radim Krčmář wrote: > L1 might want to use SECONDARY_EXEC_DESC, so we must not clear the VMCS > bit if UMIP is not being emulated. > > We must still set the bit when emulating UMIP as the feature can be > passed to L2 where L0 will do the emulation and because L2 can change >

[PATCH] KVM: nVMX: preserve SECONDARY_EXEC_DESC without UMIP

2018-01-31 Thread Radim Krčmář
L1 might want to use SECONDARY_EXEC_DESC, so we must not clear the VMCS bit if UMIP is not being emulated. We must still set the bit when emulating UMIP as the feature can be passed to L2 where L0 will do the emulation and because L2 can change CR4 without a VM exit, we should clear the bit if

[PATCH] KVM: nVMX: preserve SECONDARY_EXEC_DESC without UMIP

2018-01-31 Thread Radim Krčmář
L1 might want to use SECONDARY_EXEC_DESC, so we must not clear the VMCS bit if UMIP is not being emulated. We must still set the bit when emulating UMIP as the feature can be passed to L2 where L0 will do the emulation and because L2 can change CR4 without a VM exit, we should clear the bit if