Re: [PATCH] KVM: x86: Don't update RIP or do single-step on faulting emulation

2019-08-27 Thread Sean Christopherson
On Tue, Aug 27, 2019 at 12:12:51PM -0700, Jim Mattson wrote: > On Fri, Aug 23, 2019 at 1:55 PM Sean Christopherson > wrote: > > --- a/arch/x86/kvm/x86.c > > +++ b/arch/x86/kvm/x86.c > > @@ -6611,12 +6611,13 @@ int x86_emulate_instruction(struct kvm_vcpu *vcpu, > > unsigned long

Re: [PATCH] KVM: x86: Don't update RIP or do single-step on faulting emulation

2019-08-27 Thread Jim Mattson
On Fri, Aug 23, 2019 at 1:55 PM Sean Christopherson wrote: > > Don't advance RIP or inject a single-step #DB if emulation signals a > fault. This logic applies to all state updates that are conditional on > clean retirement of the emulation instruction, e.g. updating RFLAGS was > previously

Re: [PATCH] KVM: x86: Don't update RIP or do single-step on faulting emulation

2019-08-27 Thread Radim Krčmář
2019-08-23 13:55-0700, Sean Christopherson: > Don't advance RIP or inject a single-step #DB if emulation signals a > fault. This logic applies to all state updates that are conditional on > clean retirement of the emulation instruction, e.g. updating RFLAGS was > previously handled by commit

Re: [PATCH] KVM: x86: Don't update RIP or do single-step on faulting emulation

2019-08-26 Thread Sean Christopherson
On Fri, Aug 23, 2019 at 03:46:20PM -0700, Andy Lutomirski wrote: > On Fri, Aug 23, 2019 at 1:55 PM Sean Christopherson > wrote: > > > > Don't advance RIP or inject a single-step #DB if emulation signals a > > fault. This logic applies to all state updates that are conditional on > > clean

Re: [PATCH] KVM: x86: Don't update RIP or do single-step on faulting emulation

2019-08-23 Thread Andy Lutomirski
On Fri, Aug 23, 2019 at 1:55 PM Sean Christopherson wrote: > > Don't advance RIP or inject a single-step #DB if emulation signals a > fault. This logic applies to all state updates that are conditional on > clean retirement of the emulation instruction, e.g. updating RFLAGS was > previously

Re: [PATCH] KVM: x86: Don't update RIP or do single-step on faulting emulation

2019-08-23 Thread Nadav Amit
> On Aug 23, 2019, at 1:55 PM, Sean Christopherson > wrote: > > Don't advance RIP or inject a single-step #DB if emulation signals a > fault. This logic applies to all state updates that are conditional on > clean retirement of the emulation instruction, e.g. updating RFLAGS was > previously

[PATCH] KVM: x86: Don't update RIP or do single-step on faulting emulation

2019-08-23 Thread Sean Christopherson
Don't advance RIP or inject a single-step #DB if emulation signals a fault. This logic applies to all state updates that are conditional on clean retirement of the emulation instruction, e.g. updating RFLAGS was previously handled by commit 38827dbd3fb85 ("KVM: x86: Do not update EFLAGS on