Re: [PATCH] KVM: x86: avoid misreporting level-triggered irqs as edge-triggered in tracing

2019-04-11 Thread Paolo Bonzini
On 27/03/19 15:12, Vitaly Kuznetsov wrote: > In __apic_accept_irq() interface trig_mode is int and actually on some code > paths it is set above u8: > > kvm_apic_set_irq() extracts it from 'struct kvm_lapic_irq' where trig_mode > is u16. This is done on purpose as e.g. kvm_set_msi_irq() sets it

[PATCH] KVM: x86: avoid misreporting level-triggered irqs as edge-triggered in tracing

2019-03-27 Thread Vitaly Kuznetsov
In __apic_accept_irq() interface trig_mode is int and actually on some code paths it is set above u8: kvm_apic_set_irq() extracts it from 'struct kvm_lapic_irq' where trig_mode is u16. This is done on purpose as e.g. kvm_set_msi_irq() sets it to (1 << 15) & e->msi.data kvm_apic_local_deliver