Re: [PATCH] Kbuild, lto: Avoid reported warning with strtoul

2014-04-21 Thread Viresh Kumar
On 21 April 2014 22:20, Andi Kleen wrote: > Hmm that's odd. I guess could assign it to a dummy variable That produces this: scripts/mod/modpost.c: In function ‘remove_dot’: scripts/mod/modpost.c:1708:16: warning: variable ‘ignore’ set but not used [-Wunused-but-set-variable] > or use viro's

Re: [PATCH] Kbuild, lto: Avoid reported warning with strtoul

2014-04-21 Thread Andi Kleen
On Mon, Apr 21, 2014 at 10:25:18AM +0530, Viresh Kumar wrote: > > --- a/scripts/mod/modpost.c > > +++ b/scripts/mod/modpost.c > > @@ -1707,7 +1707,7 @@ static char *remove_dot(char *s) > > int n = strcspn(s, "."); > > > > if (n > 0 && s[n] != 0) { > > - strtoul(s + n

Re: [PATCH] Kbuild, lto: Avoid reported warning with strtoul

2014-04-21 Thread Andi Kleen
On Mon, Apr 21, 2014 at 10:25:18AM +0530, Viresh Kumar wrote: --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -1707,7 +1707,7 @@ static char *remove_dot(char *s) int n = strcspn(s, .); if (n 0 s[n] != 0) { - strtoul(s + n + 1, end, 10); +

Re: [PATCH] Kbuild, lto: Avoid reported warning with strtoul

2014-04-21 Thread Viresh Kumar
On 21 April 2014 22:20, Andi Kleen a...@linux.intel.com wrote: Hmm that's odd. I guess could assign it to a dummy variable That produces this: scripts/mod/modpost.c: In function ‘remove_dot’: scripts/mod/modpost.c:1708:16: warning: variable ‘ignore’ set but not used [-Wunused-but-set-variable]

Re: [PATCH] Kbuild, lto: Avoid reported warning with strtoul

2014-04-20 Thread Viresh Kumar
On 18 April 2014 10:05, Andi Kleen wrote: > From: Andi Kleen > > Apparently someone's C library declares strtoul with warn_unused_result. > Cast to void to avoid the warning. Error handling is not useful here. I just did a x86_64 compilation without a CROSS_COMPILE= option (My .config also had

Re: [PATCH] Kbuild, lto: Avoid reported warning with strtoul

2014-04-20 Thread Viresh Kumar
On 18 April 2014 10:05, Andi Kleen a...@firstfloor.org wrote: From: Andi Kleen a...@linux.intel.com Apparently someone's C library declares strtoul with warn_unused_result. Cast to void to avoid the warning. Error handling is not useful here. I just did a x86_64 compilation without a

Re: [PATCH] Kbuild, lto: Avoid reported warning with strtoul

2014-04-18 Thread Andi Kleen
On Fri, Apr 18, 2014 at 05:49:04AM +0100, Al Viro wrote: > On Fri, Apr 18, 2014 at 06:35:56AM +0200, Andi Kleen wrote: > > From: Andi Kleen > > > > Apparently someone's C library declares strtoul with warn_unused_result. > > Cast to void to avoid the warning. Error handling is not useful here.

Re: [PATCH] Kbuild, lto: Avoid reported warning with strtoul

2014-04-18 Thread Andi Kleen
On Fri, Apr 18, 2014 at 05:49:04AM +0100, Al Viro wrote: On Fri, Apr 18, 2014 at 06:35:56AM +0200, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com Apparently someone's C library declares strtoul with warn_unused_result. Cast to void to avoid the warning. Error handling is not

Re: [PATCH] Kbuild, lto: Avoid reported warning with strtoul

2014-04-17 Thread Al Viro
On Fri, Apr 18, 2014 at 06:35:56AM +0200, Andi Kleen wrote: > From: Andi Kleen > > Apparently someone's C library declares strtoul with warn_unused_result. > Cast to void to avoid the warning. Error handling is not useful here. Umm... Since we don't give a fsck for the value, isn't that simply

[PATCH] Kbuild, lto: Avoid reported warning with strtoul

2014-04-17 Thread Andi Kleen
From: Andi Kleen Apparently someone's C library declares strtoul with warn_unused_result. Cast to void to avoid the warning. Error handling is not useful here. Cc: Viresh Kumar Signed-off-by: Andi Kleen --- scripts/mod/modpost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] Kbuild, lto: Avoid reported warning with strtoul

2014-04-17 Thread Andi Kleen
From: Andi Kleen a...@linux.intel.com Apparently someone's C library declares strtoul with warn_unused_result. Cast to void to avoid the warning. Error handling is not useful here. Cc: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Andi Kleen a...@linux.intel.com --- scripts/mod/modpost.c

Re: [PATCH] Kbuild, lto: Avoid reported warning with strtoul

2014-04-17 Thread Al Viro
On Fri, Apr 18, 2014 at 06:35:56AM +0200, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com Apparently someone's C library declares strtoul with warn_unused_result. Cast to void to avoid the warning. Error handling is not useful here. Umm... Since we don't give a fsck for the value,