Re: [PATCH] Kirin-PCIe: Add kirin pcie msi feature.

On Wed, May 09, 2018 at 12:51:53PM +0800, Shawn Guo wrote: > Hi Bjorn, > > On Tue, May 08, 2018 at 07:56:58AM -0500, Bjorn Helgaas wrote: > ... > > > + return ret; > > > + } > > > + } > > > + > > > + pci->pp.root_bus_nr = -1; > > > > Setting root_bus_nr looks like an

Re: [PATCH] Kirin-PCIe: Add kirin pcie msi feature.

On Wed, May 09, 2018 at 12:51:53PM +0800, Shawn Guo wrote: > Hi Bjorn, > > On Tue, May 08, 2018 at 07:56:58AM -0500, Bjorn Helgaas wrote: > ... > > > + return ret; > > > + } > > > + } > > > + > > > + pci->pp.root_bus_nr = -1; > > > > Setting root_bus_nr looks like an

Re: [PATCH] Kirin-PCIe: Add kirin pcie msi feature.

Hi, On 9.05.2018 07:51, Shawn Guo wrote: Hi Bjorn, On Tue, May 08, 2018 at 07:56:58AM -0500, Bjorn Helgaas wrote: ... + return ret; + } + } + + pci->pp.root_bus_nr = -1; Setting root_bus_nr looks like an unrelated change that should be in a

Re: [PATCH] Kirin-PCIe: Add kirin pcie msi feature.

Hi, On 9.05.2018 07:51, Shawn Guo wrote: Hi Bjorn, On Tue, May 08, 2018 at 07:56:58AM -0500, Bjorn Helgaas wrote: ... + return ret; + } + } + + pci->pp.root_bus_nr = -1; Setting root_bus_nr looks like an unrelated change that should be in a

Re: [PATCH] Kirin-PCIe: Add kirin pcie msi feature.

On 2018/5/8 20:56, Bjorn Helgaas wrote: > [+cc Stanimir, Jianguo, Shawn for qcom, histb comments below] > > On Tue, May 08, 2018 at 03:03:48PM +0800, Yao Chen wrote: >> This patch adds kirin pcie msi feature. > > Thanks for the patch! Please update your subject and changelog like this: > >

Re: [PATCH] Kirin-PCIe: Add kirin pcie msi feature.

On 2018/5/8 20:56, Bjorn Helgaas wrote: > [+cc Stanimir, Jianguo, Shawn for qcom, histb comments below] > > On Tue, May 08, 2018 at 03:03:48PM +0800, Yao Chen wrote: >> This patch adds kirin pcie msi feature. > > Thanks for the patch! Please update your subject and changelog like this: > >

Re: [PATCH] Kirin-PCIe: Add kirin pcie msi feature.

Hi Bjorn, On Tue, May 08, 2018 at 07:56:58AM -0500, Bjorn Helgaas wrote: ... > > + return ret; > > + } > > + } > > + > > + pci->pp.root_bus_nr = -1; > > Setting root_bus_nr looks like an unrelated change that should be in a > separate patch. > > But I'm not sure

Re: [PATCH] Kirin-PCIe: Add kirin pcie msi feature.

Hi Bjorn, On Tue, May 08, 2018 at 07:56:58AM -0500, Bjorn Helgaas wrote: ... > > + return ret; > > + } > > + } > > + > > + pci->pp.root_bus_nr = -1; > > Setting root_bus_nr looks like an unrelated change that should be in a > separate patch. > > But I'm not sure

Re: [PATCH] Kirin-PCIe: Add kirin pcie msi feature.

On 2018/5/9 5:31, Dmitry Shmidt wrote: > On Tue, May 8, 2018 at 12:03 AM, Yao Chen wrote: >> This patch adds kirin pcie msi feature. >> >> Signed-off-by: Yao Chen >> --- >> arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 ++ >>

Re: [PATCH] Kirin-PCIe: Add kirin pcie msi feature.

On 2018/5/9 5:31, Dmitry Shmidt wrote: > On Tue, May 8, 2018 at 12:03 AM, Yao Chen wrote: >> This patch adds kirin pcie msi feature. >> >> Signed-off-by: Yao Chen >> --- >> arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 ++ >> drivers/pci/dwc/pcie-kirin.c | 38 >>

Re: [PATCH] Kirin-PCIe: Add kirin pcie msi feature.

On Tue, May 8, 2018 at 12:03 AM, Yao Chen wrote: > This patch adds kirin pcie msi feature. > > Signed-off-by: Yao Chen > --- > arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 ++ > drivers/pci/dwc/pcie-kirin.c | 38 >

Re: [PATCH] Kirin-PCIe: Add kirin pcie msi feature.

On Tue, May 8, 2018 at 12:03 AM, Yao Chen wrote: > This patch adds kirin pcie msi feature. > > Signed-off-by: Yao Chen > --- > arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 ++ > drivers/pci/dwc/pcie-kirin.c | 38 > +++ > 2 files changed, 40

Re: [PATCH] Kirin-PCIe: Add kirin pcie msi feature.

[+cc Stanimir, Jianguo, Shawn for qcom, histb comments below] On Tue, May 08, 2018 at 03:03:48PM +0800, Yao Chen wrote: > This patch adds kirin pcie msi feature. Thanks for the patch! Please update your subject and changelog like this: PCI: kirin: Add MSI support Add support for MSI. You

Re: [PATCH] Kirin-PCIe: Add kirin pcie msi feature.

[+cc Stanimir, Jianguo, Shawn for qcom, histb comments below] On Tue, May 08, 2018 at 03:03:48PM +0800, Yao Chen wrote: > This patch adds kirin pcie msi feature. Thanks for the patch! Please update your subject and changelog like this: PCI: kirin: Add MSI support Add support for MSI. You

[PATCH] Kirin-PCIe: Add kirin pcie msi feature.

This patch adds kirin pcie msi feature. Signed-off-by: Yao Chen --- arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 ++ drivers/pci/dwc/pcie-kirin.c | 38 +++ 2 files changed, 40 insertions(+) diff --git

[PATCH] Kirin-PCIe: Add kirin pcie msi feature.

This patch adds kirin pcie msi feature. Signed-off-by: Yao Chen --- arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 ++ drivers/pci/dwc/pcie-kirin.c | 38 +++ 2 files changed, 40 insertions(+) diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi