Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-08 Thread Vojtech Pavlik
On Mon, Feb 07, 2005 at 09:22:19AM -0500, Dmitry Torokhov wrote: > On Mon, 7 Feb 2005 13:20:33 +0100, Vojtech Pavlik <[EMAIL PROTECTED]> wrote: > > On Sun, Feb 06, 2005 at 08:21:13PM -0500, Dmitry Torokhov wrote: > > > > > Opening braces should go on the same line as the statement (if (...) > >

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-08 Thread David Fries
On Mon, Feb 07, 2005 at 01:20:33PM +0100, Vojtech Pavlik wrote: > On Sun, Feb 06, 2005 at 08:21:13PM -0500, Dmitry Torokhov wrote: > > This should do it: > > [EMAIL PROTECTED], 2005-02-07 13:19:59+01:00, [EMAIL PROTECTED] > input: Do a kill_fasync() in input handlers on device disconnect >

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-08 Thread David Fries
On Mon, Feb 07, 2005 at 01:20:33PM +0100, Vojtech Pavlik wrote: On Sun, Feb 06, 2005 at 08:21:13PM -0500, Dmitry Torokhov wrote: This should do it: [EMAIL PROTECTED], 2005-02-07 13:19:59+01:00, [EMAIL PROTECTED] input: Do a kill_fasync() in input handlers on device disconnect

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-08 Thread Vojtech Pavlik
On Mon, Feb 07, 2005 at 09:22:19AM -0500, Dmitry Torokhov wrote: On Mon, 7 Feb 2005 13:20:33 +0100, Vojtech Pavlik [EMAIL PROTECTED] wrote: On Sun, Feb 06, 2005 at 08:21:13PM -0500, Dmitry Torokhov wrote: Opening braces should go on the same line as the statement (if (...) {).

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-07 Thread Dmitry Torokhov
On Mon, 7 Feb 2005 13:20:33 +0100, Vojtech Pavlik <[EMAIL PROTECTED]> wrote: > On Sun, Feb 06, 2005 at 08:21:13PM -0500, Dmitry Torokhov wrote: > > > > Opening braces should go on the same line as the statement (if (...) {). > > > > > > How about this patch? > > > > Looks fine now. Hmm, wait a

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-07 Thread Vojtech Pavlik
On Sun, Feb 06, 2005 at 08:21:13PM -0500, Dmitry Torokhov wrote: > > > Opening braces should go on the same line as the statement (if (...) {). > >   > > How about this patch? > > Looks fine now. Hmm, wait a sec... Don't we also need kill_fasync calls in > disconnect routines as well? This

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-07 Thread Vojtech Pavlik
On Sun, Feb 06, 2005 at 08:21:13PM -0500, Dmitry Torokhov wrote: Opening braces should go on the same line as the statement (if (...) {).   How about this patch? Looks fine now. Hmm, wait a sec... Don't we also need kill_fasync calls in disconnect routines as well? This should do it:

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-07 Thread Dmitry Torokhov
On Mon, 7 Feb 2005 13:20:33 +0100, Vojtech Pavlik [EMAIL PROTECTED] wrote: On Sun, Feb 06, 2005 at 08:21:13PM -0500, Dmitry Torokhov wrote: Opening braces should go on the same line as the statement (if (...) {). How about this patch? Looks fine now. Hmm, wait a sec... Don't we

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-06 Thread Vojtech Pavlik
On Sun, Feb 06, 2005 at 08:21:13PM -0500, Dmitry Torokhov wrote: > On Sunday 06 February 2005 08:12, Vojtech Pavlik wrote: > > On Tue, Feb 01, 2005 at 10:24:39AM -0500, Dmitry Torokhov wrote: > > > On Tue, 1 Feb 2005 08:52:15 -0600, David Fries <[EMAIL PROTECTED]> wrote: > > > > Currently a

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-06 Thread Dmitry Torokhov
On Sunday 06 February 2005 08:12, Vojtech Pavlik wrote: > On Tue, Feb 01, 2005 at 10:24:39AM -0500, Dmitry Torokhov wrote: > > On Tue, 1 Feb 2005 08:52:15 -0600, David Fries <[EMAIL PROTECTED]> wrote: > > > Currently a blocking read, select, or poll call will not return if a > > > joystick device

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-06 Thread Vojtech Pavlik
On Tue, Feb 01, 2005 at 10:24:39AM -0500, Dmitry Torokhov wrote: > On Tue, 1 Feb 2005 08:52:15 -0600, David Fries <[EMAIL PROTECTED]> wrote: > > Currently a blocking read, select, or poll call will not return if a > > joystick device is unplugged. This patch allows them to return. > > > ... > >

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-06 Thread Vojtech Pavlik
On Tue, Feb 01, 2005 at 10:24:39AM -0500, Dmitry Torokhov wrote: On Tue, 1 Feb 2005 08:52:15 -0600, David Fries [EMAIL PROTECTED] wrote: Currently a blocking read, select, or poll call will not return if a joystick device is unplugged. This patch allows them to return. ... static

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-06 Thread Dmitry Torokhov
On Sunday 06 February 2005 08:12, Vojtech Pavlik wrote: On Tue, Feb 01, 2005 at 10:24:39AM -0500, Dmitry Torokhov wrote: On Tue, 1 Feb 2005 08:52:15 -0600, David Fries [EMAIL PROTECTED] wrote: Currently a blocking read, select, or poll call will not return if a joystick device is

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-06 Thread Vojtech Pavlik
On Sun, Feb 06, 2005 at 08:21:13PM -0500, Dmitry Torokhov wrote: On Sunday 06 February 2005 08:12, Vojtech Pavlik wrote: On Tue, Feb 01, 2005 at 10:24:39AM -0500, Dmitry Torokhov wrote: On Tue, 1 Feb 2005 08:52:15 -0600, David Fries [EMAIL PROTECTED] wrote: Currently a blocking read,

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-01 Thread Dmitry Torokhov
On Tue, 1 Feb 2005 08:52:15 -0600, David Fries <[EMAIL PROTECTED]> wrote: > Currently a blocking read, select, or poll call will not return if a > joystick device is unplugged. This patch allows them to return. > ... > static unsigned int joydev_poll(struct file *file, poll_table *wait) > { > +

[PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-01 Thread David Fries
Currently a blocking read, select, or poll call will not return if a joystick device is unplugged. This patch allows them to return. This patch adds a wake_up_interruptible call to the joydev_disconnect to interrupt both a blocking read and a blocking poll call. The read routine was already

[PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-01 Thread David Fries
Currently a blocking read, select, or poll call will not return if a joystick device is unplugged. This patch allows them to return. This patch adds a wake_up_interruptible call to the joydev_disconnect to interrupt both a blocking read and a blocking poll call. The read routine was already

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-01 Thread Dmitry Torokhov
On Tue, 1 Feb 2005 08:52:15 -0600, David Fries [EMAIL PROTECTED] wrote: Currently a blocking read, select, or poll call will not return if a joystick device is unplugged. This patch allows them to return. ... static unsigned int joydev_poll(struct file *file, poll_table *wait) { +