Re: [PATCH] LinuxPPS - definitive version

2007-07-26 Thread Roman Zippel
Hi, On Tuesday 24 July 2007, Rodolfo Giometti wrote: > By doing: > > struct pps_ktime { > __u64 sec; > - __u32 nsec; > + __u64 nsec; > }; Just using __u32 for both works as well... bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH] LinuxPPS - definitive version

2007-07-26 Thread Roman Zippel
Hi, On Tuesday 24 July 2007, Rodolfo Giometti wrote: By doing: struct pps_ktime { __u64 sec; - __u32 nsec; + __u64 nsec; }; Just using __u32 for both works as well... bye, Roman - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of

Re: [PATCH] LinuxPPS - definitive version

2007-07-24 Thread Rodolfo Giometti
On Tue, Jul 24, 2007 at 03:45:19PM +0100, David Woodhouse wrote: > On Tue, 2007-07-24 at 16:31 +0200, Rodolfo Giometti wrote: > > drivers/built-in.o: In function `sys_time_pps_fetch': > > (.text+0x5f05e): undefined reference to `__udivdi3' > > Hm, not sure. Maybe put it back to uint32_t and then

Re: [PATCH] LinuxPPS - definitive version

2007-07-24 Thread David Woodhouse
On Tue, 2007-07-24 at 16:20 +0200, Rodolfo Giometti wrote: > On Tue, Jul 24, 2007 at 02:49:02PM +0100, David Woodhouse wrote: > > > Also 's/unknow /unknown /' (2 instances) > > ?? I didn't find them: > >$ grep 'unknow ' Documentation/pps/pps.txt Elsewhere in the patch. > > In order for

Re: [PATCH] LinuxPPS - definitive version

2007-07-24 Thread David Woodhouse
On Tue, 2007-07-24 at 16:20 +0200, Rodolfo Giometti wrote: > The problem is that we can have several PPS sources into a system and > all these sources will arise their IRQ line (quasi)simultaneously and > I don't wish a CPU may delay one of these IRQ handler due a spinlock > into the pps_event().

Re: [PATCH] LinuxPPS - definitive version

2007-07-24 Thread David Woodhouse
On Tue, 2007-07-24 at 16:31 +0200, Rodolfo Giometti wrote: > drivers/built-in.o: In function `sys_time_pps_fetch': > (.text+0x5f05e): undefined reference to `__udivdi3' Hm, not sure. Maybe put it back to uint32_t and then add another uint32_t of explicit padding, or maybe just cast it to

Re: [PATCH] LinuxPPS - definitive version

2007-07-24 Thread Rodolfo Giometti
On Tue, Jul 24, 2007 at 02:49:02PM +0100, David Woodhouse wrote: > > I think you still haven't quite got the 32-bit vs. 64-bit compatibility > right. Remember that on i386, the alignment of a uint64_t is only 4 > bytes, while on most other architectures it's 8 bytes. On i386, there > will be no

Re: [PATCH] LinuxPPS - definitive version

2007-07-24 Thread Rodolfo Giometti
On Tue, Jul 24, 2007 at 02:49:02PM +0100, David Woodhouse wrote: > Also 's/unknow /unknown /' (2 instances) ?? I didn't find them: $ grep 'unknow ' Documentation/pps/pps.txt > Am I right in thinking that the only place it matters is within > pps_event()? In that case, at the very least you

Re: [PATCH] LinuxPPS - definitive version

2007-07-24 Thread David Woodhouse
On Tue, 2007-07-24 at 10:00 +0200, Rodolfo Giometti wrote: > On Mon, Jul 23, 2007 at 02:35:16PM +0100, David Woodhouse wrote: > > > > s/Documentaion/Documentation/ in the last line of Documentation/pps/pps.txt > > Fixed. Also 's/unknow /unknown /' (2 instances) > > Please feed it to

Re: [PATCH] LinuxPPS - definitive version

2007-07-24 Thread David Woodhouse
On Tue, 2007-07-24 at 10:00 +0200, Rodolfo Giometti wrote: On Mon, Jul 23, 2007 at 02:35:16PM +0100, David Woodhouse wrote: s/Documentaion/Documentation/ in the last line of Documentation/pps/pps.txt Fixed. Also 's/unknow /unknown /' (2 instances) Please feed it to

Re: [PATCH] LinuxPPS - definitive version

2007-07-24 Thread Rodolfo Giometti
On Tue, Jul 24, 2007 at 02:49:02PM +0100, David Woodhouse wrote: Also 's/unknow /unknown /' (2 instances) ?? I didn't find them: $ grep 'unknow ' Documentation/pps/pps.txt Am I right in thinking that the only place it matters is within pps_event()? In that case, at the very least you

Re: [PATCH] LinuxPPS - definitive version

2007-07-24 Thread Rodolfo Giometti
On Tue, Jul 24, 2007 at 02:49:02PM +0100, David Woodhouse wrote: I think you still haven't quite got the 32-bit vs. 64-bit compatibility right. Remember that on i386, the alignment of a uint64_t is only 4 bytes, while on most other architectures it's 8 bytes. On i386, there will be no

Re: [PATCH] LinuxPPS - definitive version

2007-07-24 Thread David Woodhouse
On Tue, 2007-07-24 at 16:31 +0200, Rodolfo Giometti wrote: drivers/built-in.o: In function `sys_time_pps_fetch': (.text+0x5f05e): undefined reference to `__udivdi3' Hm, not sure. Maybe put it back to uint32_t and then add another uint32_t of explicit padding, or maybe just cast it to uint32_t

Re: [PATCH] LinuxPPS - definitive version

2007-07-24 Thread David Woodhouse
On Tue, 2007-07-24 at 16:20 +0200, Rodolfo Giometti wrote: The problem is that we can have several PPS sources into a system and all these sources will arise their IRQ line (quasi)simultaneously and I don't wish a CPU may delay one of these IRQ handler due a spinlock into the pps_event().

Re: [PATCH] LinuxPPS - definitive version

2007-07-24 Thread David Woodhouse
On Tue, 2007-07-24 at 16:20 +0200, Rodolfo Giometti wrote: On Tue, Jul 24, 2007 at 02:49:02PM +0100, David Woodhouse wrote: Also 's/unknow /unknown /' (2 instances) ?? I didn't find them: $ grep 'unknow ' Documentation/pps/pps.txt Elsewhere in the patch. In order for your

Re: [PATCH] LinuxPPS - definitive version

2007-07-24 Thread Rodolfo Giometti
On Tue, Jul 24, 2007 at 03:45:19PM +0100, David Woodhouse wrote: On Tue, 2007-07-24 at 16:31 +0200, Rodolfo Giometti wrote: drivers/built-in.o: In function `sys_time_pps_fetch': (.text+0x5f05e): undefined reference to `__udivdi3' Hm, not sure. Maybe put it back to uint32_t and then add

Re: [PATCH] LinuxPPS - definitive version

2007-07-23 Thread David Woodhouse
On Mon, 2007-07-23 at 12:28 -0700, Andrew Morton wrote: > On Mon, 23 Jul 2007 14:35:16 +0100 > David Woodhouse <[EMAIL PROTECTED]> wrote: > > > Please feed it to scripts/checkpatch.pl -- you can ignore all the > > warnings about lines greater than 80 characters, and the complete crap > > about

Re: [PATCH] LinuxPPS - definitive version

2007-07-23 Thread Andrew Morton
On Mon, 23 Jul 2007 14:35:16 +0100 David Woodhouse <[EMAIL PROTECTED]> wrote: > Please feed it to scripts/checkpatch.pl -- you can ignore all the > warnings about lines greater than 80 characters, and the complete crap > about "declaring multiple variables together should be avoided", but > some

Re: [PATCH] LinuxPPS - definitive version

2007-07-23 Thread Rodolfo Giometti
On Mon, Jul 23, 2007 at 02:35:16PM +0100, David Woodhouse wrote: > > s/Documentaion/Documentation/ in the last line of Documentation/pps/pps.txt Fixed. > Please feed it to scripts/checkpatch.pl -- you can ignore all the > warnings about lines greater than 80 characters, and the complete crap >

Re: [PATCH] LinuxPPS - definitive version

2007-07-23 Thread David Woodhouse
On Tue, 2007-07-17 at 20:05 +0200, Rodolfo Giometti wrote: > Hello, > > here my last patch for PPS support. > > In my opinion it should be ok for inclusion... please, let me know if > something should be still changed. s/Documentaion/Documentation/ in the last line of Documentation/pps/pps.txt

Re: [PATCH] LinuxPPS - definitive version

2007-07-23 Thread David Woodhouse
On Tue, 2007-07-17 at 20:05 +0200, Rodolfo Giometti wrote: Hello, here my last patch for PPS support. In my opinion it should be ok for inclusion... please, let me know if something should be still changed. s/Documentaion/Documentation/ in the last line of Documentation/pps/pps.txt

Re: [PATCH] LinuxPPS - definitive version

2007-07-23 Thread Rodolfo Giometti
On Mon, Jul 23, 2007 at 02:35:16PM +0100, David Woodhouse wrote: s/Documentaion/Documentation/ in the last line of Documentation/pps/pps.txt Fixed. Please feed it to scripts/checkpatch.pl -- you can ignore all the warnings about lines greater than 80 characters, and the complete crap about

Re: [PATCH] LinuxPPS - definitive version

2007-07-23 Thread Andrew Morton
On Mon, 23 Jul 2007 14:35:16 +0100 David Woodhouse [EMAIL PROTECTED] wrote: Please feed it to scripts/checkpatch.pl -- you can ignore all the warnings about lines greater than 80 characters, and the complete crap about declaring multiple variables together should be avoided, but some of what

Re: [PATCH] LinuxPPS - definitive version

2007-07-23 Thread David Woodhouse
On Mon, 2007-07-23 at 12:28 -0700, Andrew Morton wrote: On Mon, 23 Jul 2007 14:35:16 +0100 David Woodhouse [EMAIL PROTECTED] wrote: Please feed it to scripts/checkpatch.pl -- you can ignore all the warnings about lines greater than 80 characters, and the complete crap about declaring