Re: [PATCH] Make __xfs_xattr_put_listen preperly report errors.

On Fri, Aug 26, 2016 at 10:59:28AM +0200, Artem Savkov wrote: > On Fri, Aug 26, 2016 at 08:42:15AM +1000, Dave Chinner wrote: > > So when I look at the fix, and see that it doesn't reproduce on my > > systems, it's clear that it's either not yet fully understood or > > hasn't been fully explained

Re: [PATCH] Make __xfs_xattr_put_listen preperly report errors.

On Fri, Aug 26, 2016 at 10:59:28AM +0200, Artem Savkov wrote: > On Fri, Aug 26, 2016 at 08:42:15AM +1000, Dave Chinner wrote: > > So when I look at the fix, and see that it doesn't reproduce on my > > systems, it's clear that it's either not yet fully understood or > > hasn't been fully explained

Re: [PATCH] Make __xfs_xattr_put_listen preperly report errors.

On Fri, Aug 26, 2016 at 08:42:15AM +1000, Dave Chinner wrote: > On Thu, Aug 25, 2016 at 10:21:09AM +0200, Artem Savkov wrote: > > On Thu, Aug 25, 2016 at 10:24:08AM +1000, Dave Chinner wrote: > > > On Wed, Aug 24, 2016 at 10:08:33AM +0200, Artem Savkov wrote: > > > > On Wed, Aug 24, 2016 at

Re: [PATCH] Make __xfs_xattr_put_listen preperly report errors.

On Fri, Aug 26, 2016 at 08:42:15AM +1000, Dave Chinner wrote: > On Thu, Aug 25, 2016 at 10:21:09AM +0200, Artem Savkov wrote: > > On Thu, Aug 25, 2016 at 10:24:08AM +1000, Dave Chinner wrote: > > > On Wed, Aug 24, 2016 at 10:08:33AM +0200, Artem Savkov wrote: > > > > On Wed, Aug 24, 2016 at

Re: [PATCH] Make __xfs_xattr_put_listen preperly report errors.

On Thu, Aug 25, 2016 at 10:21:09AM +0200, Artem Savkov wrote: > On Thu, Aug 25, 2016 at 10:24:08AM +1000, Dave Chinner wrote: > > On Wed, Aug 24, 2016 at 10:08:33AM +0200, Artem Savkov wrote: > > > On Wed, Aug 24, 2016 at 11:55:51AM +1000, Dave Chinner wrote: > > > > On Tue, Aug 23, 2016 at

Re: [PATCH] Make __xfs_xattr_put_listen preperly report errors.

On Thu, Aug 25, 2016 at 10:21:09AM +0200, Artem Savkov wrote: > On Thu, Aug 25, 2016 at 10:24:08AM +1000, Dave Chinner wrote: > > On Wed, Aug 24, 2016 at 10:08:33AM +0200, Artem Savkov wrote: > > > On Wed, Aug 24, 2016 at 11:55:51AM +1000, Dave Chinner wrote: > > > > On Tue, Aug 23, 2016 at

Re: [PATCH] Make __xfs_xattr_put_listen preperly report errors.

On Thu, Aug 25, 2016 at 10:24:08AM +1000, Dave Chinner wrote: > On Wed, Aug 24, 2016 at 10:08:33AM +0200, Artem Savkov wrote: > > On Wed, Aug 24, 2016 at 11:55:51AM +1000, Dave Chinner wrote: > > > On Tue, Aug 23, 2016 at 05:54:13PM +0200, Artem Savkov wrote: > > > > Commit "xfs: only return

Re: [PATCH] Make __xfs_xattr_put_listen preperly report errors.

On Thu, Aug 25, 2016 at 10:24:08AM +1000, Dave Chinner wrote: > On Wed, Aug 24, 2016 at 10:08:33AM +0200, Artem Savkov wrote: > > On Wed, Aug 24, 2016 at 11:55:51AM +1000, Dave Chinner wrote: > > > On Tue, Aug 23, 2016 at 05:54:13PM +0200, Artem Savkov wrote: > > > > Commit "xfs: only return

Re: [PATCH] Make __xfs_xattr_put_listen preperly report errors.

On Wed, Aug 24, 2016 at 10:08:33AM +0200, Artem Savkov wrote: > On Wed, Aug 24, 2016 at 11:55:51AM +1000, Dave Chinner wrote: > > On Tue, Aug 23, 2016 at 05:54:13PM +0200, Artem Savkov wrote: > > > Commit "xfs: only return -errno or success from attr ->put_listent" > > > changes the > > > >

Re: [PATCH] Make __xfs_xattr_put_listen preperly report errors.

On Wed, Aug 24, 2016 at 10:08:33AM +0200, Artem Savkov wrote: > On Wed, Aug 24, 2016 at 11:55:51AM +1000, Dave Chinner wrote: > > On Tue, Aug 23, 2016 at 05:54:13PM +0200, Artem Savkov wrote: > > > Commit "xfs: only return -errno or success from attr ->put_listent" > > > changes the > > > >

Re: [PATCH] Make __xfs_xattr_put_listen preperly report errors.

On Wed, Aug 24, 2016 at 11:55:51AM +1000, Dave Chinner wrote: > On Tue, Aug 23, 2016 at 05:54:13PM +0200, Artem Savkov wrote: > > Commit "xfs: only return -errno or success from attr ->put_listent" changes > > the > > Please quote commits in --oneline format in changelogs - it makes it > much

Re: [PATCH] Make __xfs_xattr_put_listen preperly report errors.

On Wed, Aug 24, 2016 at 11:55:51AM +1000, Dave Chinner wrote: > On Tue, Aug 23, 2016 at 05:54:13PM +0200, Artem Savkov wrote: > > Commit "xfs: only return -errno or success from attr ->put_listent" changes > > the > > Please quote commits in --oneline format in changelogs - it makes it > much

Re: [PATCH] Make __xfs_xattr_put_listen preperly report errors.

On Tue, Aug 23, 2016 at 05:54:13PM +0200, Artem Savkov wrote: > Commit "xfs: only return -errno or success from attr ->put_listent" changes > the Please quote commits in --oneline format in changelogs - it makes it much easier to find the change you are refering to if there is both a commit ID

Re: [PATCH] Make __xfs_xattr_put_listen preperly report errors.

On Tue, Aug 23, 2016 at 05:54:13PM +0200, Artem Savkov wrote: > Commit "xfs: only return -errno or success from attr ->put_listent" changes > the Please quote commits in --oneline format in changelogs - it makes it much easier to find the change you are refering to if there is both a commit ID

[PATCH] Make __xfs_xattr_put_listen preperly report errors.

Commit "xfs: only return -errno or success from attr ->put_listent" changes the returnvalue of __xfs_xattr_put_listen to 0 in case when there is insufficient space in the buffer assuming that setting context->count to -1 would be enough, but all of the ->put_listent callers only check seen_enough.

[PATCH] Make __xfs_xattr_put_listen preperly report errors.

Commit "xfs: only return -errno or success from attr ->put_listent" changes the returnvalue of __xfs_xattr_put_listen to 0 in case when there is insufficient space in the buffer assuming that setting context->count to -1 would be enough, but all of the ->put_listent callers only check seen_enough.