Re: [PATCH] Makefile: Convert -Wimplicit-fallthrough to -Wimplicit-fallthrough=2

2019-08-30 Thread Gustavo A. R. Silva
On 8/29/19 7:02 AM, Michal Suchanek wrote: > From gcc documentation: > > -Wimplicit-fallthrough=0 > disables the warning altogether. > -Wimplicit-fallthrough=1 > matches .* regular expression, any comment is used as fallthrough comment. > -Wimplicit-fallthrough=2 > case insensitively

Re: [PATCH] Makefile: Convert -Wimplicit-fallthrough to -Wimplicit-fallthrough=2

2019-08-30 Thread Miguel Ojeda
On Fri, Aug 30, 2019 at 1:09 PM Joe Perches wrote: > > On Thu, 2019-08-29 at 14:02 +0200, Michal Suchanek wrote: > > In particular the default value of 3 does not match the comments like > > /* falls through to do foobar */ > > How many comments are there like this in the kernel? +1 Given we are

Re: [PATCH] Makefile: Convert -Wimplicit-fallthrough to -Wimplicit-fallthrough=2

2019-08-30 Thread Joe Perches
On Thu, 2019-08-29 at 14:02 +0200, Michal Suchanek wrote: > In particular the default value of 3 does not match the comments like > /* falls through to do foobar */ How many comments are there like this in the kernel? Also you have to deal with gcc/clang differences. As far as I know, clang

[PATCH] Makefile: Convert -Wimplicit-fallthrough to -Wimplicit-fallthrough=2

2019-08-29 Thread Michal Suchanek
>From gcc documentation: -Wimplicit-fallthrough=0 disables the warning altogether. -Wimplicit-fallthrough=1 matches .* regular expression, any comment is used as fallthrough comment. -Wimplicit-fallthrough=2 case insensitively matches .*falls?[ \t-]*thr(ough|u).* regular expression.