Re: [PATCH] NFS: Fix nfs4_lock_state refcounting in nfs4_alloc_{lock,unlock}data()

On Mon, Mar 18 2019, Trond Myklebust wrote: > On Mon, 2019-03-18 at 17:00 +, Catalin Marinas wrote: >> Commit 7b587e1a5a6c ("NFS: use locks_copy_lock() to copy locks.") >> changed the lock copying from memcpy() to the dedicated >> locks_copy_lock() function. The latter correctly increments the

Re: [PATCH] NFS: Fix nfs4_lock_state refcounting in nfs4_alloc_{lock,unlock}data()

On Mon, 2019-03-18 at 17:00 +, Catalin Marinas wrote: > Commit 7b587e1a5a6c ("NFS: use locks_copy_lock() to copy locks.") > changed the lock copying from memcpy() to the dedicated > locks_copy_lock() function. The latter correctly increments the > nfs4_lock_state.ls_count via nfs4_fl_copy_lock(

[PATCH] NFS: Fix nfs4_lock_state refcounting in nfs4_alloc_{lock,unlock}data()

Commit 7b587e1a5a6c ("NFS: use locks_copy_lock() to copy locks.") changed the lock copying from memcpy() to the dedicated locks_copy_lock() function. The latter correctly increments the nfs4_lock_state.ls_count via nfs4_fl_copy_lock(), however, this refcount has already been incremented in the nfs4