Re: [PATCH] NMI: fix NMI period is not correct when cpu frequency changes issue.

2013-07-24 Thread Frederic Weisbecker
On Thu, Apr 18, 2013 at 01:32:09PM +0200, Peter Zijlstra wrote: > On Mon, 2013-04-15 at 16:30 -0700, Andrew Morton wrote: > > I think this will break the build if CONFIG_PERF_EVENTS=n and > > CONFIG_LOCKUP_DETECTOR=y. I was able to create such a config for > > powerpc. If I'm reading it

Re: [PATCH] NMI: fix NMI period is not correct when cpu frequency changes issue.

2013-07-24 Thread Frederic Weisbecker
On Thu, Apr 18, 2013 at 01:32:09PM +0200, Peter Zijlstra wrote: On Mon, 2013-04-15 at 16:30 -0700, Andrew Morton wrote: I think this will break the build if CONFIG_PERF_EVENTS=n and CONFIG_LOCKUP_DETECTOR=y. I was able to create such a config for powerpc. If I'm reading it correctly,

Re: [PATCH] NMI: fix NMI period is not correct when cpu frequency changes issue.

2013-04-18 Thread Peter Zijlstra
On Mon, 2013-04-15 at 16:30 -0700, Andrew Morton wrote: > I think this will break the build if CONFIG_PERF_EVENTS=n and > CONFIG_LOCKUP_DETECTOR=y. I was able to create such a config for > powerpc. If I'm reading it correctly, CONFIG_PERF_EVENTS cannot be > disabled on x86_64? If so, what the

Re: [PATCH] NMI: fix NMI period is not correct when cpu frequency changes issue.

2013-04-18 Thread Peter Zijlstra
On Mon, 2013-04-15 at 16:30 -0700, Andrew Morton wrote: I think this will break the build if CONFIG_PERF_EVENTS=n and CONFIG_LOCKUP_DETECTOR=y. I was able to create such a config for powerpc. If I'm reading it correctly, CONFIG_PERF_EVENTS cannot be disabled on x86_64? If so, what the heck?

Re: [PATCH] NMI: fix NMI period is not correct when cpu frequency changes issue.

2013-04-15 Thread Andrew Morton
On Tue, 16 Apr 2013 03:45:15 + "Pan, Zhenjie" wrote: > > Overall the patch looks desirable, but it increases the kernel size by > > several > > hundred bytes when CONFIG_CPU_FREQ=n. It should produce no code in > > this case! Take a look at the magic in register_hotcpu_notifier(), the way

RE: [PATCH] NMI: fix NMI period is not correct when cpu frequency changes issue.

2013-04-15 Thread Pan, Zhenjie
i...@redhat.com; > a...@ghostprotocols.net; dzic...@redhat.com; t...@linutronix.de; Liu, > Chuansheng; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] NMI: fix NMI period is not correct when cpu frequency > changes issue. > > On Mon, 1 Apr 2013 03:47:42 + "Pan, Zhenjie" >

RE: [PATCH] NMI: fix NMI period is not correct when cpu frequency changes issue.

2013-04-15 Thread Pan, Zhenjie
Zhenjie > Cc: a.p.zijls...@chello.nl; pau...@samba.org; mi...@redhat.com; > a...@ghostprotocols.net; a...@linux-foundation.org; t...@linutronix.de; > Liu, Chuansheng; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] NMI: fix NMI period is not correct when cpu frequency > changes issue

Re: [PATCH] NMI: fix NMI period is not correct when cpu frequency changes issue.

2013-04-15 Thread Andrew Morton
On Mon, 1 Apr 2013 03:47:42 + "Pan, Zhenjie" wrote: > Watchdog use performance monitor of cpu clock cycle to generate NMI to detect > hard lockup. > But when cpu's frequency changes, the event period will also change. > It's not as expected as the configuration. > For example, set the NMI

Re: [PATCH] NMI: fix NMI period is not correct when cpu frequency changes issue.

2013-04-15 Thread Andrew Morton
On Mon, 1 Apr 2013 03:47:42 + Pan, Zhenjie zhenjie@intel.com wrote: Watchdog use performance monitor of cpu clock cycle to generate NMI to detect hard lockup. But when cpu's frequency changes, the event period will also change. It's not as expected as the configuration. For example,

RE: [PATCH] NMI: fix NMI period is not correct when cpu frequency changes issue.

2013-04-15 Thread Pan, Zhenjie
: a.p.zijls...@chello.nl; pau...@samba.org; mi...@redhat.com; a...@ghostprotocols.net; a...@linux-foundation.org; t...@linutronix.de; Liu, Chuansheng; linux-kernel@vger.kernel.org Subject: Re: [PATCH] NMI: fix NMI period is not correct when cpu frequency changes issue. On Mon, Apr 01, 2013 at 03:47

RE: [PATCH] NMI: fix NMI period is not correct when cpu frequency changes issue.

2013-04-15 Thread Pan, Zhenjie
; a...@ghostprotocols.net; dzic...@redhat.com; t...@linutronix.de; Liu, Chuansheng; linux-kernel@vger.kernel.org Subject: Re: [PATCH] NMI: fix NMI period is not correct when cpu frequency changes issue. On Mon, 1 Apr 2013 03:47:42 + Pan, Zhenjie zhenjie@intel.com wrote: Watchdog use performance

Re: [PATCH] NMI: fix NMI period is not correct when cpu frequency changes issue.

2013-04-15 Thread Andrew Morton
On Tue, 16 Apr 2013 03:45:15 + Pan, Zhenjie zhenjie@intel.com wrote: Overall the patch looks desirable, but it increases the kernel size by several hundred bytes when CONFIG_CPU_FREQ=n. It should produce no code in this case! Take a look at the magic in

Re: [PATCH] NMI: fix NMI period is not correct when cpu frequency changes issue.

2013-04-03 Thread Don Zickus
On Mon, Apr 01, 2013 at 03:47:42AM +, Pan, Zhenjie wrote: > Watchdog use performance monitor of cpu clock cycle to generate NMI to detect > hard lockup. > But when cpu's frequency changes, the event period will also change. > It's not as expected as the configuration. > For example, set the

Re: [PATCH] NMI: fix NMI period is not correct when cpu frequency changes issue.

2013-04-03 Thread Don Zickus
On Mon, Apr 01, 2013 at 03:47:42AM +, Pan, Zhenjie wrote: Watchdog use performance monitor of cpu clock cycle to generate NMI to detect hard lockup. But when cpu's frequency changes, the event period will also change. It's not as expected as the configuration. For example, set the NMI

[PATCH] NMI: fix NMI period is not correct when cpu frequency changes issue.

2013-03-31 Thread Pan, Zhenjie
Watchdog use performance monitor of cpu clock cycle to generate NMI to detect hard lockup. But when cpu's frequency changes, the event period will also change. It's not as expected as the configuration. For example, set the NMI event handler period is 10 seconds when the cpu is 2.0GHz. If the

[PATCH] NMI: fix NMI period is not correct when cpu frequency changes issue.

2013-03-31 Thread Pan, Zhenjie
Watchdog use performance monitor of cpu clock cycle to generate NMI to detect hard lockup. But when cpu's frequency changes, the event period will also change. It's not as expected as the configuration. For example, set the NMI event handler period is 10 seconds when the cpu is 2.0GHz. If the