Re: [PATCH] Only print SCSI data direction warning once for a command

2008-01-14 Thread Douglas Gilbert
Andi Kleen wrote: to the log because they come from printk_ratelimit(). So all you've done is halved the volume of flow to the logs and left a dangling printk suppressed message that keeps spewing, so I don't think the patch even does what you describe it as doing ... if you reverse the order

Re: [PATCH] Only print SCSI data direction warning once for a command

2008-01-14 Thread Douglas Gilbert
Andi Kleen wrote: to the log because they come from printk_ratelimit(). So all you've done is halved the volume of flow to the logs and left a dangling printk suppressed message that keeps spewing, so I don't think the patch even does what you describe it as doing ... if you reverse the order

Re: [PATCH] Only print SCSI data direction warning once for a command

2008-01-13 Thread Andi Kleen
> to the log because they come from printk_ratelimit(). So all you've > done is halved the volume of flow to the logs and left a dangling printk > suppressed message that keeps spewing, so I don't think the patch even > does what you describe it as doing ... if you reverse the order of the >

Re: [PATCH] Only print SCSI data direction warning once for a command

2008-01-13 Thread Andi Kleen
to the log because they come from printk_ratelimit(). So all you've done is halved the volume of flow to the logs and left a dangling printk suppressed message that keeps spewing, so I don't think the patch even does what you describe it as doing ... if you reverse the order of the

Re: [PATCH] Only print SCSI data direction warning once for a command

2008-01-12 Thread James Bottomley
On Wed, 2008-01-02 at 07:03 +0100, Andi Kleen wrote: > When I use cdparanoia my logs get spammed a lot by > > printk: 464 messages suppressed. > sg_write: data in/out 30576/30576 bytes for SCSI command 0xbe--guessing data > in; >program cdparanoia not setting count and/or reply_len properly

Re: [PATCH] Only print SCSI data direction warning once for a command

2008-01-12 Thread James Bottomley
On Wed, 2008-01-02 at 07:03 +0100, Andi Kleen wrote: When I use cdparanoia my logs get spammed a lot by printk: 464 messages suppressed. sg_write: data in/out 30576/30576 bytes for SCSI command 0xbe--guessing data in; program cdparanoia not setting count and/or reply_len properly

[PATCH] Only print SCSI data direction warning once for a command

2008-01-01 Thread Andi Kleen
When I use cdparanoia my logs get spammed a lot by printk: 464 messages suppressed. sg_write: data in/out 30576/30576 bytes for SCSI command 0xbe--guessing data in; program cdparanoia not setting count and/or reply_len properly printk: 1078 messages suppressed. and many more of those. With

[PATCH] Only print SCSI data direction warning once for a command

2008-01-01 Thread Andi Kleen
When I use cdparanoia my logs get spammed a lot by printk: 464 messages suppressed. sg_write: data in/out 30576/30576 bytes for SCSI command 0xbe--guessing data in; program cdparanoia not setting count and/or reply_len properly printk: 1078 messages suppressed. and many more of those. With