Re: [PATCH] PCI, pciehp: Reuse set_slot_off()

On Fri, Feb 24, 2017 at 9:17 AM, Raj, Ashok wrote: > On Thu, Feb 23, 2017 at 10:54:35PM -0800, Yinghai Lu wrote: >> +++ linux-2.6/drivers/pci/hotplug/pciehp_ctrl.c >> @@ -71,9 +71,6 @@ static void set_slot_off(struct controll >>*/ >>

Re: [PATCH] PCI, pciehp: Reuse set_slot_off()

On Fri, Feb 24, 2017 at 9:17 AM, Raj, Ashok wrote: > On Thu, Feb 23, 2017 at 10:54:35PM -0800, Yinghai Lu wrote: >> +++ linux-2.6/drivers/pci/hotplug/pciehp_ctrl.c >> @@ -71,9 +71,6 @@ static void set_slot_off(struct controll >>*/ >> msleep(1000); >> } >> - >>

Re: [PATCH] PCI, pciehp: Reuse set_slot_off()

Hi Yinghai On Thu, Feb 23, 2017 at 10:54:35PM -0800, Yinghai Lu wrote: > +++ linux-2.6/drivers/pci/hotplug/pciehp_ctrl.c > @@ -71,9 +71,6 @@ static void set_slot_off(struct controll >*/ > msleep(1000); > } > - > - pciehp_green_led_off(pslot); > -

Re: [PATCH] PCI, pciehp: Reuse set_slot_off()

Hi Yinghai On Thu, Feb 23, 2017 at 10:54:35PM -0800, Yinghai Lu wrote: > +++ linux-2.6/drivers/pci/hotplug/pciehp_ctrl.c > @@ -71,9 +71,6 @@ static void set_slot_off(struct controll >*/ > msleep(1000); > } > - > - pciehp_green_led_off(pslot); > -

[PATCH] PCI, pciehp: Reuse set_slot_off()

Now set_slot_off() is used in board_added() err path. We could reuse in remove_board. Also need to move green_led and attention_status out it. and make code more readable. Signed-off-by: Yinghai Lu --- drivers/pci/hotplug/pciehp_ctrl.c | 16 +++- 1 file

[PATCH] PCI, pciehp: Reuse set_slot_off()

Now set_slot_off() is used in board_added() err path. We could reuse in remove_board. Also need to move green_led and attention_status out it. and make code more readable. Signed-off-by: Yinghai Lu --- drivers/pci/hotplug/pciehp_ctrl.c | 16 +++- 1 file changed, 3