Re: [PATCH] PCI, x86: clear initial value for root info resources

2012-09-23 Thread Konrad Rzeszutek Wilk
On Fri, Sep 21, 2012 at 11:27:00AM -0700, Yinghai Lu wrote: > On Fri, Sep 21, 2012 at 9:50 AM, Konrad Rzeszutek Wilk > wrote: > > On Wed, Sep 19, 2012 at 10:49:00AM -0700, Yinghai Lu wrote: > > > > Can you include the stack trace? > > [ 414.997281] pci_bus :00: freeing pci_bus info > [

Re: [PATCH] PCI, x86: clear initial value for root info resources

2012-09-23 Thread Konrad Rzeszutek Wilk
On Fri, Sep 21, 2012 at 11:27:00AM -0700, Yinghai Lu wrote: On Fri, Sep 21, 2012 at 9:50 AM, Konrad Rzeszutek Wilk kon...@kernel.org wrote: On Wed, Sep 19, 2012 at 10:49:00AM -0700, Yinghai Lu wrote: Can you include the stack trace? [ 414.997281] pci_bus :00: freeing pci_bus info

Re: [PATCH] PCI, x86: clear initial value for root info resources

2012-09-21 Thread Konrad Rzeszutek Wilk
On Wed, Sep 19, 2012 at 10:49:00AM -0700, Yinghai Lu wrote: > Found one system one root bus hot remove get panic. Boy, this is mangled. Can you include the name of the system? Perhaps you can rephrase this to say: "On XYZ removing the root bus (through ACPI unplug) causes a panic." > Panic

Re: [PATCH] PCI, x86: clear initial value for root info resources

2012-09-21 Thread Konrad Rzeszutek Wilk
On Wed, Sep 19, 2012 at 10:49:00AM -0700, Yinghai Lu wrote: Found one system one root bus hot remove get panic. Boy, this is mangled. Can you include the name of the system? Perhaps you can rephrase this to say: On XYZ removing the root bus (through ACPI unplug) causes a panic. Panic happens

[PATCH] PCI, x86: clear initial value for root info resources

2012-09-19 Thread Yinghai Lu
Found one system one root bus hot remove get panic. Panic happens when try to release hostbridge resource. It turns out that resource get reject during put into resource tree because of conflicts. Also that resource parent pointer have random value. That invalid value cause it pass through check

Re: [PATCH] PCI, x86: clear initial value for root info resources

2012-09-19 Thread Yinghai Lu
On Wed, Sep 19, 2012 at 6:12 AM, Bjorn Helgaas wrote: >> yes, but they don't support pci_set_host_bridge_release yet. so they >> should not meet this problem yet. > > Why should we wait to fix that bug until later? I'm not interested in > debugging this in the future. If you fix a bug, you

Re: [PATCH] PCI, x86: clear initial value for root info resources

2012-09-19 Thread Jiang Liu
On 09/19/2012 07:49 AM, Yinghai Lu wrote: > On Tue, Sep 18, 2012 at 3:46 PM, Bjorn Helgaas wrote: >> On Fri, Sep 14, 2012 at 6:48 PM, Yinghai Lu wrote: >>> Found one system one root bus hot remove get panic. >>> Panic happens when try to release hostbridge resource. >>> >>> It turns out that

Re: [PATCH] PCI, x86: clear initial value for root info resources

2012-09-19 Thread Bjorn Helgaas
On Tue, Sep 18, 2012 at 5:49 PM, Yinghai Lu wrote: > On Tue, Sep 18, 2012 at 3:46 PM, Bjorn Helgaas wrote: >> On Fri, Sep 14, 2012 at 6:48 PM, Yinghai Lu wrote: >>> Found one system one root bus hot remove get panic. >>> Panic happens when try to release hostbridge resource. >>> >>> It turns

Re: [PATCH] PCI, x86: clear initial value for root info resources

2012-09-19 Thread Bjorn Helgaas
On Tue, Sep 18, 2012 at 5:49 PM, Yinghai Lu ying...@kernel.org wrote: On Tue, Sep 18, 2012 at 3:46 PM, Bjorn Helgaas bhelg...@google.com wrote: On Fri, Sep 14, 2012 at 6:48 PM, Yinghai Lu ying...@kernel.org wrote: Found one system one root bus hot remove get panic. Panic happens when try to

Re: [PATCH] PCI, x86: clear initial value for root info resources

2012-09-19 Thread Jiang Liu
On 09/19/2012 07:49 AM, Yinghai Lu wrote: On Tue, Sep 18, 2012 at 3:46 PM, Bjorn Helgaas bhelg...@google.com wrote: On Fri, Sep 14, 2012 at 6:48 PM, Yinghai Lu ying...@kernel.org wrote: Found one system one root bus hot remove get panic. Panic happens when try to release hostbridge resource.

Re: [PATCH] PCI, x86: clear initial value for root info resources

2012-09-19 Thread Yinghai Lu
On Wed, Sep 19, 2012 at 6:12 AM, Bjorn Helgaas bhelg...@google.com wrote: yes, but they don't support pci_set_host_bridge_release yet. so they should not meet this problem yet. Why should we wait to fix that bug until later? I'm not interested in debugging this in the future. If you fix a

[PATCH] PCI, x86: clear initial value for root info resources

2012-09-19 Thread Yinghai Lu
Found one system one root bus hot remove get panic. Panic happens when try to release hostbridge resource. It turns out that resource get reject during put into resource tree because of conflicts. Also that resource parent pointer have random value. That invalid value cause it pass through check

Re: [PATCH] PCI, x86: clear initial value for root info resources

2012-09-18 Thread Yinghai Lu
On Tue, Sep 18, 2012 at 3:46 PM, Bjorn Helgaas wrote: > On Fri, Sep 14, 2012 at 6:48 PM, Yinghai Lu wrote: >> Found one system one root bus hot remove get panic. >> Panic happens when try to release hostbridge resource. >> >> It turns out that resource get reject during put into resource tree >>

Re: [PATCH] PCI, x86: clear initial value for root info resources

2012-09-18 Thread Bjorn Helgaas
On Fri, Sep 14, 2012 at 6:48 PM, Yinghai Lu wrote: > Found one system one root bus hot remove get panic. > Panic happens when try to release hostbridge resource. > > It turns out that resource get reject during put into resource tree > because of conflicts. > Also that resource parent pointer

Re: [PATCH] PCI, x86: clear initial value for root info resources

2012-09-18 Thread Bjorn Helgaas
On Fri, Sep 14, 2012 at 6:48 PM, Yinghai Lu ying...@kernel.org wrote: Found one system one root bus hot remove get panic. Panic happens when try to release hostbridge resource. It turns out that resource get reject during put into resource tree because of conflicts. Also that resource parent

Re: [PATCH] PCI, x86: clear initial value for root info resources

2012-09-18 Thread Yinghai Lu
On Tue, Sep 18, 2012 at 3:46 PM, Bjorn Helgaas bhelg...@google.com wrote: On Fri, Sep 14, 2012 at 6:48 PM, Yinghai Lu ying...@kernel.org wrote: Found one system one root bus hot remove get panic. Panic happens when try to release hostbridge resource. It turns out that resource get reject

[PATCH] PCI, x86: clear initial value for root info resources

2012-09-14 Thread Yinghai Lu
Found one system one root bus hot remove get panic. Panic happens when try to release hostbridge resource. It turns out that resource get reject during put into resource tree because of conflicts. Also that resource parent pointer have random value. That invalid value cause it pass through check

[PATCH] PCI, x86: clear initial value for root info resources

2012-09-14 Thread Yinghai Lu
Found one system one root bus hot remove get panic. Panic happens when try to release hostbridge resource. It turns out that resource get reject during put into resource tree because of conflicts. Also that resource parent pointer have random value. That invalid value cause it pass through check