On 08/09/2018 02:18 PM, Bjorn Helgaas wrote:
On Thu, Aug 09, 2018 at 02:00:23PM -0500, Alex G. wrote:
On 08/09/2018 01:29 PM, Bjorn Helgaas wrote:
On Thu, Aug 09, 2018 at 04:46:32PM +, alex_gagn...@dellteam.com wrote:
On 08/09/2018 09:16 AM, Bjorn Helgaas wrote:
(snip_
On 08/09/2018 02:18 PM, Bjorn Helgaas wrote:
On Thu, Aug 09, 2018 at 02:00:23PM -0500, Alex G. wrote:
On 08/09/2018 01:29 PM, Bjorn Helgaas wrote:
On Thu, Aug 09, 2018 at 04:46:32PM +, alex_gagn...@dellteam.com wrote:
On 08/09/2018 09:16 AM, Bjorn Helgaas wrote:
(snip_
On Thu, Aug 09, 2018 at 02:00:23PM -0500, Alex G. wrote:
> On 08/09/2018 01:29 PM, Bjorn Helgaas wrote:
> > On Thu, Aug 09, 2018 at 04:46:32PM +, alex_gagn...@dellteam.com wrote:
> > > On 08/09/2018 09:16 AM, Bjorn Helgaas wrote:
> (snip_
> > > > enable_ecrc_checking()
> > > >
On Thu, Aug 09, 2018 at 02:00:23PM -0500, Alex G. wrote:
> On 08/09/2018 01:29 PM, Bjorn Helgaas wrote:
> > On Thu, Aug 09, 2018 at 04:46:32PM +, alex_gagn...@dellteam.com wrote:
> > > On 08/09/2018 09:16 AM, Bjorn Helgaas wrote:
> (snip_
> > > > enable_ecrc_checking()
> > > >
On 08/09/2018 01:29 PM, Bjorn Helgaas wrote:
On Thu, Aug 09, 2018 at 04:46:32PM +, alex_gagn...@dellteam.com wrote:
On 08/09/2018 09:16 AM, Bjorn Helgaas wrote:
(snip_
enable_ecrc_checking()
disable_ecrc_checking()
I don't immediately see how this would affect FFS, but the
On 08/09/2018 01:29 PM, Bjorn Helgaas wrote:
On Thu, Aug 09, 2018 at 04:46:32PM +, alex_gagn...@dellteam.com wrote:
On 08/09/2018 09:16 AM, Bjorn Helgaas wrote:
(snip_
enable_ecrc_checking()
disable_ecrc_checking()
I don't immediately see how this would affect FFS, but the
On Thu, Aug 09, 2018 at 04:46:32PM +, alex_gagn...@dellteam.com wrote:
> On 08/09/2018 09:16 AM, Bjorn Helgaas wrote:
> > On Tue, Jul 17, 2018 at 10:31:23AM -0500, Alexandru Gagniuc wrote:
> >> When we don't own AER, we shouldn't touch the AER error bits. This
> >> happens unconditionally on
On Thu, Aug 09, 2018 at 04:46:32PM +, alex_gagn...@dellteam.com wrote:
> On 08/09/2018 09:16 AM, Bjorn Helgaas wrote:
> > On Tue, Jul 17, 2018 at 10:31:23AM -0500, Alexandru Gagniuc wrote:
> >> When we don't own AER, we shouldn't touch the AER error bits. This
> >> happens unconditionally on
On 08/09/2018 09:16 AM, Bjorn Helgaas wrote:
> On Tue, Jul 17, 2018 at 10:31:23AM -0500, Alexandru Gagniuc wrote:
>> When we don't own AER, we shouldn't touch the AER error bits. This
>> happens unconditionally on device probe(). Clearing AER bits
>> willy-nilly might cause firmware to miss
On 08/09/2018 09:16 AM, Bjorn Helgaas wrote:
> On Tue, Jul 17, 2018 at 10:31:23AM -0500, Alexandru Gagniuc wrote:
>> When we don't own AER, we shouldn't touch the AER error bits. This
>> happens unconditionally on device probe(). Clearing AER bits
>> willy-nilly might cause firmware to miss
On Tue, Jul 17, 2018 at 10:31:23AM -0500, Alexandru Gagniuc wrote:
> When we don't own AER, we shouldn't touch the AER error bits. This
> happens unconditionally on device probe(). Clearing AER bits
> willy-nilly might cause firmware to miss errors. Instead
> these bits should get cleared by FFS,
On Tue, Jul 17, 2018 at 10:31:23AM -0500, Alexandru Gagniuc wrote:
> When we don't own AER, we shouldn't touch the AER error bits. This
> happens unconditionally on device probe(). Clearing AER bits
> willy-nilly might cause firmware to miss errors. Instead
> these bits should get cleared by FFS,
On 07/19/2018 11:58 AM, Sinan Kaya wrote:
On 7/19/2018 8:55 AM, Alex G. wrote:
I find the intent clearer if we check it here rather than having to do
the mental parsing of the state of aer_cap.
I don't feel too strong about my comment to be honest. This was a
style/maintenance comment.
On 07/19/2018 11:58 AM, Sinan Kaya wrote:
On 7/19/2018 8:55 AM, Alex G. wrote:
I find the intent clearer if we check it here rather than having to do
the mental parsing of the state of aer_cap.
I don't feel too strong about my comment to be honest. This was a
style/maintenance comment.
On 7/19/2018 8:55 AM, Alex G. wrote:
I find the intent clearer if we check it here rather than having to do
the mental parsing of the state of aer_cap.
I don't feel too strong about my comment to be honest. This was a
style/maintenance comment.
It feels like we are putting
On 7/19/2018 8:55 AM, Alex G. wrote:
I find the intent clearer if we check it here rather than having to do
the mental parsing of the state of aer_cap.
I don't feel too strong about my comment to be honest. This was a
style/maintenance comment.
It feels like we are putting
On 07/17/2018 10:41 AM, Sinan Kaya wrote:
On 7/17/2018 8:31 AM, Alexandru Gagniuc wrote:
+ if (pcie_aer_get_firmware_first(dev))
+ return -EIO;
Can you move this to closer to the caller pci_aer_init()?
I could move it there. although pci_cleanup_aer_error_status_regs() is
On 07/17/2018 10:41 AM, Sinan Kaya wrote:
On 7/17/2018 8:31 AM, Alexandru Gagniuc wrote:
+ if (pcie_aer_get_firmware_first(dev))
+ return -EIO;
Can you move this to closer to the caller pci_aer_init()?
I could move it there. although pci_cleanup_aer_error_status_regs() is
On 7/17/2018 8:31 AM, Alexandru Gagniuc wrote:
+ if (pcie_aer_get_firmware_first(dev))
+ return -EIO;
Can you move this to closer to the caller pci_aer_init()?
On 7/17/2018 8:31 AM, Alexandru Gagniuc wrote:
+ if (pcie_aer_get_firmware_first(dev))
+ return -EIO;
Can you move this to closer to the caller pci_aer_init()?
When we don't own AER, we shouldn't touch the AER error bits. This
happens unconditionally on device probe(). Clearing AER bits
willy-nilly might cause firmware to miss errors. Instead
these bits should get cleared by FFS, or via ACPI _HPX method.
This race is mostly of theoretical significance,
When we don't own AER, we shouldn't touch the AER error bits. This
happens unconditionally on device probe(). Clearing AER bits
willy-nilly might cause firmware to miss errors. Instead
these bits should get cleared by FFS, or via ACPI _HPX method.
This race is mostly of theoretical significance,
22 matches
Mail list logo
