Re: [PATCH] PCI: Add sysfs attribute for disabling PCIe link to downstream component

2019-08-21 Thread Bjorn Helgaas
On Wed, Aug 21, 2019 at 05:37:51PM +0300, Mika Westerberg wrote: > On Wed, Aug 21, 2019 at 10:28:37AM +0300, Mika Westerberg wrote: > > > If we see a type of PCI_EXP_TYPE_ROOT_PORT or > > > PCI_EXP_TYPE_PCIE_BRIDGE, I think we have to assume that's accurate > > > (which we already do today -- for

Re: [PATCH] PCI: Add sysfs attribute for disabling PCIe link to downstream component

2019-08-21 Thread Mika Westerberg
On Wed, Aug 21, 2019 at 10:28:37AM +0300, Mika Westerberg wrote: > > If we see a type of PCI_EXP_TYPE_ROOT_PORT or > > PCI_EXP_TYPE_PCIE_BRIDGE, I think we have to assume that's accurate > > (which we already do today -- for those types, we assume the device > > has a secondary link). > > > > For

Re: [PATCH] PCI: Add sysfs attribute for disabling PCIe link to downstream component

2019-08-21 Thread Mika Westerberg
On Tue, Aug 20, 2019 at 09:17:17AM -0500, Bjorn Helgaas wrote: > On Tue, Aug 20, 2019 at 12:58:20PM +0300, Mika Westerberg wrote: > > On Mon, Aug 19, 2019 at 06:52:45PM -0500, Bjorn Helgaas wrote: > > > > Right, it looks like we need some sort of flag there anyway. > > > > > > Does this mean

Re: [PATCH] PCI: Add sysfs attribute for disabling PCIe link to downstream component

2019-08-20 Thread Bjorn Helgaas
On Tue, Aug 20, 2019 at 12:58:20PM +0300, Mika Westerberg wrote: > On Mon, Aug 19, 2019 at 06:52:45PM -0500, Bjorn Helgaas wrote: > > > Right, it looks like we need some sort of flag there anyway. > > > > Does this mean you're looking at getting rid of "has_secondary_link", > > you think it's

Re: [PATCH] PCI: Add sysfs attribute for disabling PCIe link to downstream component

2019-08-20 Thread Mika Westerberg
On Mon, Aug 19, 2019 at 06:52:45PM -0500, Bjorn Helgaas wrote: > > Right, it looks like we need some sort of flag there anyway. > > Does this mean you're looking at getting rid of "has_secondary_link", > you think it's impossible, or you think it's not worth trying? I was of thinking that we

Re: [PATCH] PCI: Add sysfs attribute for disabling PCIe link to downstream component

2019-08-19 Thread Bjorn Helgaas
On Tue, Aug 06, 2019 at 01:12:30PM +0300, Mika Westerberg wrote: > On Thu, Aug 01, 2019 at 04:53:39PM -0500, Bjorn Helgaas wrote: > > [+cc FPGA folks, just FYI; I'm pretty sure PCI could do a much better > > job supporting FPGAs, so any input is welcome!] > > > > On Wed, Jul 03, 2019 at

Re: [PATCH] PCI: Add sysfs attribute for disabling PCIe link to downstream component

2019-08-06 Thread Mika Westerberg
On Thu, Aug 01, 2019 at 04:53:39PM -0500, Bjorn Helgaas wrote: > [+cc FPGA folks, just FYI; I'm pretty sure PCI could do a much better > job supporting FPGAs, so any input is welcome!] > > On Wed, Jul 03, 2019 at 06:03:41PM +0300, Mika Westerberg wrote: > > On Wed, Jul 03, 2019 at 08:39:53AM

Re: [PATCH] PCI: Add sysfs attribute for disabling PCIe link to downstream component

2019-08-04 Thread Wu Hao
On Thu, Aug 01, 2019 at 04:53:39PM -0500, Bjorn Helgaas wrote: > [+cc FPGA folks, just FYI; I'm pretty sure PCI could do a much better > job supporting FPGAs, so any input is welcome!] > > On Wed, Jul 03, 2019 at 06:03:41PM +0300, Mika Westerberg wrote: > > On Wed, Jul 03, 2019 at 08:39:53AM

Re: [PATCH] PCI: Add sysfs attribute for disabling PCIe link to downstream component

2019-08-01 Thread Bjorn Helgaas
[+cc FPGA folks, just FYI; I'm pretty sure PCI could do a much better job supporting FPGAs, so any input is welcome!] On Wed, Jul 03, 2019 at 06:03:41PM +0300, Mika Westerberg wrote: > On Wed, Jul 03, 2019 at 08:39:53AM -0500, Bjorn Helgaas wrote: > > On Wed, May 29, 2019 at 01:49:42PM +0300,