Re: [PATCH] PCI: Remove duplicate pci_disable_device for pcie port

2013-04-26 Thread Yijing Wang
On 2013/4/26 14:20, Yinghai Lu wrote: > On Thu, Apr 25, 2013 at 9:02 PM, Yijing Wang wrote: >> Hi Yinghai, >>We should not remove this additional pci_disable_device(). >> Because we enable pcie port device twice before. The first is >> pci_enable_brides(), >> in x86, it was called in

Re: [PATCH] PCI: Remove duplicate pci_disable_device for pcie port

2013-04-26 Thread Yinghai Lu
On Thu, Apr 25, 2013 at 9:02 PM, Yijing Wang wrote: > Hi Yinghai, >We should not remove this additional pci_disable_device(). > Because we enable pcie port device twice before. The first is > pci_enable_brides(), > in x86, it was called in pci_assign_unassigned_resources(). The second in >

Re: [PATCH] PCI: Remove duplicate pci_disable_device for pcie port

2013-04-26 Thread Yinghai Lu
On Thu, Apr 25, 2013 at 9:02 PM, Yijing Wang wangyij...@huawei.com wrote: Hi Yinghai, We should not remove this additional pci_disable_device(). Because we enable pcie port device twice before. The first is pci_enable_brides(), in x86, it was called in pci_assign_unassigned_resources().

Re: [PATCH] PCI: Remove duplicate pci_disable_device for pcie port

2013-04-26 Thread Yijing Wang
On 2013/4/26 14:20, Yinghai Lu wrote: On Thu, Apr 25, 2013 at 9:02 PM, Yijing Wang wangyij...@huawei.com wrote: Hi Yinghai, We should not remove this additional pci_disable_device(). Because we enable pcie port device twice before. The first is pci_enable_brides(), in x86, it was called

Re: [PATCH] PCI: Remove duplicate pci_disable_device for pcie port

2013-04-25 Thread Yijing Wang
Hi Yinghai, We should not remove this additional pci_disable_device(). Because we enable pcie port device twice before. The first is pci_enable_brides(), in x86, it was called in pci_assign_unassigned_resources(). The second in pcie_port_device_register(). So we should call

[PATCH] PCI: Remove duplicate pci_disable_device for pcie port

2013-04-25 Thread Yinghai Lu
During chasing one PCI xHCI hotplug problem, David Bulkow found static void pcie_portdrv_remove(struct pci_dev *dev) { pcie_port_device_remove(dev); pci_disable_device(dev); } and void pcie_port_device_remove(struct pci_dev *dev)

[PATCH] PCI: Remove duplicate pci_disable_device for pcie port

2013-04-25 Thread Yinghai Lu
During chasing one PCI xHCI hotplug problem, David Bulkow found static void pcie_portdrv_remove(struct pci_dev *dev) { pcie_port_device_remove(dev); pci_disable_device(dev); } and void pcie_port_device_remove(struct pci_dev *dev)

Re: [PATCH] PCI: Remove duplicate pci_disable_device for pcie port

2013-04-25 Thread Yijing Wang
Hi Yinghai, We should not remove this additional pci_disable_device(). Because we enable pcie port device twice before. The first is pci_enable_brides(), in x86, it was called in pci_assign_unassigned_resources(). The second in pcie_port_device_register(). So we should call