Re: [PATCH] PCI: Workaround AMD EHCI controller PME bug

2017-06-19 Thread Kai-Heng Feng
On Tue, Jun 20, 2017 at 2:01 AM, Bjorn Helgaas wrote: > > Applied (patch below) to pci/pm for v4.13, thanks! > > Note that I added parens because bitwise NOT is higher precedence than > bitwise shift right, and I think we want the shift before the NOT. Please > double-check.

Re: [PATCH] PCI: Workaround AMD EHCI controller PME bug

2017-06-19 Thread Kai-Heng Feng
On Tue, Jun 20, 2017 at 2:01 AM, Bjorn Helgaas wrote: > > Applied (patch below) to pci/pm for v4.13, thanks! > > Note that I added parens because bitwise NOT is higher precedence than > bitwise shift right, and I think we want the shift before the NOT. Please > double-check. You are right. NOT

Re: [PATCH] PCI: Workaround AMD EHCI controller PME bug

2017-06-19 Thread Bjorn Helgaas
[+cc Alan] On Fri, Jun 16, 2017 at 05:40:54PM +0800, Kai-Heng Feng wrote: > On an AMD Carrizo laptop, when EHCI runtime PM is enabled, EHCI ports do > not respond to any device plugging event. > > As Alan Stern points out [1], the PME signal is not enabled when > controller is in D3, therefore

Re: [PATCH] PCI: Workaround AMD EHCI controller PME bug

2017-06-19 Thread Bjorn Helgaas
[+cc Alan] On Fri, Jun 16, 2017 at 05:40:54PM +0800, Kai-Heng Feng wrote: > On an AMD Carrizo laptop, when EHCI runtime PM is enabled, EHCI ports do > not respond to any device plugging event. > > As Alan Stern points out [1], the PME signal is not enabled when > controller is in D3, therefore

[PATCH] PCI: Workaround AMD EHCI controller PME bug

2017-06-16 Thread Kai-Heng Feng
On an AMD Carrizo laptop, when EHCI runtime PM is enabled, EHCI ports do not respond to any device plugging event. As Alan Stern points out [1], the PME signal is not enabled when controller is in D3, therefore it's not being woken up when new deivces get plugged in. Testing shows PME signal

[PATCH] PCI: Workaround AMD EHCI controller PME bug

2017-06-16 Thread Kai-Heng Feng
On an AMD Carrizo laptop, when EHCI runtime PM is enabled, EHCI ports do not respond to any device plugging event. As Alan Stern points out [1], the PME signal is not enabled when controller is in D3, therefore it's not being woken up when new deivces get plugged in. Testing shows PME signal