Re: [PATCH] PCI: add a quirk for keeping Bus Master bit on shutdown

2013-11-26 Thread Konstantin Khlebnikov
On Tue, Nov 26, 2013 at 10:37 PM, Khalid Aziz wrote: > On Tue, Nov 26, 2013 at 05:48:06PM +, Matthew Garrett wrote: >> On Tue, Nov 26, 2013 at 10:35:26AM -0700, Bjorn Helgaas wrote: >> > On Tue, Nov 26, 2013 at 9:40 AM, Khalid Aziz >> > wrote: >> > > Disabling Bus Master bit is effectively

Re: [PATCH] PCI: add a quirk for keeping Bus Master bit on shutdown

2013-11-26 Thread Khalid Aziz
On Tue, Nov 26, 2013 at 05:48:06PM +, Matthew Garrett wrote: > On Tue, Nov 26, 2013 at 10:35:26AM -0700, Bjorn Helgaas wrote: > > On Tue, Nov 26, 2013 at 9:40 AM, Khalid Aziz wrote: > > > Disabling Bus Master bit is effectively a brute force and not an elegant > > > way > > > to stop

Re: [PATCH] PCI: add a quirk for keeping Bus Master bit on shutdown

2013-11-26 Thread Matthew Garrett
On Tue, Nov 26, 2013 at 10:35:26AM -0700, Bjorn Helgaas wrote: > On Tue, Nov 26, 2013 at 9:40 AM, Khalid Aziz wrote: > > Disabling Bus Master bit is effectively a brute force and not an elegant way > > to stop unwanted DMA. It can have side effects as Alan and others pointed > > out in the

Re: [PATCH] PCI: add a quirk for keeping Bus Master bit on shutdown

2013-11-26 Thread Bjorn Helgaas
[+cc Eric, Matthew] On Tue, Nov 26, 2013 at 9:40 AM, Khalid Aziz wrote: > On 11/25/2013 08:33 PM, Bjorn Helgaas wrote: >> >> [+cc Lan, Khalid, Konstantin, Alan, Takao, Jility, Florian, linux-kernel] >> >> On Tue, Nov 12, 2013 at 07:40:03PM +, Chang Liu wrote: >>> >>> This fixes

Re: [PATCH] PCI: add a quirk for keeping Bus Master bit on shutdown

2013-11-26 Thread Khalid Aziz
On 11/25/2013 08:33 PM, Bjorn Helgaas wrote: [+cc Lan, Khalid, Konstantin, Alan, Takao, Jility, Florian, linux-kernel] On Tue, Nov 12, 2013 at 07:40:03PM +, Chang Liu wrote: This fixes https://bugzilla.kernel.org/show_bug.cgi?id=63861 Commit b566a22c2 and 7897e60227 made

Re: [PATCH] PCI: add a quirk for keeping Bus Master bit on shutdown

2013-11-26 Thread Khalid Aziz
On 11/25/2013 08:33 PM, Bjorn Helgaas wrote: [+cc Lan, Khalid, Konstantin, Alan, Takao, Jility, Florian, linux-kernel] On Tue, Nov 12, 2013 at 07:40:03PM +, Chang Liu wrote: This fixes https://bugzilla.kernel.org/show_bug.cgi?id=63861 Commit b566a22c2 and 7897e60227 made

Re: [PATCH] PCI: add a quirk for keeping Bus Master bit on shutdown

2013-11-26 Thread Bjorn Helgaas
[+cc Eric, Matthew] On Tue, Nov 26, 2013 at 9:40 AM, Khalid Aziz khalid.a...@oracle.com wrote: On 11/25/2013 08:33 PM, Bjorn Helgaas wrote: [+cc Lan, Khalid, Konstantin, Alan, Takao, Jility, Florian, linux-kernel] On Tue, Nov 12, 2013 at 07:40:03PM +, Chang Liu wrote: This fixes

Re: [PATCH] PCI: add a quirk for keeping Bus Master bit on shutdown

2013-11-26 Thread Matthew Garrett
On Tue, Nov 26, 2013 at 10:35:26AM -0700, Bjorn Helgaas wrote: On Tue, Nov 26, 2013 at 9:40 AM, Khalid Aziz khalid.a...@oracle.com wrote: Disabling Bus Master bit is effectively a brute force and not an elegant way to stop unwanted DMA. It can have side effects as Alan and others pointed

Re: [PATCH] PCI: add a quirk for keeping Bus Master bit on shutdown

2013-11-26 Thread Khalid Aziz
On Tue, Nov 26, 2013 at 05:48:06PM +, Matthew Garrett wrote: On Tue, Nov 26, 2013 at 10:35:26AM -0700, Bjorn Helgaas wrote: On Tue, Nov 26, 2013 at 9:40 AM, Khalid Aziz khalid.a...@oracle.com wrote: Disabling Bus Master bit is effectively a brute force and not an elegant way to

Re: [PATCH] PCI: add a quirk for keeping Bus Master bit on shutdown

2013-11-26 Thread Konstantin Khlebnikov
On Tue, Nov 26, 2013 at 10:37 PM, Khalid Aziz khalid.a...@oracle.com wrote: On Tue, Nov 26, 2013 at 05:48:06PM +, Matthew Garrett wrote: On Tue, Nov 26, 2013 at 10:35:26AM -0700, Bjorn Helgaas wrote: On Tue, Nov 26, 2013 at 9:40 AM, Khalid Aziz khalid.a...@oracle.com wrote: Disabling

Re: [PATCH] PCI: add a quirk for keeping Bus Master bit on shutdown

2013-11-25 Thread Lan Tianyu
On 2013年11月26日 11:33, Bjorn Helgaas wrote: > Lan, do you have access to any Lynx Point boxes? Can you test and see > whether they hang on power-off also? I suspect this might be something > specific to the Acer box, not a generic Lynx Point issue. Sure. I just get one such prototype laptop and

Re: [PATCH] PCI: add a quirk for keeping Bus Master bit on shutdown

2013-11-25 Thread Bjorn Helgaas
On Mon, Nov 25, 2013 at 9:11 PM, Chang Liu wrote: > If this turns out to be a problem specific to Acer V573G, we can simply > wrap the if (pdev->...) line in ata/ahci.c with if > (dmi_check_system(acer_v573g)) > so that only acer v573g laptops will be affected by this patch. The remaining > part

Re: [PATCH] PCI: add a quirk for keeping Bus Master bit on shutdown

2013-11-25 Thread Chang Liu
If this turns out to be a problem specific to Acer V573G, we can simply wrap the if (pdev->...) line in ata/ahci.c with if (dmi_check_system(acer_v573g)) so that only acer v573g laptops will be affected by this patch. The remaining part of the patch won't need to be changed. I can do an updated

Re: [PATCH] PCI: add a quirk for keeping Bus Master bit on shutdown

2013-11-25 Thread Bjorn Helgaas
[+cc Lan, Khalid, Konstantin, Alan, Takao, Jility, Florian, linux-kernel] On Tue, Nov 12, 2013 at 07:40:03PM +, Chang Liu wrote: > This fixes https://bugzilla.kernel.org/show_bug.cgi?id=63861 > > Commit b566a22c2 and 7897e60227 made pci_device_shutdown() > unconditionally clear Bus Master bit

Re: [PATCH] PCI: add a quirk for keeping Bus Master bit on shutdown

2013-11-25 Thread Bjorn Helgaas
[+cc Lan, Khalid, Konstantin, Alan, Takao, Jility, Florian, linux-kernel] On Tue, Nov 12, 2013 at 07:40:03PM +, Chang Liu wrote: This fixes https://bugzilla.kernel.org/show_bug.cgi?id=63861 Commit b566a22c2 and 7897e60227 made pci_device_shutdown() unconditionally clear Bus Master bit for

Re: [PATCH] PCI: add a quirk for keeping Bus Master bit on shutdown

2013-11-25 Thread Chang Liu
If this turns out to be a problem specific to Acer V573G, we can simply wrap the if (pdev-...) line in ata/ahci.c with if (dmi_check_system(acer_v573g)) so that only acer v573g laptops will be affected by this patch. The remaining part of the patch won't need to be changed. I can do an updated

Re: [PATCH] PCI: add a quirk for keeping Bus Master bit on shutdown

2013-11-25 Thread Bjorn Helgaas
On Mon, Nov 25, 2013 at 9:11 PM, Chang Liu cl9...@gmail.com wrote: If this turns out to be a problem specific to Acer V573G, we can simply wrap the if (pdev-...) line in ata/ahci.c with if (dmi_check_system(acer_v573g)) so that only acer v573g laptops will be affected by this patch. The

Re: [PATCH] PCI: add a quirk for keeping Bus Master bit on shutdown

2013-11-25 Thread Lan Tianyu
On 2013年11月26日 11:33, Bjorn Helgaas wrote: Lan, do you have access to any Lynx Point boxes? Can you test and see whether they hang on power-off also? I suspect this might be something specific to the Acer box, not a generic Lynx Point issue. Sure. I just get one such prototype laptop and