Re: [PATCH] PCI AER: Handle non-AER HEST error sources in aer_hest_parse()

2013-12-16 Thread Bjorn Helgaas
On Mon, Dec 16, 2013 at 8:15 AM, Betty Dall wrote: > On Fri, 2013-12-13 at 16:06 -0700, Bjorn Helgaas wrote: > >> I should have thought longer before hitting send. I think it's worthwhile >> to use the same helper in aer_hest_parse_aff(), and once I did that, it >> became more obvious that

Re: [PATCH] PCI AER: Handle non-AER HEST error sources in aer_hest_parse()

2013-12-16 Thread Betty Dall
On Fri, 2013-12-13 at 16:06 -0700, Bjorn Helgaas wrote: > I should have thought longer before hitting send. I think it's worthwhile > to use the same helper in aer_hest_parse_aff(), and once I did that, it > became more obvious that aer_hest_parse() and aer_hest_parse_aff() are > essentially

Re: [PATCH] PCI AER: Handle non-AER HEST error sources in aer_hest_parse()

2013-12-16 Thread Betty Dall
On Fri, 2013-12-13 at 16:06 -0700, Bjorn Helgaas wrote: I should have thought longer before hitting send. I think it's worthwhile to use the same helper in aer_hest_parse_aff(), and once I did that, it became more obvious that aer_hest_parse() and aer_hest_parse_aff() are essentially

Re: [PATCH] PCI AER: Handle non-AER HEST error sources in aer_hest_parse()

2013-12-16 Thread Bjorn Helgaas
On Mon, Dec 16, 2013 at 8:15 AM, Betty Dall betty.d...@hp.com wrote: On Fri, 2013-12-13 at 16:06 -0700, Bjorn Helgaas wrote: I should have thought longer before hitting send. I think it's worthwhile to use the same helper in aer_hest_parse_aff(), and once I did that, it became more obvious

Re: [PATCH] PCI AER: Handle non-AER HEST error sources in aer_hest_parse()

2013-12-13 Thread Bjorn Helgaas
On Fri, Dec 13, 2013 at 03:47:33PM -0700, Betty Dall wrote: > Yes, that is more readable code. Thanks for revising it. I tested it on > my system that has non-AER error sources and it works fine. One nit is > that "Ignore" is misspelled in the subject line. Thanks, fixed. I should have thought

Re: [PATCH] PCI AER: Handle non-AER HEST error sources in aer_hest_parse()

2013-12-13 Thread Betty Dall
On Fri, 2013-12-13 at 15:16 -0700, Bjorn Helgaas wrote: > On Fri, Dec 13, 2013 at 08:23:16AM -0700, Betty Dall wrote: > > aer_hest_parse() could pass a non-AER HEST error source to the function > > hest_match_pci(). hest_match_pci() assumes that the HEST error source is > > type

Re: [PATCH] PCI AER: Handle non-AER HEST error sources in aer_hest_parse()

2013-12-13 Thread Bjorn Helgaas
On Fri, Dec 13, 2013 at 08:23:16AM -0700, Betty Dall wrote: > aer_hest_parse() could pass a non-AER HEST error source to the function > hest_match_pci(). hest_match_pci() assumes that the HEST error source is > type ACPI_HEST_TYPE_AER_ROOT_PORT, ACPI_HEST_TYPE_AER_ENDPOINT, or >

[PATCH] PCI AER: Handle non-AER HEST error sources in aer_hest_parse()

2013-12-13 Thread Betty Dall
aer_hest_parse() could pass a non-AER HEST error source to the function hest_match_pci(). hest_match_pci() assumes that the HEST error source is type ACPI_HEST_TYPE_AER_ROOT_PORT, ACPI_HEST_TYPE_AER_ENDPOINT, or ACPI_HEST_TYPE_AER_BRIDGE. I have a platform that has some ACPI_HEST_TYPE_GENERIC

[PATCH] PCI AER: Handle non-AER HEST error sources in aer_hest_parse()

2013-12-13 Thread Betty Dall
aer_hest_parse() could pass a non-AER HEST error source to the function hest_match_pci(). hest_match_pci() assumes that the HEST error source is type ACPI_HEST_TYPE_AER_ROOT_PORT, ACPI_HEST_TYPE_AER_ENDPOINT, or ACPI_HEST_TYPE_AER_BRIDGE. I have a platform that has some ACPI_HEST_TYPE_GENERIC

Re: [PATCH] PCI AER: Handle non-AER HEST error sources in aer_hest_parse()

2013-12-13 Thread Bjorn Helgaas
On Fri, Dec 13, 2013 at 08:23:16AM -0700, Betty Dall wrote: aer_hest_parse() could pass a non-AER HEST error source to the function hest_match_pci(). hest_match_pci() assumes that the HEST error source is type ACPI_HEST_TYPE_AER_ROOT_PORT, ACPI_HEST_TYPE_AER_ENDPOINT, or

Re: [PATCH] PCI AER: Handle non-AER HEST error sources in aer_hest_parse()

2013-12-13 Thread Betty Dall
On Fri, 2013-12-13 at 15:16 -0700, Bjorn Helgaas wrote: On Fri, Dec 13, 2013 at 08:23:16AM -0700, Betty Dall wrote: aer_hest_parse() could pass a non-AER HEST error source to the function hest_match_pci(). hest_match_pci() assumes that the HEST error source is type

Re: [PATCH] PCI AER: Handle non-AER HEST error sources in aer_hest_parse()

2013-12-13 Thread Bjorn Helgaas
On Fri, Dec 13, 2013 at 03:47:33PM -0700, Betty Dall wrote: Yes, that is more readable code. Thanks for revising it. I tested it on my system that has non-AER error sources and it works fine. One nit is that Ignore is misspelled in the subject line. Thanks, fixed. I should have thought