ChangeSet 1.1998.11.17, 2005/02/17 15:05:32-08:00, [EMAIL PROTECTED] [PATCH] PCI Hotplug: Fix OSHP calls in shpchp and pciehp drivers
Here is a patch to fix a problem in OSHP calls in shpchp and pciehp drivers that was detected in 2.6.11-rc3. In this kernel, calls to acpi_evaluate_object() to evaluate OSHP returned AE_BUFFER_OVERFLOW with the existing code. Earlier kernels didn't return this error code. The correct fix should be making return_buffer pointer NULL for no value is returned from this method. Signed-off-by: Dely Sy <[EMAIL PROTECTED]> Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> drivers/pci/hotplug/pciehprm_acpi.c | 3 +-- drivers/pci/hotplug/shpchprm_acpi.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff -Nru a/drivers/pci/hotplug/pciehprm_acpi.c b/drivers/pci/hotplug/pciehprm_acpi.c --- a/drivers/pci/hotplug/pciehprm_acpi.c 2005-03-04 12:42:18 -08:00 +++ b/drivers/pci/hotplug/pciehprm_acpi.c 2005-03-04 12:42:18 -08:00 @@ -254,10 +254,9 @@ { acpi_status status; u8 *path_name = acpi_path_name(ab->handle); - struct acpi_buffer ret_buf = { 0, NULL}; /* run OSHP */ - status = acpi_evaluate_object(ab->handle, METHOD_NAME_OSHP, NULL, &ret_buf); + status = acpi_evaluate_object(ab->handle, METHOD_NAME_OSHP, NULL, NULL); if (ACPI_FAILURE(status)) { err("acpi_pciehprm:%s OSHP fails=0x%x\n", path_name, status); oshp_run_status = (status == AE_NOT_FOUND) ? OSHP_NOT_EXIST : OSHP_RUN_FAILED; diff -Nru a/drivers/pci/hotplug/shpchprm_acpi.c b/drivers/pci/hotplug/shpchprm_acpi.c --- a/drivers/pci/hotplug/shpchprm_acpi.c 2005-03-04 12:42:18 -08:00 +++ b/drivers/pci/hotplug/shpchprm_acpi.c 2005-03-04 12:42:18 -08:00 @@ -242,10 +242,9 @@ { acpi_status status; u8 *path_name = acpi_path_name(ab->handle); - struct acpi_buffer ret_buf = { 0, NULL}; /* run OSHP */ - status = acpi_evaluate_object(ab->handle, METHOD_NAME_OSHP, NULL, &ret_buf); + status = acpi_evaluate_object(ab->handle, METHOD_NAME_OSHP, NULL, NULL); if (ACPI_FAILURE(status)) { err("acpi_pciehprm:%s OSHP fails=0x%x\n", path_name, status); } else - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/