Re: [PATCH] PWM: atmel: fix incorrect CDTY value after enabling or disabling

2014-08-25 Thread Thierry Reding
On Mon, Aug 25, 2014 at 01:54:54PM +0200, Alexandre Belloni wrote: > Hi, > > On 25/08/2014 at 12:15:23 +0200, Thierry Reding wrote : > > On Fri, Mar 14, 2014 at 08:05:31PM +0100, Alexandre Belloni wrote: > > > pwm-leds calls .config() and .disable() in a row. This exhibits that it > > > may > >

Re: [PATCH] PWM: atmel: fix incorrect CDTY value after enabling or disabling

2014-08-25 Thread Alexandre Belloni
Hi, On 25/08/2014 at 12:15:23 +0200, Thierry Reding wrote : > On Fri, Mar 14, 2014 at 08:05:31PM +0100, Alexandre Belloni wrote: > > pwm-leds calls .config() and .disable() in a row. This exhibits that it may > > happen that the channel gets disabled before CDTY has been updated with > > CUPD. >

Re: [PATCH] PWM: atmel: fix incorrect CDTY value after enabling or disabling

2014-08-25 Thread Thierry Reding
On Fri, Mar 14, 2014 at 08:05:31PM +0100, Alexandre Belloni wrote: > pwm-leds calls .config() and .disable() in a row. This exhibits that it may > happen that the channel gets disabled before CDTY has been updated with CUPD. > The issue gets quite worse with long periods. > So, ensure by reading

Re: [PATCH] PWM: atmel: fix incorrect CDTY value after enabling or disabling

2014-08-25 Thread Thierry Reding
On Fri, Mar 14, 2014 at 08:05:31PM +0100, Alexandre Belloni wrote: pwm-leds calls .config() and .disable() in a row. This exhibits that it may happen that the channel gets disabled before CDTY has been updated with CUPD. The issue gets quite worse with long periods. So, ensure by reading ISR

Re: [PATCH] PWM: atmel: fix incorrect CDTY value after enabling or disabling

2014-08-25 Thread Alexandre Belloni
Hi, On 25/08/2014 at 12:15:23 +0200, Thierry Reding wrote : On Fri, Mar 14, 2014 at 08:05:31PM +0100, Alexandre Belloni wrote: pwm-leds calls .config() and .disable() in a row. This exhibits that it may happen that the channel gets disabled before CDTY has been updated with CUPD. The

Re: [PATCH] PWM: atmel: fix incorrect CDTY value after enabling or disabling

2014-08-25 Thread Thierry Reding
On Mon, Aug 25, 2014 at 01:54:54PM +0200, Alexandre Belloni wrote: Hi, On 25/08/2014 at 12:15:23 +0200, Thierry Reding wrote : On Fri, Mar 14, 2014 at 08:05:31PM +0100, Alexandre Belloni wrote: pwm-leds calls .config() and .disable() in a row. This exhibits that it may happen that

[PATCH] PWM: atmel: fix incorrect CDTY value after enabling or disabling

2014-03-14 Thread Alexandre Belloni
pwm-leds calls .config() and .disable() in a row. This exhibits that it may happen that the channel gets disabled before CDTY has been updated with CUPD. The issue gets quite worse with long periods. So, ensure by reading ISR that at least one period has past before disabling the channel. The

[PATCH] PWM: atmel: fix incorrect CDTY value after enabling or disabling

2014-03-14 Thread Alexandre Belloni
pwm-leds calls .config() and .disable() in a row. This exhibits that it may happen that the channel gets disabled before CDTY has been updated with CUPD. The issue gets quite worse with long periods. So, ensure by reading ISR that at least one period has past before disabling the channel. The