Re: [PATCH] Releasing resources with children

2005-03-14 Thread Ingo Oeser
Russell King wrote: > The only thing I'd question is whether we really need to BUG_ON() here. > ISTR Linus' policy for BUG()/BUG_ON() was only if the condition lead > directly to a filesystem-corrupting bug. I consider it quite effective to flag interface violations. Programming by contract anyone

Re: [PATCH] Releasing resources with children

2005-03-14 Thread Russell King
On Mon, Mar 14, 2005 at 10:49:16AM -0700, Matthew Wilcox wrote: > What does it mean to release a resource with children? Should the > children become children of the released resource's parent? Should they > be released too? Should we fail the release? I've been running kernels with: + i

[PATCH] Releasing resources with children

2005-03-14 Thread Matthew Wilcox
Releasing resources with children What does it mean to release a resource with children? Should the children become children of the released resource's parent? Should they be released too? Should we fail the release? I bet we have no callers who expect this right now, but with insert_resource(