Re: [PATCH] Repair misuse of sv_lock in 5.10.16-rt30.

2021-02-26 Thread Chuck Lever
> On Feb 26, 2021, at 10:19 AM, Joe Korty wrote: > > On Fri, Feb 26, 2021 at 03:15:46PM +, Chuck Lever wrote: >> >> >>> On Feb 26, 2021, at 10:00 AM, J. Bruce Fields wrote: >>> >>> Adding Chuck, linux-nfs. >>> >>> Makes sense to me.--b. >> >> Joe, I can add this to nfsd-5.12-rc.

Re: [PATCH] Repair misuse of sv_lock in 5.10.16-rt30.

2021-02-26 Thread Joe Korty
On Fri, Feb 26, 2021 at 03:15:46PM +, Chuck Lever wrote: > > > > On Feb 26, 2021, at 10:00 AM, J. Bruce Fields wrote: > > > > Adding Chuck, linux-nfs. > > > > Makes sense to me.--b. > > Joe, I can add this to nfsd-5.12-rc. Would it be appropriate to add: > > Fixes: 719f8bcc883e

Re: [PATCH] Repair misuse of sv_lock in 5.10.16-rt30.

2021-02-26 Thread Chuck Lever
> On Feb 26, 2021, at 10:00 AM, J. Bruce Fields wrote: > > Adding Chuck, linux-nfs. > > Makes sense to me.--b. Joe, I can add this to nfsd-5.12-rc. Would it be appropriate to add: Fixes: 719f8bcc883e ("svcrpc: fix xpt_list traversal locking on shutdown") > On Fri, Feb 26, 2021 at

Re: [PATCH] Repair misuse of sv_lock in 5.10.16-rt30.

2021-02-26 Thread J. Bruce Fields
Adding Chuck, linux-nfs. Makes sense to me.--b. On Fri, Feb 26, 2021 at 09:38:20AM -0500, Joe Korty wrote: > Repair misuse of sv_lock in 5.10.16-rt30. > > [ This problem is in mainline, but only rt has the chops to be > able to detect it. ] > > Lockdep reports a circular lock dependency

[PATCH] Repair misuse of sv_lock in 5.10.16-rt30.

2021-02-26 Thread Joe Korty
Repair misuse of sv_lock in 5.10.16-rt30. [ This problem is in mainline, but only rt has the chops to be able to detect it. ] Lockdep reports a circular lock dependency between serv->sv_lock and softirq_ctl.lock on system shutdown, when using a kernel built with CONFIG_PREEMPT_RT=y, and a nfs