Re: [PATCH] Revert "NFS: readdirplus optimization by cache mechanism" (memleak)

2019-07-12 Thread Trond Myklebust
On Fri, 2019-07-12 at 17:28 +0200, Greg KH wrote: > On Fri, Jul 12, 2019 at 04:18:06PM +0200, Max Kellermann wrote: > > This reverts commit be4c2d4723a4a637f0d1b4f7c66447141a4b3564. > > > > That commit caused a severe memory leak in nfs_readdir_make_qstr(). > > > > When listing a directory with

Re: [PATCH] Revert "NFS: readdirplus optimization by cache mechanism" (memleak)

2019-07-12 Thread Greg KH
On Fri, Jul 12, 2019 at 04:18:06PM +0200, Max Kellermann wrote: > This reverts commit be4c2d4723a4a637f0d1b4f7c66447141a4b3564. > > That commit caused a severe memory leak in nfs_readdir_make_qstr(). > > When listing a directory with more than 100 files (this is how many > struct

[PATCH] Revert "NFS: readdirplus optimization by cache mechanism" (memleak)

2019-07-12 Thread Max Kellermann
This reverts commit be4c2d4723a4a637f0d1b4f7c66447141a4b3564. That commit caused a severe memory leak in nfs_readdir_make_qstr(). When listing a directory with more than 100 files (this is how many struct nfs_cache_array_entry elements fit in one 4kB page), all allocated file name strings past