Re: [PATCH] Revert "driver core: synchronize device shutdown"

2014-03-08 Thread Greg Kroah-Hartman
On Fri, Mar 07, 2014 at 06:30:49PM -0800, Arjan van de Ven wrote: > >> AFAICT the synchronization does nothing useful and is just a remnant > >> of a patch series where the real meat didn't get applied. But of > >> course it would be great if Shaohua could confirm my understanding. > > > > Shaohua

Re: [PATCH] Revert "driver core: synchronize device shutdown"

2014-03-07 Thread Arjan van de Ven
>> AFAICT the synchronization does nothing useful and is just a remnant >> of a patch series where the real meat didn't get applied. But of >> course it would be great if Shaohua could confirm my understanding. > > Shaohua's email address seems to now bounce :( > > Arjan, any thoughts? if there

Re: [PATCH] Revert "driver core: synchronize device shutdown"

2014-03-04 Thread Greg Kroah-Hartman
On Tue, Mar 04, 2014 at 08:15:36PM -0800, Roland Dreier wrote: > > Hm, no one seems to have said anything for the past 5 years about this. > > It definitely is hard to hit -- you have to do "shutdown" or "reboot" > right as something schedules async work. In our case we have some > systems with a

Re: [PATCH] Revert "driver core: synchronize device shutdown"

2014-03-04 Thread Roland Dreier
> Hm, no one seems to have said anything for the past 5 years about this. It definitely is hard to hit -- you have to do "shutdown" or "reboot" right as something schedules async work. In our case we have some systems with a large and slightly flaky SAS fabric, so there's a constant level of re-p

Re: [PATCH] Revert "driver core: synchronize device shutdown"

2014-03-04 Thread Greg Kroah-Hartman
On Tue, Mar 04, 2014 at 07:57:51PM -0800, Roland Dreier wrote: > From: Roland Dreier > > This reverts commit 401097ea4b89846d66ac78f7f108d49c2e922d9c. The > original changelog said: > > A patch series to make .shutdown execute asynchronously. Some drivers's > shutdown can take a lot of

[PATCH] Revert "driver core: synchronize device shutdown"

2014-03-04 Thread Roland Dreier
From: Roland Dreier This reverts commit 401097ea4b89846d66ac78f7f108d49c2e922d9c. The original changelog said: A patch series to make .shutdown execute asynchronously. Some drivers's shutdown can take a lot of time. The patches can help save some shutdown time. The patches use Ar