Re: [PATCH] Revert "leds: convert blink timer to workqueue"

2014-09-02 Thread Jiri Kosina
On Tue, 2 Sep 2014, Bryan Wu wrote: > On Tue, Sep 2, 2014 at 2:03 AM, Jiri Kosina wrote: > > This reverts commit 8b37e1bef5a6b60e949e28a4db3006e4b00bd758. > > > > It's broken as it changes led_blink_set() in a way that it can now sleep > > (while synchronously waiting for workqueue to be

Re: [PATCH] Revert "leds: convert blink timer to workqueue"

2014-09-02 Thread Josh Boyer
On Tue, Sep 2, 2014 at 1:02 PM, Bryan Wu wrote: > On Tue, Sep 2, 2014 at 2:03 AM, Jiri Kosina wrote: >> This reverts commit 8b37e1bef5a6b60e949e28a4db3006e4b00bd758. >> >> It's broken as it changes led_blink_set() in a way that it can now sleep >> (while synchronously waiting for workqueue to be

Re: [PATCH] Revert "leds: convert blink timer to workqueue"

2014-09-02 Thread Bryan Wu
On Tue, Sep 2, 2014 at 2:03 AM, Jiri Kosina wrote: > This reverts commit 8b37e1bef5a6b60e949e28a4db3006e4b00bd758. > > It's broken as it changes led_blink_set() in a way that it can now sleep > (while synchronously waiting for workqueue to be cancelled). That's a > problem, because it's possible

Re: [PATCH] Revert "leds: convert blink timer to workqueue"

2014-09-02 Thread Bryan Wu
On Tue, Sep 2, 2014 at 8:55 AM, Josh Boyer wrote: > On Tue, Sep 2, 2014 at 5:03 AM, Jiri Kosina wrote: >> This reverts commit 8b37e1bef5a6b60e949e28a4db3006e4b00bd758. >> >> It's broken as it changes led_blink_set() in a way that it can now sleep >> (while synchronously waiting for workqueue to

Re: [PATCH] Revert "leds: convert blink timer to workqueue"

2014-09-02 Thread Josh Boyer
On Tue, Sep 2, 2014 at 5:03 AM, Jiri Kosina wrote: > This reverts commit 8b37e1bef5a6b60e949e28a4db3006e4b00bd758. > > It's broken as it changes led_blink_set() in a way that it can now sleep > (while synchronously waiting for workqueue to be cancelled). That's a > problem, because it's possible

[PATCH] Revert "leds: convert blink timer to workqueue"

2014-09-02 Thread Jiri Kosina
This reverts commit 8b37e1bef5a6b60e949e28a4db3006e4b00bd758. It's broken as it changes led_blink_set() in a way that it can now sleep (while synchronously waiting for workqueue to be cancelled). That's a problem, because it's possible that this function gets called from atomic context

[PATCH] Revert leds: convert blink timer to workqueue

2014-09-02 Thread Jiri Kosina
This reverts commit 8b37e1bef5a6b60e949e28a4db3006e4b00bd758. It's broken as it changes led_blink_set() in a way that it can now sleep (while synchronously waiting for workqueue to be cancelled). That's a problem, because it's possible that this function gets called from atomic context

Re: [PATCH] Revert leds: convert blink timer to workqueue

2014-09-02 Thread Josh Boyer
On Tue, Sep 2, 2014 at 5:03 AM, Jiri Kosina jkos...@suse.cz wrote: This reverts commit 8b37e1bef5a6b60e949e28a4db3006e4b00bd758. It's broken as it changes led_blink_set() in a way that it can now sleep (while synchronously waiting for workqueue to be cancelled). That's a problem, because it's

Re: [PATCH] Revert leds: convert blink timer to workqueue

2014-09-02 Thread Bryan Wu
On Tue, Sep 2, 2014 at 8:55 AM, Josh Boyer jwbo...@fedoraproject.org wrote: On Tue, Sep 2, 2014 at 5:03 AM, Jiri Kosina jkos...@suse.cz wrote: This reverts commit 8b37e1bef5a6b60e949e28a4db3006e4b00bd758. It's broken as it changes led_blink_set() in a way that it can now sleep (while

Re: [PATCH] Revert leds: convert blink timer to workqueue

2014-09-02 Thread Bryan Wu
On Tue, Sep 2, 2014 at 2:03 AM, Jiri Kosina jkos...@suse.cz wrote: This reverts commit 8b37e1bef5a6b60e949e28a4db3006e4b00bd758. It's broken as it changes led_blink_set() in a way that it can now sleep (while synchronously waiting for workqueue to be cancelled). That's a problem, because it's

Re: [PATCH] Revert leds: convert blink timer to workqueue

2014-09-02 Thread Josh Boyer
On Tue, Sep 2, 2014 at 1:02 PM, Bryan Wu coolo...@gmail.com wrote: On Tue, Sep 2, 2014 at 2:03 AM, Jiri Kosina jkos...@suse.cz wrote: This reverts commit 8b37e1bef5a6b60e949e28a4db3006e4b00bd758. It's broken as it changes led_blink_set() in a way that it can now sleep (while synchronously

Re: [PATCH] Revert leds: convert blink timer to workqueue

2014-09-02 Thread Jiri Kosina
On Tue, 2 Sep 2014, Bryan Wu wrote: On Tue, Sep 2, 2014 at 2:03 AM, Jiri Kosina jkos...@suse.cz wrote: This reverts commit 8b37e1bef5a6b60e949e28a4db3006e4b00bd758. It's broken as it changes led_blink_set() in a way that it can now sleep (while synchronously waiting for workqueue to be